Re: [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval

[Paul Cercueil <paul@crapouillou.net>]

Hi Chris,

Le lun., juin 27 2022 at 17:14:42 -0500, Chris Morgan 
<macroalpha82@gmail.com> a écrit :
> Add poll-interval support for the adc-joystick documentation. This is
> an optional value and if not provided the adc-joystick works as it
> does today (with triggered buffers). If this value is provided, the
> adc-joystick driver is polled at the specified interval.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/input/adc-joystick.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git 
> a/Documentation/devicetree/bindings/input/adc-joystick.yaml 
> b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> index 2ee04e03bc22..2d755091e46d 100644
> --- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
> +++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
> @@ -18,6 +18,12 @@ properties:
>    compatible:
>      const: adc-joystick
> 
> +  poll-interval:
> +    description:
> +      Poll interval time in milliseconds. If not specified, device 
> will use
> +      triggered buffer.

It doesn't have to use *triggered* buffer - it can use regular buffer 
as well.

The property should use a unit suffix, as explained here:
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml

So it should be named poll-interval-ms.

Cheers,
-Paul

> +    $ref: /schemas/types.yaml#/definitions/uint32
> +
>    io-channels:
>      minItems: 1
>      maxItems: 1024
> --
> 2.34.1
>