From: Artur Rojek <contact@artur-rojek.eu>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-input@vger.kernel.org, devicetree@vger.kernel.org,
maccraft123mc@gmail.com, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
dmitry.torokhov@gmail.com, paul@crapouillou.net,
jic23@kernel.org, linux-iio@vger.kernel.org,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v4 2/3] Input: adc-joystick - Add polled input device support
Date: Tue, 28 Jun 2022 00:45:59 +0200 [thread overview]
Message-ID: <c1edc707902248dde5ae6717aa9a27a0@artur-rojek.eu> (raw)
In-Reply-To: <20220627221444.3638-3-macroalpha82@gmail.com>
On 2022-06-28 00:14, Chris Morgan wrote:
> Add polled input device support to the adc-joystick driver. This is
> useful for devices which do not have hardware capable triggers on
> their SARADC. Code modified from adc-joystick.c changes made by Maya
> Matuszczyk.
>
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
Hey Chris,
comments inline.
> drivers/input/joystick/adc-joystick.c | 49 +++++++++++++++++++++------
> 1 file changed, 38 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/input/joystick/adc-joystick.c
> b/drivers/input/joystick/adc-joystick.c
> index 78ebca7d400a..7e3c5083ec3c 100644
> --- a/drivers/input/joystick/adc-joystick.c
> +++ b/drivers/input/joystick/adc-joystick.c
> @@ -26,8 +26,23 @@ struct adc_joystick {
> struct adc_joystick_axis *axes;
> struct iio_channel *chans;
> int num_chans;
> + bool polled;
> };
>
> +static void adc_joystick_poll(struct input_dev *input)
> +{
> + struct adc_joystick *joy = input_get_drvdata(input);
> + int i, val, ret;
> +
> + for (i = 0; i < joy->num_chans; i++) {
> + ret = iio_read_channel_raw(&joy->chans[i], &val);
> + if (ret < 0)
> + return;
> + input_report_abs(input, joy->axes[i].code, val);
> + }
> + input_sync(input);
> +}
> +
> static int adc_joystick_handle(const void *data, void *private)
> {
> struct adc_joystick *joy = private;
> @@ -179,6 +194,7 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> int error;
> int bits;
> int i;
> + int value;
This name is not self-describing. How about `poll_interval` instead?
>
> joy = devm_kzalloc(dev, sizeof(*joy), GFP_KERNEL);
> if (!joy)
> @@ -215,8 +231,15 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> joy->input = input;
> input->name = pdev->name;
> input->id.bustype = BUS_HOST;
> - input->open = adc_joystick_open;
> - input->close = adc_joystick_close;
> +
> + if (!device_property_read_u32(dev, "poll-interval", &value)) {
> + joy->polled = 1;
> + input_setup_polling(input, adc_joystick_poll);
> + input_set_poll_interval(input, value);
> + } else {
> + input->open = adc_joystick_open;
> + input->close = adc_joystick_close;
> + }
Let's move the polling setup logic for after you establish the value of
`joy->polled`:
```
joy->polled = !device_property_read_u32(dev, "poll-interval",
&poll_interval);
if (joy->polled) {
input_setup_polling(input, adc_joystick_poll);
input_set_poll_interval(input, poll_interval);
} else {
input->open = adc_joystick_open;
input->close = adc_joystick_close;
}
```
This makes the intention more clear and is consistent with the `if
(!joy->polled)` check later on.
Cheers,
Artur
>
> error = adc_joystick_set_axes(dev, joy);
> if (error)
> @@ -229,16 +252,20 @@ static int adc_joystick_probe(struct
> platform_device *pdev)
> return error;
> }
>
> - joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle, joy);
> - if (IS_ERR(joy->buffer)) {
> - dev_err(dev, "Unable to allocate callback buffer\n");
> - return PTR_ERR(joy->buffer);
> - }
> + if (!joy->polled) {
> + joy->buffer = iio_channel_get_all_cb(dev, adc_joystick_handle,
> + joy);
> + if (IS_ERR(joy->buffer)) {
> + dev_err(dev, "Unable to allocate callback buffer\n");
> + return PTR_ERR(joy->buffer);
> + }
>
> - error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> joy->buffer);
> - if (error) {
> - dev_err(dev, "Unable to add action\n");
> - return error;
> + error = devm_add_action_or_reset(dev, adc_joystick_cleanup,
> + joy->buffer);
> + if (error) {
> + dev_err(dev, "Unable to add action\n");
> + return error;
> + }
> }
>
> return 0;
next prev parent reply other threads:[~2022-06-27 22:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 22:14 [PATCH v4 0/3] adc-joystick: Add polled support Chris Morgan
2022-06-27 22:14 ` [PATCH v4 1/3] dt-bindings: adc-joystick: add poll-interval Chris Morgan
2022-06-27 22:33 ` Paul Cercueil
2022-06-27 22:41 ` Chris Morgan
2022-06-27 22:47 ` Paul Cercueil
2022-06-30 15:08 ` Rob Herring
2022-06-30 15:11 ` Rob Herring
2022-06-27 22:14 ` [PATCH v4 2/3] Input: adc-joystick - Add polled input device support Chris Morgan
2022-06-27 22:45 ` Artur Rojek [this message]
2022-06-27 22:14 ` [PATCH v4 3/3] arm64: dts: rockchip: Update joystick to polled for Odroid-Go2 Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1edc707902248dde5ae6717aa9a27a0@artur-rojek.eu \
--to=contact@artur-rojek.eu \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=heiko@sntech.de \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=maccraft123mc@gmail.com \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).