* [PATCH] counter: 104-quad-8: Fix Synapse action reported for Index signals
@ 2023-03-16 20:34 William Breathitt Gray
2023-03-18 13:28 ` William Breathitt Gray
0 siblings, 1 reply; 2+ messages in thread
From: William Breathitt Gray @ 2023-03-16 20:34 UTC (permalink / raw)
To: linux-iio; +Cc: linux-kernel, William Breathitt Gray, stable
Signal 16 and higher represent the device's Index lines. The
priv->preset_enable array holds the device configuration for these Index
lines. The preset_enable configuration is active low on the device, so
invert the conditional check in quad8_action_read() to properly handle
the logical state of preset_enable.
Fixes: f1d8a071d45b ("counter: 104-quad-8: Add Generic Counter interface support")
Cc: <stable@vger.kernel.org>
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
---
drivers/counter/104-quad-8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index deed4afadb29..529bce4ee631 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -378,7 +378,7 @@ static int quad8_action_read(struct counter_device *counter,
/* Handle Index signals */
if (synapse->signal->id >= 16) {
- if (priv->preset_enable[count->id])
+ if (!priv->preset_enable[count->id])
*action = COUNTER_SYNAPSE_ACTION_RISING_EDGE;
else
*action = COUNTER_SYNAPSE_ACTION_NONE;
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] counter: 104-quad-8: Fix Synapse action reported for Index signals
2023-03-16 20:34 [PATCH] counter: 104-quad-8: Fix Synapse action reported for Index signals William Breathitt Gray
@ 2023-03-18 13:28 ` William Breathitt Gray
0 siblings, 0 replies; 2+ messages in thread
From: William Breathitt Gray @ 2023-03-18 13:28 UTC (permalink / raw)
To: William Breathitt Gray; +Cc: linux-iio, linux-kernel, stable
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
On Thu, Mar 16, 2023 at 04:34:26PM -0400, William Breathitt Gray wrote:
> Signal 16 and higher represent the device's Index lines. The
> priv->preset_enable array holds the device configuration for these Index
> lines. The preset_enable configuration is active low on the device, so
> invert the conditional check in quad8_action_read() to properly handle
> the logical state of preset_enable.
>
> Fixes: f1d8a071d45b ("counter: 104-quad-8: Add Generic Counter interface support")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
Applied to counter-fixes.
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-18 13:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-16 20:34 [PATCH] counter: 104-quad-8: Fix Synapse action reported for Index signals William Breathitt Gray
2023-03-18 13:28 ` William Breathitt Gray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).