From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>,
<linux-iio@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <jic23@kernel.org>, <mcoquelin.stm32@gmail.com>,
<alexandre.torgue@st.com>, <olivier.moysan@st.com>,
Sergiu Cuciurean <sergiu.cuciurean@analog.com>
Subject: Re: [PATCH v2] iio: stm32-dac: Replace indio_dev->mlock with own device lock
Date: Wed, 16 Sep 2020 12:18:02 +0200 [thread overview]
Message-ID: <b8d5cbb5-f393-6a5f-19cd-afa983b9f10a@st.com> (raw)
In-Reply-To: <20200916092349.75647-1-alexandru.ardelean@analog.com>
On 9/16/20 11:23 AM, Alexandru Ardelean wrote:
> From: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
>
> As part of the general cleanup of indio_dev->mlock, this change replaces
> it with a local lock. The lock protects against potential races when
> reading the CR reg and then updating, so that the state of pm_runtime
> is consistent between the two operations.
>
> This is part of a bigger cleanup.
> Link: https://lore.kernel.org/linux-iio/CA+U=Dsoo6YABe5ODLp+eFNPGFDjk5ZeQEceGkqjxXcVEhLWubw@mail.gmail.com/
>
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> ---
> drivers/iio/dac/stm32-dac.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
Hi Alexandru,
Many thanks for this updated patch,
Reviewed-by: Fabrice Gasnier <fabrice.gasnier@st.com>
Best regards,
Fabrice
>
> diff --git a/drivers/iio/dac/stm32-dac.c b/drivers/iio/dac/stm32-dac.c
> index 092c796fa3d9..12dec68c16f7 100644
> --- a/drivers/iio/dac/stm32-dac.c
> +++ b/drivers/iio/dac/stm32-dac.c
> @@ -26,9 +26,12 @@
> /**
> * struct stm32_dac - private data of DAC driver
> * @common: reference to DAC common data
> + * @lock: lock to protect against potential races when reading
> + * and update CR, to keep it in sync with pm_runtime
> */
> struct stm32_dac {
> struct stm32_dac_common *common;
> + struct mutex lock;
> };
>
> static int stm32_dac_is_enabled(struct iio_dev *indio_dev, int channel)
> @@ -58,10 +61,10 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
> int ret;
>
> /* already enabled / disabled ? */
> - mutex_lock(&indio_dev->mlock);
> + mutex_lock(&dac->lock);
> ret = stm32_dac_is_enabled(indio_dev, ch);
> if (ret < 0 || enable == !!ret) {
> - mutex_unlock(&indio_dev->mlock);
> + mutex_unlock(&dac->lock);
> return ret < 0 ? ret : 0;
> }
>
> @@ -69,13 +72,13 @@ static int stm32_dac_set_enable_state(struct iio_dev *indio_dev, int ch,
> ret = pm_runtime_get_sync(dev);
> if (ret < 0) {
> pm_runtime_put_noidle(dev);
> - mutex_unlock(&indio_dev->mlock);
> + mutex_unlock(&dac->lock);
> return ret;
> }
> }
>
> ret = regmap_update_bits(dac->common->regmap, STM32_DAC_CR, msk, en);
> - mutex_unlock(&indio_dev->mlock);
> + mutex_unlock(&dac->lock);
> if (ret < 0) {
> dev_err(&indio_dev->dev, "%s failed\n", en ?
> "Enable" : "Disable");
> @@ -327,6 +330,8 @@ static int stm32_dac_probe(struct platform_device *pdev)
> indio_dev->info = &stm32_dac_iio_info;
> indio_dev->modes = INDIO_DIRECT_MODE;
>
> + mutex_init(&dac->lock);
> +
> ret = stm32_dac_chan_of_init(indio_dev);
> if (ret < 0)
> return ret;
>
next prev parent reply other threads:[~2020-09-16 20:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 6:38 [PATCH] iio: stm32-dac: Replace indio_dev->mlock with own device lock Alexandru Ardelean
2020-08-26 8:57 ` Fabrice Gasnier
2020-08-26 10:01 ` Alexandru Ardelean
2020-08-26 12:00 ` [PATCH v2] " Alexandru Ardelean
2020-08-27 8:55 ` Alexandru Ardelean
2020-08-27 9:03 ` Fabrice Gasnier
2020-08-27 10:00 ` Alexandru Ardelean
2020-08-29 15:46 ` Jonathan Cameron
2020-09-02 6:12 ` Alexandru Ardelean
2020-09-16 9:23 ` Alexandru Ardelean
2020-09-16 10:18 ` Fabrice Gasnier [this message]
2020-09-16 17:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8d5cbb5-f393-6a5f-19cd-afa983b9f10a@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=alexandru.ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=sergiu.cuciurean@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).