Linux-IIO Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long
@ 2019-11-05 20:28 Colin King
  2019-11-06 14:19 ` Sa, Nuno
  0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2019-11-05 20:28 UTC (permalink / raw)
  To: Nuno Sá,
	Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen,
	Peter Meerwald-Stadler, linux-iio
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Currently the read of temp using of_property_read_u32_index is reading
a u32 value into a unsigned long long.  This relies on machine endianness
to work correctly, so fix this by reading a u32 value and setting temp
to this value.

Addresses-Coverity: ("Reliance on integer endianness")
Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/iio/temperature/ltc2983.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index ddf47023364b..d39c0d6b77f1 100644
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -444,8 +444,10 @@ static struct ltc2983_custom_sensor *__ltc2983_custom_sensor_new(
 			else
 				temp = __convert_to_raw(temp, resolution);
 		} else {
-			of_property_read_u32_index(np, propname, index,
-						   (u32 *)&temp);
+			u32 t32;
+
+			of_property_read_u32_index(np, propname, index, &t32);
+			temp = t32;
 		}
 
 		for (j = 0; j < n_size; j++)
-- 
2.20.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long
  2019-11-05 20:28 [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long Colin King
@ 2019-11-06 14:19 ` Sa, Nuno
  2019-11-10 11:48   ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Sa, Nuno @ 2019-11-06 14:19 UTC (permalink / raw)
  To: linux-iio, Jonathan.Cameron, colin.king, knaack.h, pmeerw, lars
  Cc: kernel-janitors, linux-kernel

On Tue, 2019-11-05 at 20:28 +0000, Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the read of temp using of_property_read_u32_index is
> reading
> a u32 value into a unsigned long long.  This relies on machine
> endianness
> to work correctly, so fix this by reading a u32 value and setting
> temp
> to this value.
> 
> Addresses-Coverity: ("Reliance on integer endianness")
> Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/iio/temperature/ltc2983.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/temperature/ltc2983.c
> b/drivers/iio/temperature/ltc2983.c
> index ddf47023364b..d39c0d6b77f1 100644
> --- a/drivers/iio/temperature/ltc2983.c
> +++ b/drivers/iio/temperature/ltc2983.c
> @@ -444,8 +444,10 @@ static struct ltc2983_custom_sensor
> *__ltc2983_custom_sensor_new(
>  			else
>  				temp = __convert_to_raw(temp,
> resolution);
>  		} else {
> -			of_property_read_u32_index(np, propname, index,
> -						   (u32 *)&temp);
> +			u32 t32;
> +
> +			of_property_read_u32_index(np, propname, index,
> &t32);
> +			temp = t32;
>  		}
>  
>  		for (j = 0; j < n_size; j++)

Acked-by: Nuno Sá <nuno.sa@analog.com>

Thanks,
Nuno Sá

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long
  2019-11-06 14:19 ` Sa, Nuno
@ 2019-11-10 11:48   ` Jonathan Cameron
  2019-11-16 15:15     ` Jonathan Cameron
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2019-11-10 11:48 UTC (permalink / raw)
  To: Sa, Nuno
  Cc: linux-iio, Jonathan.Cameron, colin.king, knaack.h, pmeerw, lars,
	kernel-janitors, linux-kernel

On Wed, 6 Nov 2019 14:19:52 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> On Tue, 2019-11-05 at 20:28 +0000, Colin King wrote:
> > 
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > Currently the read of temp using of_property_read_u32_index is
> > reading
> > a u32 value into a unsigned long long.  This relies on machine
> > endianness
> > to work correctly, so fix this by reading a u32 value and setting
> > temp
> > to this value.
> > 
> > Addresses-Coverity: ("Reliance on integer endianness")
> > Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> >  drivers/iio/temperature/ltc2983.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/iio/temperature/ltc2983.c
> > b/drivers/iio/temperature/ltc2983.c
> > index ddf47023364b..d39c0d6b77f1 100644
> > --- a/drivers/iio/temperature/ltc2983.c
> > +++ b/drivers/iio/temperature/ltc2983.c
> > @@ -444,8 +444,10 @@ static struct ltc2983_custom_sensor
> > *__ltc2983_custom_sensor_new(
> >  			else
> >  				temp = __convert_to_raw(temp,
> > resolution);
> >  		} else {
> > -			of_property_read_u32_index(np, propname, index,
> > -						   (u32 *)&temp);
> > +			u32 t32;
> > +
> > +			of_property_read_u32_index(np, propname, index,
> > &t32);
> > +			temp = t32;
> >  		}
> >  
> >  		for (j = 0; j < n_size; j++)  
> 
> Acked-by: Nuno Sá <nuno.sa@analog.com>
> 

A slight complexity around this one. I'm not sure I'll have time for a pull
before the merge window (as Greg will only take them to about 1 week before
that opens so we get some exposure in Linux next).

As a result I'll have to sit on this one until Linus comments on rc7, probably
later today.  Otherwise it'll be material for stable post release.

If I seem to have lost it give me a poke and we'll make sure it goes into 
an early rc instead of at the merge window.

Thanks,

Jonathan

> Thanks,
> Nuno Sá


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long
  2019-11-10 11:48   ` Jonathan Cameron
@ 2019-11-16 15:15     ` Jonathan Cameron
  0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2019-11-16 15:15 UTC (permalink / raw)
  To: Sa, Nuno
  Cc: linux-iio, Jonathan.Cameron, colin.king, knaack.h, pmeerw, lars,
	kernel-janitors, linux-kernel

On Sun, 10 Nov 2019 11:48:23 +0000
Jonathan Cameron <jic23@kernel.org> wrote:

> On Wed, 6 Nov 2019 14:19:52 +0000
> "Sa, Nuno" <Nuno.Sa@analog.com> wrote:
> 
> > On Tue, 2019-11-05 at 20:28 +0000, Colin King wrote:  
> > > 
> > > From: Colin Ian King <colin.king@canonical.com>
> > > 
> > > Currently the read of temp using of_property_read_u32_index is
> > > reading
> > > a u32 value into a unsigned long long.  This relies on machine
> > > endianness
> > > to work correctly, so fix this by reading a u32 value and setting
> > > temp
> > > to this value.
> > > 
> > > Addresses-Coverity: ("Reliance on integer endianness")
> > > Fixes: f110f3188e56 ("iio: temperature: Add support for LTC2983")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > >  drivers/iio/temperature/ltc2983.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/drivers/iio/temperature/ltc2983.c
> > > b/drivers/iio/temperature/ltc2983.c
> > > index ddf47023364b..d39c0d6b77f1 100644
> > > --- a/drivers/iio/temperature/ltc2983.c
> > > +++ b/drivers/iio/temperature/ltc2983.c
> > > @@ -444,8 +444,10 @@ static struct ltc2983_custom_sensor
> > > *__ltc2983_custom_sensor_new(
> > >  			else
> > >  				temp = __convert_to_raw(temp,
> > > resolution);
> > >  		} else {
> > > -			of_property_read_u32_index(np, propname, index,
> > > -						   (u32 *)&temp);
> > > +			u32 t32;
> > > +
> > > +			of_property_read_u32_index(np, propname, index,
> > > &t32);
> > > +			temp = t32;
> > >  		}
> > >  
> > >  		for (j = 0; j < n_size; j++)    
> > 
> > Acked-by: Nuno Sá <nuno.sa@analog.com>
> >   
> 
> A slight complexity around this one. I'm not sure I'll have time for a pull
> before the merge window (as Greg will only take them to about 1 week before
> that opens so we get some exposure in Linux next).
> 
> As a result I'll have to sit on this one until Linus comments on rc7, probably
> later today.  Otherwise it'll be material for stable post release.
> 
> If I seem to have lost it give me a poke and we'll make sure it goes into 
> an early rc instead of at the merge window.
I forgot about it when I sent the final pull request out.  Sorry about that,
will have to wait for post merge window.

Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> 
> Thanks,
> 
> Jonathan
> 
> > Thanks,
> > Nuno Sá  
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 20:28 [PATCH] iio: temperature: ltc2983: fix u32 read into a unsigned long long Colin King
2019-11-06 14:19 ` Sa, Nuno
2019-11-10 11:48   ` Jonathan Cameron
2019-11-16 15:15     ` Jonathan Cameron

Linux-IIO Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-iio/0 linux-iio/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-iio linux-iio/ https://lore.kernel.org/linux-iio \
		linux-iio@vger.kernel.org
	public-inbox-index linux-iio

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-iio


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git