From: Luca Ceresoli <luca@lucaceresoli.net>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-clk <linux-clk@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-spi <linux-spi@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"open list:REMOTE PROCESSOR (REMOTEPROC) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
Linux HWMON List <linux-hwmon@vger.kernel.org>,
Linux I2C <linux-i2c@vger.kernel.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
Linux Input <linux-input@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
MTD Maling List <linux-mtd@lists.infradead.org>,
netdev <netdev@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux USB List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files
Date: Fri, 14 Aug 2020 18:30:17 +0200 [thread overview]
Message-ID: <f1963eb9-283f-e903-2a3a-4f324d71d418@lucaceresoli.net> (raw)
In-Reply-To: <CAL_JsqKekx0VO4NROwLrgrU8+L584HaLHM9i3kCZvU+g5myeGw@mail.gmail.com>
Hi,
On 14/08/20 16:51, Rob Herring wrote:
> On Thu, Aug 13, 2020 at 4:31 AM Luca Ceresoli <luca@lucaceresoli.net> wrote:
>>
>> Hi Rob,
>>
>> On 12/08/20 22:36, Rob Herring wrote:
>>> Clean-up incorrect indentation, extra spaces, long lines, and missing
>>> EOF newline in schema files. Most of the clean-ups are for list
>>> indentation which should always be 2 spaces more than the preceding
>>> keyword.
>>>
>>> Found with yamllint (which I plan to integrate into the checks).
>>
>> [...]
>>
>>> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> index 3d4e1685cc55..28c6461b9a9a 100644
>>> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
>>> @@ -95,10 +95,10 @@ allOf:
>>> # Devices without builtin crystal
>>> properties:
>>> clock-names:
>>> - minItems: 1
>>> - maxItems: 2
>>> - items:
>>> - enum: [ xin, clkin ]
>>> + minItems: 1
>>> + maxItems: 2
>>> + items:
>>> + enum: [ xin, clkin ]
>>> clocks:
>>> minItems: 1
>>> maxItems: 2
>>
>> Thanks for noticing, LGTM.
>>
>> [...]
>>
>>> diff --git a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
>>> index d7dac16a3960..36dc7b56a453 100644
>>> --- a/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
>>> +++ b/Documentation/devicetree/bindings/input/touchscreen/touchscreen.yaml
>>> @@ -33,8 +33,8 @@ properties:
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>>
>>> touchscreen-min-pressure:
>>> - description: minimum pressure on the touchscreen to be achieved in order for the
>>> - touchscreen driver to report a touch event.
>>> + description: minimum pressure on the touchscreen to be achieved in order
>>> + for the touchscreen driver to report a touch event.
>>
>> Out of personal taste, I find the original layout more pleasant and
>> readable. This third option is also good, especially for long descriptions:
>>
>> description:
>> minimum pressure on the touchscreen to be achieved in order for the
>> touchscreen driver to report a touch event.
>>
>> At first glance yamllint seems to support exactly these two by default:
>>
>>> With indentation: {spaces: 4, check-multi-line-strings: true}
>
> Turning on check-multi-line-strings results in 10K+ warnings, so no.
>
> The other issue is the style ruamel.yaml wants to write out is as the
> patch does above. This matters when doing some scripted
> transformations where we read in the files and write them back out. I
> can somewhat work around that by first doing a pass with no changes
> and then another pass with the actual changes, but that's completely
> scriptable. Hopefully, ruamel learns to preserve the style better.
Kind of sad, but I understand the reason as far as my understanding of
the yaml world allows. Thanks for the explanation.
[For idt,versaclock5.yaml, plus an overview of whole patch]
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
next prev parent reply other threads:[~2020-08-14 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200812203618.2656699-1-robh@kernel.org>
2020-08-12 21:34 ` [PATCH] dt-bindings: Whitespace clean-ups in schema files Sam Ravnborg
2020-08-12 22:41 ` Rob Herring
2020-08-16 8:44 ` Jonathan Cameron
2020-08-12 22:32 ` Joe Perches
2020-08-12 23:05 ` Rob Herring
2020-08-13 7:50 ` Geert Uytterhoeven
2020-08-13 10:31 ` Luca Ceresoli
2020-08-14 14:51 ` Rob Herring
2020-08-14 16:30 ` Luca Ceresoli [this message]
2020-08-25 7:10 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1963eb9-283f-e903-2a3a-4f324d71d418@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).