* [PATCH] hid: remove NO_D3 flag for ish not CHV platform
@ 2019-05-17 8:46 hongyan.song
2019-05-22 10:36 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: hongyan.song @ 2019-05-17 8:46 UTC (permalink / raw)
To: jikos, jic23, linux-iio, linux-input
Cc: srinivas.pandruvada, hdegoede, even.xu
From: Song Hongyan <hongyan.song@intel.com>
NO_D3 flag is set for CHV and the older platforms, the other platform
suppose can enter D3, if have this NO_D3 flag set it can never enter D3
Signed-off-by: Song Hongyan <hongyan.song@intel.com>
---
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
index a6e1ee7..de1459b 100644
--- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
+++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
@@ -154,7 +154,9 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
/* mapping IO device memory */
hw->mem_addr = pcim_iomap_table(pdev)[0];
ishtp->pdev = pdev;
- pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
+ /*This NO_D3 flag is only for CHV and older platforms*/
+ if (pdev->device == CHV_DEVICE_ID)
+ pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
/* request and enable interrupt */
ret = pci_alloc_irq_vectors(pdev, 1, 1, PCI_IRQ_ALL_TYPES);
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] hid: remove NO_D3 flag for ish not CHV platform
2019-05-17 8:46 [PATCH] hid: remove NO_D3 flag for ish not CHV platform hongyan.song
@ 2019-05-22 10:36 ` Jiri Kosina
2019-05-22 18:04 ` Pandruvada, Srinivas
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2019-05-22 10:36 UTC (permalink / raw)
To: hongyan.song
Cc: jic23, linux-iio, linux-input, srinivas.pandruvada, hdegoede, even.xu
On Fri, 17 May 2019, hongyan.song@intel.com wrote:
> From: Song Hongyan <hongyan.song@intel.com>
>
> NO_D3 flag is set for CHV and the older platforms, the other platform
> suppose can enter D3, if have this NO_D3 flag set it can never enter D3
Could you please provide a little bit more descriptive changelog -- namely
what observable problem is it fixing.
> Signed-off-by: Song Hongyan <hongyan.song@intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index a6e1ee7..de1459b 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -154,7 +154,9 @@ static int ish_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> /* mapping IO device memory */
> hw->mem_addr = pcim_iomap_table(pdev)[0];
> ishtp->pdev = pdev;
> - pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
> + /*This NO_D3 flag is only for CHV and older platforms*/
... and while you're updating the changelog, please also stick a space
before and after the comment mark.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hid: remove NO_D3 flag for ish not CHV platform
2019-05-22 10:36 ` Jiri Kosina
@ 2019-05-22 18:04 ` Pandruvada, Srinivas
2019-05-24 9:10 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Pandruvada, Srinivas @ 2019-05-22 18:04 UTC (permalink / raw)
To: jikos, Song, Hongyan; +Cc: linux-input, hdegoede, linux-iio, jic23, Xu, Even
[-- Attachment #1: Type: text/plain, Size: 1514 bytes --]
On Wed, 2019-05-22 at 12:36 +0200, Jiri Kosina wrote:
> On Fri, 17 May 2019, hongyan.song@intel.com wrote:
>
> > From: Song Hongyan <hongyan.song@intel.com>
Also commit summary "hid: remove NO_D3 flag for non Cherry Trail (CHT)"
> >
> > NO_D3 flag is set for CHV and the older platforms, the other
> > platform
> > suppose can enter D3, if have this NO_D3 flag set it can never
> > enter D3
>
> Could you please provide a little bit more descriptive changelog --
> namely
> what observable problem is it fixing.
In addition, I don't think this is a rc2+ release fix.
Thanks,
Srinivas
>
> > Signed-off-by: Song Hongyan <hongyan.song@intel.com>
> > ---
> > drivers/hid/intel-ish-hid/ipc/pci-ish.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> > b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> > index a6e1ee7..de1459b 100644
> > --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> > +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> > @@ -154,7 +154,9 @@ static int ish_probe(struct pci_dev *pdev,
> > const struct pci_device_id *ent)
> > /* mapping IO device memory */
> > hw->mem_addr = pcim_iomap_table(pdev)[0];
> > ishtp->pdev = pdev;
> > - pdev->dev_flags |= PCI_DEV_FLAGS_NO_D3;
> > + /*This NO_D3 flag is only for CHV and older platforms*/
>
> ... and while you're updating the changelog, please also stick a
> space
> before and after the comment mark.
>
> Thanks,
>
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3290 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hid: remove NO_D3 flag for ish not CHV platform
2019-05-22 18:04 ` Pandruvada, Srinivas
@ 2019-05-24 9:10 ` Jiri Kosina
2019-05-29 3:27 ` Pandruvada, Srinivas
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2019-05-24 9:10 UTC (permalink / raw)
To: Pandruvada, Srinivas
Cc: Song, Hongyan, linux-input, hdegoede, linux-iio, jic23, Xu, Even
On Wed, 22 May 2019, Pandruvada, Srinivas wrote:
> > > From: Song Hongyan <hongyan.song@intel.com>
> Also commit summary "hid: remove NO_D3 flag for non Cherry Trail (CHT)"
>
> > >
> > > NO_D3 flag is set for CHV and the older platforms, the other
> > > platform
> > > suppose can enter D3, if have this NO_D3 flag set it can never
> > > enter D3
> >
> > Could you please provide a little bit more descriptive changelog --
> > namely
> > what observable problem is it fixing.
>
>
> In addition, I don't think this is a rc2+ release fix.
Thanks Srinivas. Could you please Ack v2 so that I could queue it?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] hid: remove NO_D3 flag for ish not CHV platform
2019-05-24 9:10 ` Jiri Kosina
@ 2019-05-29 3:27 ` Pandruvada, Srinivas
0 siblings, 0 replies; 5+ messages in thread
From: Pandruvada, Srinivas @ 2019-05-29 3:27 UTC (permalink / raw)
To: jikos; +Cc: linux-input, hdegoede, Song, Hongyan, linux-iio, jic23, Xu, Even
[-- Attachment #1: Type: text/plain, Size: 862 bytes --]
On Fri, 2019-05-24 at 11:10 +0200, Jiri Kosina wrote:
> On Wed, 22 May 2019, Pandruvada, Srinivas wrote:
>
> > > > From: Song Hongyan <hongyan.song@intel.com>
> >
> > Also commit summary "hid: remove NO_D3 flag for non Cherry Trail
> > (CHT)"
> >
> > > >
> > > > NO_D3 flag is set for CHV and the older platforms, the other
> > > > platform
> > > > suppose can enter D3, if have this NO_D3 flag set it can never
> > > > enter D3
> > >
> > > Could you please provide a little bit more descriptive changelog
> > > --
> > > namely
> > > what observable problem is it fixing.
> >
> >
> > In addition, I don't think this is a rc2+ release fix.
>
> Thanks Srinivas. Could you please Ack v2 so that I could queue it?
I want some more information in the commit and test information. So
Song will submit v3.
Thanks,
Srinivas
>
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3290 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-29 3:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-17 8:46 [PATCH] hid: remove NO_D3 flag for ish not CHV platform hongyan.song
2019-05-22 10:36 ` Jiri Kosina
2019-05-22 18:04 ` Pandruvada, Srinivas
2019-05-24 9:10 ` Jiri Kosina
2019-05-29 3:27 ` Pandruvada, Srinivas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).