* [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
@ 2014-08-07 2:52 Simon Wood
2014-08-12 14:30 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Simon Wood @ 2014-08-07 2:52 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, Jiri Kosina, Simon Wood
If the device data is not accessible for some reason, returning 0 will cause the call to be
continuously called again as none of the string has been 'consumed'.
---
drivers/hid/hid-lg4ff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index cc2bd20..7835717 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
drv_data = hid_get_drvdata(hid);
if (!drv_data) {
hid_err(hid, "Private driver data not found!\n");
- return 0;
+ return -EINVAL;
}
entry = drv_data->device_props;
if (!entry) {
hid_err(hid, "Device properties not found!\n");
- return 0;
+ return -EINVAL;
}
if (range == 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
2014-08-07 2:52 [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface Simon Wood
@ 2014-08-12 14:30 ` Jiri Kosina
2014-08-15 2:43 ` [PATCHv2] " Simon Wood
0 siblings, 1 reply; 4+ messages in thread
From: Jiri Kosina @ 2014-08-12 14:30 UTC (permalink / raw)
To: Simon Wood; +Cc: linux-input, linux-kernel
On Wed, 6 Aug 2014, Simon Wood wrote:
> If the device data is not accessible for some reason, returning 0 will cause the call to be
> continuously called again as none of the string has been 'consumed'.
Hi Simon,
this patch is missing signoff.
> ---
> drivers/hid/hid-lg4ff.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index cc2bd20..7835717 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
> drv_data = hid_get_drvdata(hid);
> if (!drv_data) {
> hid_err(hid, "Private driver data not found!\n");
> - return 0;
> + return -EINVAL;
> }
>
> entry = drv_data->device_props;
> if (!entry) {
> hid_err(hid, "Device properties not found!\n");
> - return 0;
> + return -EINVAL;
> }
>
> if (range == 0)
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCHv2] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
2014-08-12 14:30 ` Jiri Kosina
@ 2014-08-15 2:43 ` Simon Wood
2014-08-15 8:56 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Simon Wood @ 2014-08-15 2:43 UTC (permalink / raw)
To: linux-input; +Cc: linux-kernel, Jiri Kosina, Simon Wood
If the device data is not accessible for some reason, returning 0 will cause the call to be
continuously called again as none of the string has been 'consumed'.
Signed-off-by: Simon Wood <simon@mungewell.org>
---
drivers/hid/hid-lg4ff.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
index cc2bd20..7835717 100644
--- a/drivers/hid/hid-lg4ff.c
+++ b/drivers/hid/hid-lg4ff.c
@@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
drv_data = hid_get_drvdata(hid);
if (!drv_data) {
hid_err(hid, "Private driver data not found!\n");
- return 0;
+ return -EINVAL;
}
entry = drv_data->device_props;
if (!entry) {
hid_err(hid, "Device properties not found!\n");
- return 0;
+ return -EINVAL;
}
if (range == 0)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCHv2] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface
2014-08-15 2:43 ` [PATCHv2] " Simon Wood
@ 2014-08-15 8:56 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2014-08-15 8:56 UTC (permalink / raw)
To: Simon Wood; +Cc: linux-input, linux-kernel
On Thu, 14 Aug 2014, Simon Wood wrote:
> If the device data is not accessible for some reason, returning 0 will cause the call to be
> continuously called again as none of the string has been 'consumed'.
>
> Signed-off-by: Simon Wood <simon@mungewell.org>
> ---
> drivers/hid/hid-lg4ff.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index cc2bd20..7835717 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -451,13 +451,13 @@ static ssize_t lg4ff_range_store(struct device *dev, struct device_attribute *at
> drv_data = hid_get_drvdata(hid);
> if (!drv_data) {
> hid_err(hid, "Private driver data not found!\n");
> - return 0;
> + return -EINVAL;
> }
>
> entry = drv_data->device_props;
> if (!entry) {
> hid_err(hid, "Device properties not found!\n");
> - return 0;
> + return -EINVAL;
> }
>
Queued for 3.17, thanks Simon.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-08-15 8:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-07 2:52 [PATCH] HID:hid-logitech: Prevent possibility of infinite loop when using /sys interface Simon Wood
2014-08-12 14:30 ` Jiri Kosina
2014-08-15 2:43 ` [PATCHv2] " Simon Wood
2014-08-15 8:56 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).