[PATCH] Fixed bug in single-touch emulation on the Stantum panel

[PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Stephane Chatty]

Fixed bug in touchscreen emulation for the Stantum multitouch panel

Signed-off-by: Stephane Chatty <chatty@enac.fr>

diff -rupN a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c
--- a/drivers/hid/hid-stantum.c	2010-02-06 14:59:57.000000000 +0100
+++ b/drivers/hid/hid-stantum.c	2010-02-06 15:00:36.000000000 +0100
@@ -16,7 +16,7 @@
 #include <linux/hid.h>
 #include <linux/module.h>
 
-MODULE_VERSION("1.00");
+MODULE_VERSION("1.01");
 MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
 MODULE_DESCRIPTION("Stantum HID multitouch panels");
 MODULE_LICENSE("GPL");
@@ -147,7 +147,6 @@ static void stantum_filter_event(struct 
 
 	input_mt_sync(input);
 	sd->valid = false;
-	sd->first = false;
 
 	/* touchscreen emulation */
 	if (sd->first) {
@@ -158,6 +157,7 @@ static void stantum_filter_event(struct 
 		input_event(input, EV_ABS, ABS_X, sd->x);
 		input_event(input, EV_ABS, ABS_Y, sd->y);
 	}
+	sd->first = false;
 }
 
 

Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Jiri Kosina]

On Sat, 6 Feb 2010, Stephane Chatty wrote:

> Fixed bug in touchscreen emulation for the Stantum multitouch panel

Hi Stephane,

could you please perhaps provide a little bit more detailed information 
about the nature of the bug this is fixing? It might be useful for people 
looking through changelog.

> Signed-off-by: Stephane Chatty <chatty@enac.fr>
> 
> diff -rupN a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c
> --- a/drivers/hid/hid-stantum.c	2010-02-06 14:59:57.000000000 +0100
> +++ b/drivers/hid/hid-stantum.c	2010-02-06 15:00:36.000000000 +0100
> @@ -16,7 +16,7 @@
>  #include <linux/hid.h>
>  #include <linux/module.h>
>  
> -MODULE_VERSION("1.00");
> +MODULE_VERSION("1.01");

Are you planning to maintain this numbering, btw? Usually people forget to 
update it :)

>  MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
>  MODULE_DESCRIPTION("Stantum HID multitouch panels");
>  MODULE_LICENSE("GPL");
> @@ -147,7 +147,6 @@ static void stantum_filter_event(struct 
>  
>  	input_mt_sync(input);
>  	sd->valid = false;
> -	sd->first = false;
>  
>  	/* touchscreen emulation */
>  	if (sd->first) {
> @@ -158,6 +157,7 @@ static void stantum_filter_event(struct 
>  		input_event(input, EV_ABS, ABS_X, sd->x);
>  		input_event(input, EV_ABS, ABS_Y, sd->y);
>  	}
> +	sd->first = false;
>  }
>  

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Stéphane Chatty]

Le 9 févr. 10 à 11:27, Jiri Kosina a écrit :

> On Sat, 6 Feb 2010, Stephane Chatty wrote:
>
>> Fixed bug in touchscreen emulation for the Stantum multitouch panel
>
> Hi Stephane,
>
> could you please perhaps provide a little bit more detailed  
> information
> about the nature of the bug this is fixing? It might be useful for  
> people
> looking through changelog.

Fixed stupid copy-paste bug in touchscreen emulation for the Stantum  
multitouch panel: a flag was reset just before being tested.

>>
>
> Are you planning to maintain this numbering, btw? Usually people  
> forget to
> update it :)

As a user I find it useful. As a coder I usually maintain them. But I  
was wondering what was going to happen if other people were to submit  
patches on the code; in that case, and if they don't update the  
number I guess having a version number is a bad idea.


--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Dmitry Torokhov]

On Tue, Feb 09, 2010 at 03:59:34PM +0100, Stéphane Chatty wrote:
> 
> Le 9 févr. 10 à 11:27, Jiri Kosina a écrit :
> 
> >On Sat, 6 Feb 2010, Stephane Chatty wrote:
> >
> >>Fixed bug in touchscreen emulation for the Stantum multitouch panel
> >
> >Hi Stephane,
> >
> >could you please perhaps provide a little bit more detailed
> >information
> >about the nature of the bug this is fixing? It might be useful for
> >people
> >looking through changelog.
> 
> Fixed stupid copy-paste bug in touchscreen emulation for the Stantum
> multitouch panel: a flag was reset just before being tested.
> 
> >>
> >
> >Are you planning to maintain this numbering, btw? Usually people
> >forget to
> >update it :)
> 
> As a user I find it useful. As a coder I usually maintain them. But
> I was wondering what was going to happen if other people were to
> submit patches on the code; in that case, and if they don't update
> the number I guess having a version number is a bad idea.

Once a driver is in mainline its internal version number becomes pretty
meaningless, the only thing that can help identify the code is kernel
version or, better, commit ID of the branch it was built off.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Jiri Kosina]

On Sat, 6 Feb 2010, Stephane Chatty wrote:

> 
> Fixed bug in touchscreen emulation for the Stantum multitouch panel
> 
> Signed-off-by: Stephane Chatty <chatty@enac.fr>
> 
> diff -rupN a/drivers/hid/hid-stantum.c b/drivers/hid/hid-stantum.c
> --- a/drivers/hid/hid-stantum.c	2010-02-06 14:59:57.000000000 +0100
> +++ b/drivers/hid/hid-stantum.c	2010-02-06 15:00:36.000000000 +0100
> @@ -16,7 +16,7 @@
>  #include <linux/hid.h>
>  #include <linux/module.h>
>  
> -MODULE_VERSION("1.00");
> +MODULE_VERSION("1.01");
>  MODULE_AUTHOR("Stephane Chatty <chatty@enac.fr>");
>  MODULE_DESCRIPTION("Stantum HID multitouch panels");
>  MODULE_LICENSE("GPL");
> @@ -147,7 +147,6 @@ static void stantum_filter_event(struct 
>  
>  	input_mt_sync(input);
>  	sd->valid = false;
> -	sd->first = false;
>  
>  	/* touchscreen emulation */
>  	if (sd->first) {
> @@ -158,6 +157,7 @@ static void stantum_filter_event(struct 
>  		input_event(input, EV_ABS, ABS_X, sd->x);
>  		input_event(input, EV_ABS, ABS_Y, sd->y);
>  	}
> +	sd->first = false;
>  }

It doesn't apply to the driver I have in the tree. That claims to be 
version 0.6, and it doesn't contain this bug.

Perhaps you forgot to submit a patch refreshing the driver to newer 
version (or perhaps I have missed it?).

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Stéphane Chatty]

Le 9 févr. 10 à 16:34, Jiri Kosina a écrit :

>
> It doesn't apply to the driver I have in the tree. That claims to be
> version 0.6, and it doesn't contain this bug.

Obviously I got the version number wrong when I submitted the driver  
(was 0.6, should have been 1.00). But the bug is there alright: when  
I look at the code in your 'for-next' branch, sd->first is reset at  
line 150 when it should be reset at line 160 or 161.


> Perhaps you forgot to submit a patch refreshing the driver to newer
> version (or perhaps I have missed it?).

I guess I just ticked the version number to 1.00 *after* submitting  
the driver instead of doing it before. Sorry for the confusion.

St.

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Fixed bug in single-touch emulation on the Stantum panel

[Jiri Kosina]

On Tue, 9 Feb 2010, Stéphane Chatty wrote:

> Obviously I got the version number wrong when I submitted the driver (was 0.6,
> should have been 1.00). But the bug is there alright: when I look at the code
> in your 'for-next' branch, sd->first is reset at line 150 when it should be
> reset at line 160 or 161.

I have now applied your fix, thanks.

> > Perhaps you forgot to submit a patch refreshing the driver to newer
> > version (or perhaps I have missed it?).
> 
> I guess I just ticked the version number to 1.00 *after* submitting the driver
> instead of doing it before. Sorry for the confusion.

I suggest we remove the version number once the driver is merged upstream, 
as git is much better tracking the versions.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html