* [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
@ 2019-11-25 21:14 Dmitry Torokhov
2019-11-26 0:40 ` Anson Huang
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2019-11-25 21:14 UTC (permalink / raw)
To: linux-input; +Cc: Anson Huang, Robin van der Gracht, linux-kernel
Gratuitous NULL initializers rarely help and often prevent compiler
from warning about using uninitialized variable. Let's remove them.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/snvs_pwrkey.c b/drivers/input/keyboard/snvs_pwrkey.c
index fd6f244f403d..2f5e3ab5ed63 100644
--- a/drivers/input/keyboard/snvs_pwrkey.c
+++ b/drivers/input/keyboard/snvs_pwrkey.c
@@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
{
- struct pwrkey_drv_data *pdata = NULL;
- struct input_dev *input = NULL;
+ struct pwrkey_drv_data *pdata;
+ struct input_dev *input;
struct device_node *np;
int error;
u32 vid;
--
2.24.0.432.g9d3f5f5b63-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
2019-11-25 21:14 [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers Dmitry Torokhov
@ 2019-11-26 0:40 ` Anson Huang
0 siblings, 0 replies; 2+ messages in thread
From: Anson Huang @ 2019-11-26 0:40 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Robin van der Gracht, linux-kernel
> Subject: [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers
>
> Gratuitous NULL initializers rarely help and often prevent compiler from
> warning about using uninitialized variable. Let's remove them.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/input/keyboard/snvs_pwrkey.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> b/drivers/input/keyboard/snvs_pwrkey.c
> index fd6f244f403d..2f5e3ab5ed63 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -108,8 +108,8 @@ static void imx_snvs_pwrkey_act(void *pdata)
>
> static int imx_snvs_pwrkey_probe(struct platform_device *pdev) {
> - struct pwrkey_drv_data *pdata = NULL;
> - struct input_dev *input = NULL;
> + struct pwrkey_drv_data *pdata;
> + struct input_dev *input;
> struct device_node *np;
> int error;
> u32 vid;
> --
> 2.24.0.432.g9d3f5f5b63-goog
>
>
> --
> Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-26 0:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 21:14 [PATCH] Input: snvs_pwrkey - remove gratuitous NULL initializers Dmitry Torokhov
2019-11-26 0:40 ` Anson Huang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).