From: Jason Gunthorpe <jgg@ziepe.ca>
To: Seunghun Han <kkamagui@gmail.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
"open list:TPM DEVICE DRIVER" <linux-integrity@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM
Date: Fri, 30 Aug 2019 09:43:34 -0300 [thread overview]
Message-ID: <20190830124334.GA10004@ziepe.ca> (raw)
In-Reply-To: <20190830095639.4562-3-kkamagui@gmail.com>
On Fri, Aug 30, 2019 at 06:56:39PM +0900, Seunghun Han wrote:
> I got an AMD system which had a Ryzen Threadripper 1950X and MSI
> mainboard, and I had a problem with AMD's fTPM. My machine showed an error
> message below, and the fTPM didn't work because of it.
>
> [ 5.732084] tpm_crb MSFT0101:00: can't request region for resource
> [mem 0x79b4f000-0x79b4ffff]
> [ 5.732089] tpm_crb: probe of MSFT0101:00 failed with error -16
>
> When I saw the iomem, I found two fTPM regions were in the ACPI NVS area.
> The regions are below.
>
> 79a39000-79b6afff : ACPI Non-volatile Storage
> 79b4b000-79b4bfff : MSFT0101:00
> 79b4f000-79b4ffff : MSFT0101:00
>
> After analyzing this issue, I found that crb_map_io() function called
> devm_ioremap_resource() and it failed. The ACPI NVS didn't allow the TPM
> CRB driver to assign a resource in it because a busy bit was set to
> the ACPI NVS area.
>
> To support AMD's fTPM, I added a function to check intersects between
> the TPM region and ACPI NVS before it mapped the region. If some
> intersects are detected, the function just calls devm_ioremap() for
> a workaround. If there is no intersect, it calls devm_ioremap_resource().
>
> Signed-off-by: Seunghun Han <kkamagui@gmail.com>
> ---
> drivers/char/tpm/tpm_crb.c | 25 +++++++++++++++++++++++--
> 1 file changed, 23 insertions(+), 2 deletions(-)
This still seems to result in two drivers controlling the same
memory. Does this create bugs and races during resume?
Jason
next prev parent reply other threads:[~2019-08-30 12:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:56 [PATCH 0/2] Enhance support for the AMD's fTPM Seunghun Han
2019-08-30 9:56 ` [PATCH 1/2] tpm: tpm_crb: enhance command and response buffer size calculation code Seunghun Han
2019-08-30 9:56 ` [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM Seunghun Han
2019-08-30 12:43 ` Jason Gunthorpe [this message]
2019-08-30 13:54 ` Seunghun Han
2019-08-30 14:20 ` Safford, David (GE Global Research, US)
2019-08-30 16:54 ` Seunghun Han
2019-08-30 17:58 ` Safford, David (GE Global Research, US)
2019-09-02 13:53 ` Jarkko Sakkinen
2019-09-02 22:42 ` Seunghun Han
2019-09-03 16:10 ` Jarkko Sakkinen
2019-09-03 17:43 ` Seunghun Han
2019-09-03 9:56 ` Seunghun Han
2019-09-03 9:59 ` Seunghun Han
2019-09-03 12:26 ` Safford, David (GE Global Research, US)
2019-09-03 18:14 ` Seunghun Han
2019-09-03 16:16 ` Jarkko Sakkinen
2019-09-03 18:52 ` Seunghun Han
2019-08-30 14:38 ` Jason Gunthorpe
2019-08-30 16:13 ` Seunghun Han
2019-08-31 22:27 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190830124334.GA10004@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kkamagui@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).