From: kbuild test robot <lkp@intel.com>
To: Seunghun Han <kkamagui@gmail.com>
Cc: kbuild-all@01.org,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Peter Huewe <peterhuewe@gmx.de>,
"open list:TPM DEVICE DRIVER" <linux-integrity@vger.kernel.org>,
linux-kernel@vger.kernel.org, Seunghun Han <kkamagui@gmail.com>
Subject: Re: [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM
Date: Sun, 1 Sep 2019 06:27:46 +0800 [thread overview]
Message-ID: <201909010620.mIDwNGDO%lkp@intel.com> (raw)
In-Reply-To: <20190830095639.4562-3-kkamagui@gmail.com>
Hi Seunghun,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on jss-tpmdd/next]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Seunghun-Han/Enhance-support-for-the-AMD-s-fTPM/20190901-042313
base: git://git.infradead.org/users/jjs/linux-tpmdd next
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/char/tpm/tpm_crb.c:457:29-32: WARNING: Suspicious code. resource_size is maybe missing with res
vim +457 drivers/char/tpm/tpm_crb.c
452
453 static void __iomem *crb_ioremap_resource(struct device *dev,
454 const struct resource *res)
455 {
456 int rc;
> 457 resource_size_t size = res->end - res->start;
458
459 /* Broken BIOS assigns command and response buffers in ACPI NVS region.
460 * Check intersections between a resource and ACPI NVS for W/A.
461 */
462 rc = region_intersects(res->start, size, IORESOURCE_MEM |
463 IORESOURCE_BUSY, IORES_DESC_ACPI_NV_STORAGE);
464 if (rc != REGION_DISJOINT) {
465 dev_err(dev,
466 FW_BUG "Resource overlaps with a ACPI NVS. %pr\n",
467 res);
468 return devm_ioremap(dev, res->start, size);
469 }
470
471 return devm_ioremap_resource(dev, res);
472 }
473
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
prev parent reply other threads:[~2019-08-31 22:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 9:56 [PATCH 0/2] Enhance support for the AMD's fTPM Seunghun Han
2019-08-30 9:56 ` [PATCH 1/2] tpm: tpm_crb: enhance command and response buffer size calculation code Seunghun Han
2019-08-30 9:56 ` [PATCH 2/2] tpm: tpm_crb: enhance resource mapping mechanism for supporting AMD's fTPM Seunghun Han
2019-08-30 12:43 ` Jason Gunthorpe
2019-08-30 13:54 ` Seunghun Han
2019-08-30 14:20 ` Safford, David (GE Global Research, US)
2019-08-30 16:54 ` Seunghun Han
2019-08-30 17:58 ` Safford, David (GE Global Research, US)
2019-09-02 13:53 ` Jarkko Sakkinen
2019-09-02 22:42 ` Seunghun Han
2019-09-03 16:10 ` Jarkko Sakkinen
2019-09-03 17:43 ` Seunghun Han
2019-09-03 9:56 ` Seunghun Han
2019-09-03 9:59 ` Seunghun Han
2019-09-03 12:26 ` Safford, David (GE Global Research, US)
2019-09-03 18:14 ` Seunghun Han
2019-09-03 16:16 ` Jarkko Sakkinen
2019-09-03 18:52 ` Seunghun Han
2019-08-30 14:38 ` Jason Gunthorpe
2019-08-30 16:13 ` Seunghun Han
2019-08-31 22:27 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201909010620.mIDwNGDO%lkp@intel.com \
--to=lkp@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=kbuild-all@01.org \
--cc=kkamagui@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).