archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <>
To: Peter Huewe <>,
	Jarkko Sakkinen <>
	Andrey Pronin <>,
	Duncan Laurie <>,
	Jason Gunthorpe <>, Arnd Bergmann <>,
	Greg Kroah-Hartman <>,
	Guenter Roeck <>,
	Alexander Steffen <>,
	Heiko Stuebner <>
Subject: [PATCH v7 0/6] tpm: Add driver for cr50
Date: Fri, 20 Sep 2019 11:32:34 -0700	[thread overview]
Message-ID: <> (raw)

This patch series adds support for the H1 secure microcontroller
running cr50 firmware found on various recent Chromebooks. This driver
is necessary to boot into a ChromeOS userspace environment. It
implements support for several functions, including TPM-like
functionality over a SPI interface.

The last time this was series sent looks to be [1]. I've looked over the
patches and review comments and tried to address any feedback that
Andrey didn't address (really minor things like newlines). I've reworked
the patches from the last version to layer on top of the existing TPM
TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more
palatable than combining the two drivers together into one file.

Please review so we can get the approach to supporting this device
sorted out.


 * Add a patch to spit out WARN_ON() when TPM is suspended and some
   kernel code attempts to use it
 * Rework the i2c driver per Alexander's comments on v2

Changes from v6 (
 * Two new patches to cleanup includes and module usage
 * Moved cr50 C file to tpm_tis_spi_cr50.c
 * Used the tpm_tis_spi_mod target approach to make the module work
 * Brought back Kconfig option to allow user to disable cr50 code
 * Rebased to v5.3

Changes from v5 (
 * Picked up Jarkko's ack/review tags
 * Fixed bug with irqs happening before completion is initialized
 * Dropped is_cr50 bool
 * Moved wake_after to tpm_tis_spi struct
 * Changed authorship of main cr50 patch to Andrey as I'm just shuffling
   code here

Changes from v4 (
 * Dropped the 'pre-transfer' hook patch and added a 'ready' member instead
 * Combined cr50_spi and tpm_tis_spi into one kernel module
 * Introduced a swizzle in tpm_tis_spi probe routine to jump to cr50
   probe path
 * Moved binding to start of the thread
 * Picked up Jarkko reviewed-by tag on new flag for suspend/resume
 * Added a comment to flow control patch indicating what it's all about

Changes from v3:
 * Split out hooks into separate patches
 * Update commit text to not say "libify"
 * Collapse if statement into one for first patch
 * Update commit text on first patch to mention flag
 * Drop TIS_IS_CR50 as it's unused

Changes from v2:
 * Sent khwrng thread patch separately
 * New patch to expose TPM SPI functionality from tpm_tis_spi.c
 * Usage of that new patch in cr50 SPI driver
 * Drop i2c version of cr50 SPI driver for now (will resend later)
 * New patch to add a TPM chip flag indicating TPM shouldn't be reset
   over suspend. Allows us to get rid of the cr50 suspend/resume functions
   that are mostly generic

Changes from v1:
 * Dropped symlink and sysfs patches
 * Removed 'is_suspended' bits
 * Added new patch to freeze khwrng thread
 * Moved binding to google,cr50.txt and added Reviewed-by tag from Rob

Cc: Andrey Pronin <>
Cc: Duncan Laurie <>
Cc: Jason Gunthorpe <>
Cc: Arnd Bergmann <>
Cc: Greg Kroah-Hartman <>
Cc: Guenter Roeck <>
Cc: Alexander Steffen <>
Cc: Heiko Stuebner <>

Andrey Pronin (2):
  dt-bindings: tpm: document properties for cr50
  tpm: tpm_tis_spi: Support cr50 devices

Stephen Boyd (4):
  tpm: Add a flag to indicate TPM power is managed by firmware
  tpm: tpm_tis_spi: Introduce a flow control callback
  tpm: tpm_tis_spi: Cleanup includes
  tpm: tpm_tis_spi: Drop THIS_MODULE usage from driver struct

 .../bindings/security/tpm/google,cr50.txt     |  19 ++
 drivers/char/tpm/Kconfig                      |   7 +
 drivers/char/tpm/Makefile                     |   4 +-
 drivers/char/tpm/tpm-interface.c              |   8 +-
 drivers/char/tpm/tpm.h                        |   1 +
 drivers/char/tpm/tpm_tis_spi.c                | 143 +++++---
 drivers/char/tpm/tpm_tis_spi.h                |  53 +++
 drivers/char/tpm/tpm_tis_spi_cr50.c           | 321 ++++++++++++++++++
 8 files changed, 498 insertions(+), 58 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/security/tpm/google,cr50.txt
 create mode 100644 drivers/char/tpm/tpm_tis_spi.h
 create mode 100644 drivers/char/tpm/tpm_tis_spi_cr50.c

base-commit: 4d856f72c10ecb060868ed10ff1b1453943fc6c8
Sent by a computer through tubes

             reply	other threads:[~2019-09-20 18:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-20 18:32 Stephen Boyd [this message]
2019-09-20 18:32 ` [PATCH v7 1/6] dt-bindings: tpm: document properties for cr50 Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 2/6] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 3/6] tpm: tpm_tis_spi: Introduce a flow control callback Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 4/6] tpm: tpm_tis_spi: Support cr50 devices Stephen Boyd
2019-10-06 22:32   ` Jarkko Sakkinen
2020-02-03  9:13   ` Alexander Steffen
2020-02-04  0:37     ` Stephen Boyd
2020-02-04  7:15       ` Alexander Steffen
2020-02-04 12:00         ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 5/6] tpm: tpm_tis_spi: Cleanup includes Stephen Boyd
2019-10-06 22:34   ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 6/6] tpm: tpm_tis_spi: Drop THIS_MODULE usage from driver struct Stephen Boyd
2019-10-06 22:35   ` Jarkko Sakkinen
2019-10-06 22:39 ` [PATCH v7 0/6] tpm: Add driver for cr50 Jarkko Sakkinen
2019-10-11  7:50   ` Heiko Stübner
2019-10-14 19:56     ` Jarkko Sakkinen
2019-10-15 20:23       ` Heiko Stuebner
2019-10-16 15:27         ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).