From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Peter Huewe <peterhuewe@gmx.de>,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Andrey Pronin <apronin@chromium.org>,
Duncan Laurie <dlaurie@chromium.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Guenter Roeck <groeck@chromium.org>,
Alexander Steffen <Alexander.Steffen@infineon.com>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v7 0/6] tpm: Add driver for cr50
Date: Mon, 7 Oct 2019 01:39:00 +0300 [thread overview]
Message-ID: <20191006223831.GA10397@linux.intel.com> (raw)
In-Reply-To: <20190920183240.181420-1-swboyd@chromium.org>
On Fri, Sep 20, 2019 at 11:32:34AM -0700, Stephen Boyd wrote:
> This patch series adds support for the H1 secure microcontroller
> running cr50 firmware found on various recent Chromebooks. This driver
> is necessary to boot into a ChromeOS userspace environment. It
> implements support for several functions, including TPM-like
> functionality over a SPI interface.
>
> The last time this was series sent looks to be [1]. I've looked over the
> patches and review comments and tried to address any feedback that
> Andrey didn't address (really minor things like newlines). I've reworked
> the patches from the last version to layer on top of the existing TPM
> TIS SPI implementation in tpm_tis_spi.c. Hopefully this is more
> palatable than combining the two drivers together into one file.
>
> Please review so we can get the approach to supporting this device
> sorted out.
>
> [1] https://lkml.kernel.org/r/1469757314-116169-1-git-send-email-apronin@chromium.org
>
> TODO:
> * Add a patch to spit out WARN_ON() when TPM is suspended and some
> kernel code attempts to use it
> * Rework the i2c driver per Alexander's comments on v2
>
> Changes from v6 (https://lkml.kernel.org/r/20190829224110.91103-1-swboyd@chromium.org):
> * Two new patches to cleanup includes and module usage
> * Moved cr50 C file to tpm_tis_spi_cr50.c
> * Used the tpm_tis_spi_mod target approach to make the module work
> * Brought back Kconfig option to allow user to disable cr50 code
> * Rebased to v5.3
>
> Changes from v5 (https://lkml.kernel.org/r/20190828082150.42194-1-swboyd@chromium.org):
> * Picked up Jarkko's ack/review tags
> * Fixed bug with irqs happening before completion is initialized
> * Dropped is_cr50 bool
> * Moved wake_after to tpm_tis_spi struct
> * Changed authorship of main cr50 patch to Andrey as I'm just shuffling
> code here
>
> Changes from v4 (https://lkml.kernel.org/r/20190812223622.73297-1-swboyd@chromium.org):
> * Dropped the 'pre-transfer' hook patch and added a 'ready' member instead
> * Combined cr50_spi and tpm_tis_spi into one kernel module
> * Introduced a swizzle in tpm_tis_spi probe routine to jump to cr50
> probe path
> * Moved binding to start of the thread
> * Picked up Jarkko reviewed-by tag on new flag for suspend/resume
> * Added a comment to flow control patch indicating what it's all about
>
> Changes from v3:
> * Split out hooks into separate patches
> * Update commit text to not say "libify"
> * Collapse if statement into one for first patch
> * Update commit text on first patch to mention flag
> * Drop TIS_IS_CR50 as it's unused
>
> Changes from v2:
> * Sent khwrng thread patch separately
> * New patch to expose TPM SPI functionality from tpm_tis_spi.c
> * Usage of that new patch in cr50 SPI driver
> * Drop i2c version of cr50 SPI driver for now (will resend later)
> * New patch to add a TPM chip flag indicating TPM shouldn't be reset
> over suspend. Allows us to get rid of the cr50 suspend/resume functions
> that are mostly generic
>
> Changes from v1:
> * Dropped symlink and sysfs patches
> * Removed 'is_suspended' bits
> * Added new patch to freeze khwrng thread
> * Moved binding to google,cr50.txt and added Reviewed-by tag from Rob
>
> Cc: Andrey Pronin <apronin@chromium.org>
> Cc: Duncan Laurie <dlaurie@chromium.org>
> Cc: Jason Gunthorpe <jgg@ziepe.ca>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Alexander Steffen <Alexander.Steffen@infineon.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
OK, so, I put these to my master in hopes to get testing exposure.
I think the changes are in great shape now. Thank you.
/Jarkko
next prev parent reply other threads:[~2019-10-06 22:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 18:32 [PATCH v7 0/6] tpm: Add driver for cr50 Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 1/6] dt-bindings: tpm: document properties " Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 2/6] tpm: Add a flag to indicate TPM power is managed by firmware Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 3/6] tpm: tpm_tis_spi: Introduce a flow control callback Stephen Boyd
2019-09-20 18:32 ` [PATCH v7 4/6] tpm: tpm_tis_spi: Support cr50 devices Stephen Boyd
2019-10-06 22:32 ` Jarkko Sakkinen
2020-02-03 9:13 ` Alexander Steffen
2020-02-04 0:37 ` Stephen Boyd
2020-02-04 7:15 ` Alexander Steffen
2020-02-04 12:00 ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 5/6] tpm: tpm_tis_spi: Cleanup includes Stephen Boyd
2019-10-06 22:34 ` Jarkko Sakkinen
2019-09-20 18:32 ` [PATCH v7 6/6] tpm: tpm_tis_spi: Drop THIS_MODULE usage from driver struct Stephen Boyd
2019-10-06 22:35 ` Jarkko Sakkinen
2019-10-06 22:39 ` Jarkko Sakkinen [this message]
2019-10-11 7:50 ` [PATCH v7 0/6] tpm: Add driver for cr50 Heiko Stübner
2019-10-14 19:56 ` Jarkko Sakkinen
2019-10-15 20:23 ` Heiko Stuebner
2019-10-16 15:27 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191006223831.GA10397@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=Alexander.Steffen@infineon.com \
--cc=apronin@chromium.org \
--cc=arnd@arndb.de \
--cc=dlaurie@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).