* [PATCH v2] tpm: Switch to platform_get_irq_optional()
@ 2019-10-25 9:14 Hans de Goede
2019-10-25 14:12 ` Jerry Snitselaar
2019-10-28 20:47 ` Jarkko Sakkinen
0 siblings, 2 replies; 3+ messages in thread
From: Hans de Goede @ 2019-10-25 9:14 UTC (permalink / raw)
To: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe
Cc: Hans de Goede, Arnd Bergmann, Greg Kroah-Hartman,
linux-integrity, stable
platform_get_irq() calls dev_err() on an error. As the IRQ usage in the
tpm_tis driver is optional, this is undesirable.
Specifically this leads to this new false-positive error being logged:
[ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found
This commit switches to platform_get_irq_optional(), which does not log
an error, fixing this.
Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"
Cc: <stable@vger.kernel.org> # 5.4.x
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
Changes in v2:
- Slightly reword commit msg, add Fixes tag
---
drivers/char/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index e4fdde93ed4c..e7df342a317d 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -286,7 +286,7 @@ static int tpm_tis_plat_probe(struct platform_device *pdev)
}
tpm_info.res = *res;
- tpm_info.irq = platform_get_irq(pdev, 0);
+ tpm_info.irq = platform_get_irq_optional(pdev, 0);
if (tpm_info.irq <= 0) {
if (pdev != force_pdev)
tpm_info.irq = -1;
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tpm: Switch to platform_get_irq_optional()
2019-10-25 9:14 [PATCH v2] tpm: Switch to platform_get_irq_optional() Hans de Goede
@ 2019-10-25 14:12 ` Jerry Snitselaar
2019-10-28 20:47 ` Jarkko Sakkinen
1 sibling, 0 replies; 3+ messages in thread
From: Jerry Snitselaar @ 2019-10-25 14:12 UTC (permalink / raw)
To: Hans de Goede
Cc: Peter Huewe, Jarkko Sakkinen, Jason Gunthorpe, Arnd Bergmann,
Greg Kroah-Hartman, linux-integrity, stable
On Fri Oct 25 19, Hans de Goede wrote:
>platform_get_irq() calls dev_err() on an error. As the IRQ usage in the
>tpm_tis driver is optional, this is undesirable.
>
>Specifically this leads to this new false-positive error being logged:
>[ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found
>
>This commit switches to platform_get_irq_optional(), which does not log
>an error, fixing this.
>
>Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"
>Cc: <stable@vger.kernel.org> # 5.4.x
>Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
>---
>Changes in v2:
>- Slightly reword commit msg, add Fixes tag
>---
> drivers/char/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
>index e4fdde93ed4c..e7df342a317d 100644
>--- a/drivers/char/tpm/tpm_tis.c
>+++ b/drivers/char/tpm/tpm_tis.c
>@@ -286,7 +286,7 @@ static int tpm_tis_plat_probe(struct platform_device *pdev)
> }
> tpm_info.res = *res;
>
>- tpm_info.irq = platform_get_irq(pdev, 0);
>+ tpm_info.irq = platform_get_irq_optional(pdev, 0);
> if (tpm_info.irq <= 0) {
> if (pdev != force_pdev)
> tpm_info.irq = -1;
>--
>2.23.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] tpm: Switch to platform_get_irq_optional()
2019-10-25 9:14 [PATCH v2] tpm: Switch to platform_get_irq_optional() Hans de Goede
2019-10-25 14:12 ` Jerry Snitselaar
@ 2019-10-28 20:47 ` Jarkko Sakkinen
1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2019-10-28 20:47 UTC (permalink / raw)
To: Hans de Goede
Cc: Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
linux-integrity, stable
On Fri, Oct 25, 2019 at 11:14:48AM +0200, Hans de Goede wrote:
> platform_get_irq() calls dev_err() on an error. As the IRQ usage in the
> tpm_tis driver is optional, this is undesirable.
>
> Specifically this leads to this new false-positive error being logged:
> [ 5.135413] tpm_tis MSFT0101:00: IRQ index 0 not found
>
> This commit switches to platform_get_irq_optional(), which does not log
> an error, fixing this.
>
> Fixes: 7723f4c5ecdb ("driver core: platform: Add an error message to platform_get_irq*()"
> Cc: <stable@vger.kernel.org> # 5.4.x
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-28 20:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 9:14 [PATCH v2] tpm: Switch to platform_get_irq_optional() Hans de Goede
2019-10-25 14:12 ` Jerry Snitselaar
2019-10-28 20:47 ` Jarkko Sakkinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).