Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH v2] tpm_tis: Remove the HID IFX0102
@ 2020-06-25  2:31 Jarkko Sakkinen
  2020-06-25  6:21 ` Jerry Snitselaar
  0 siblings, 1 reply; 9+ messages in thread
From: Jarkko Sakkinen @ 2020-06-25  2:31 UTC (permalink / raw)
  To: linux-integrity
  Cc: Jarkko Sakkinen, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

Acer C720 running Linux v5.3 reports this in klog:

tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
tpm tpm0: tpm_try_transmit: send(): error -5
tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
tpm_tis tpm_tis: Could not get TPM timeouts and durations
tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
tpm tpm0: tpm_try_transmit: send(): error -5
tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
tpm_tis 00:08: Could not get TPM timeouts and durations
ima: No TPM chip found, activating TPM-bypass!
tpm_inf_pnp 00:08: Found TPM with ID IFX0102

% git --no-pager grep IFX0102 drivers/char/tpm
drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */

Obviously IFX0102 was added to the HID table for the TCG TIS driver by
mistake.

Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
Cc: Kylene Jo Hall <kjhall@us.ibm.com>
Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
v2:
git diff -R HEAD~1 -- drivers/char/tpm/tpm2-space.c  | patch -p1
git diff -R HEAD~1 -- include/linux/tpm.h  | patch -p1
 drivers/char/tpm/tpm_tis.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index e7df342a317d..c58ea10fc92f 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -238,7 +238,6 @@ static int tpm_tis_pnp_init(struct pnp_dev *pnp_dev,
 static struct pnp_device_id tpm_pnp_tbl[] = {
 	{"PNP0C31", 0},		/* TPM */
 	{"ATM1200", 0},		/* Atmel */
-	{"IFX0102", 0},		/* Infineon */
 	{"BCM0101", 0},		/* Broadcom */
 	{"BCM0102", 0},		/* Broadcom */
 	{"NSC1200", 0},		/* National */
-- 
2.25.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-25  2:31 [PATCH v2] tpm_tis: Remove the HID IFX0102 Jarkko Sakkinen
@ 2020-06-25  6:21 ` Jerry Snitselaar
  2020-06-25 21:02   ` Jarkko Sakkinen
  0 siblings, 1 reply; 9+ messages in thread
From: Jerry Snitselaar @ 2020-06-25  6:21 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Thu Jun 25 20, Jarkko Sakkinen wrote:
>Acer C720 running Linux v5.3 reports this in klog:
>
>tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
>tpm tpm0: tpm_try_transmit: send(): error -5
>tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>tpm_tis tpm_tis: Could not get TPM timeouts and durations
>tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
>tpm tpm0: tpm_try_transmit: send(): error -5
>tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>tpm_tis 00:08: Could not get TPM timeouts and durations
>ima: No TPM chip found, activating TPM-bypass!
>tpm_inf_pnp 00:08: Found TPM with ID IFX0102
>
>% git --no-pager grep IFX0102 drivers/char/tpm
>drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
>drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
>
>Obviously IFX0102 was added to the HID table for the TCG TIS driver by
>mistake.
>
>Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
>Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
>Cc: Kylene Jo Hall <kjhall@us.ibm.com>
>Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
>Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-25  6:21 ` Jerry Snitselaar
@ 2020-06-25 21:02   ` Jarkko Sakkinen
  2020-06-25 21:19     ` Jerry Snitselaar
  0 siblings, 1 reply; 9+ messages in thread
From: Jarkko Sakkinen @ 2020-06-25 21:02 UTC (permalink / raw)
  To: linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
> On Thu Jun 25 20, Jarkko Sakkinen wrote:
> > Acer C720 running Linux v5.3 reports this in klog:
> > 
> > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
> > tpm tpm0: tpm_try_transmit: send(): error -5
> > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> > tpm_tis tpm_tis: Could not get TPM timeouts and durations
> > tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
> > tpm tpm0: tpm_try_transmit: send(): error -5
> > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> > tpm_tis 00:08: Could not get TPM timeouts and durations
> > ima: No TPM chip found, activating TPM-bypass!
> > tpm_inf_pnp 00:08: Found TPM with ID IFX0102
> > 
> > % git --no-pager grep IFX0102 drivers/char/tpm
> > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
> > 
> > Obviously IFX0102 was added to the HID table for the TCG TIS driver by
> > mistake.
> > 
> > Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
> > Cc: Kylene Jo Hall <kjhall@us.ibm.com>
> > Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> 
> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>

Bugzilla has an example of similar behavior with v4.15. I'll apply this
asap.

/Jarkko

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-25 21:02   ` Jarkko Sakkinen
@ 2020-06-25 21:19     ` Jerry Snitselaar
  2020-06-25 21:23       ` James Bottomley
  2020-06-26 13:08       ` Jarkko Sakkinen
  0 siblings, 2 replies; 9+ messages in thread
From: Jerry Snitselaar @ 2020-06-25 21:19 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Fri Jun 26 20, Jarkko Sakkinen wrote:
>On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
>> On Thu Jun 25 20, Jarkko Sakkinen wrote:
>> > Acer C720 running Linux v5.3 reports this in klog:
>> >
>> > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
>> > tpm tpm0: tpm_try_transmit: send(): error -5
>> > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>> > tpm_tis tpm_tis: Could not get TPM timeouts and durations
>> > tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
>> > tpm tpm0: tpm_try_transmit: send(): error -5
>> > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>> > tpm_tis 00:08: Could not get TPM timeouts and durations
>> > ima: No TPM chip found, activating TPM-bypass!
>> > tpm_inf_pnp 00:08: Found TPM with ID IFX0102
>> >
>> > % git --no-pager grep IFX0102 drivers/char/tpm
>> > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
>> > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
>> >
>> > Obviously IFX0102 was added to the HID table for the TCG TIS driver by
>> > mistake.
>> >
>> > Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
>> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
>> > Cc: Kylene Jo Hall <kjhall@us.ibm.com>
>> > Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
>> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>>
>> Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
>
>Bugzilla has an example of similar behavior with v4.15. I'll apply this
>asap.
>
>/Jarkko
>

Any idea what happened to git.infradead.org? It was offline the other day,
and at the moment not all repos from before seem to be there.


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-25 21:19     ` Jerry Snitselaar
@ 2020-06-25 21:23       ` James Bottomley
  2020-06-26 13:15         ` Jarkko Sakkinen
  2020-06-26 13:08       ` Jarkko Sakkinen
  1 sibling, 1 reply; 9+ messages in thread
From: James Bottomley @ 2020-06-25 21:23 UTC (permalink / raw)
  To: Jerry Snitselaar, Jarkko Sakkinen
  Cc: linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Thu, 2020-06-25 at 14:19 -0700, Jerry Snitselaar wrote:
> On Fri Jun 26 20, Jarkko Sakkinen wrote:
> > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
> > > On Thu Jun 25 20, Jarkko Sakkinen wrote:
> > > > Acer C720 running Linux v5.3 reports this in klog:
> > > > 
> > > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
> > > > tpm tpm0: tpm_try_transmit: send(): error -5
> > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the
> > > > timeouts
> > > > tpm_tis tpm_tis: Could not get TPM timeouts and durations
> > > > tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
> > > > tpm tpm0: tpm_try_transmit: send(): error -5
> > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the
> > > > timeouts
> > > > tpm_tis 00:08: Could not get TPM timeouts and durations
> > > > ima: No TPM chip found, activating TPM-bypass!
> > > > tpm_inf_pnp 00:08: Found TPM with ID IFX0102
> > > > 
> > > > % git --no-pager grep IFX0102 drivers/char/tpm
> > > > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> > > > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		
> > > > /* Infineon */
> > > > 
> > > > Obviously IFX0102 was added to the HID table for the TCG TIS
> > > > driver by
> > > > mistake.
> > > > 
> > > > Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
> > > > Cc: Kylene Jo Hall <kjhall@us.ibm.com>
> > > > Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com
> > > > >
> > > 
> > > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> > 
> > Bugzilla has an example of similar behavior with v4.15. I'll apply
> > this asap.
> > 
> > /Jarkko
> > 
> 
> Any idea what happened to git.infradead.org? It was offline the other
> day, and at the moment not all repos from before seem to be there.

Infradead has been playing up for a while on other things (non git
services I use).

Perhaps it's time to get a kernel.org repository ...

James

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-25 21:19     ` Jerry Snitselaar
  2020-06-25 21:23       ` James Bottomley
@ 2020-06-26 13:08       ` Jarkko Sakkinen
  2020-06-30 19:15         ` Jerry Snitselaar
  1 sibling, 1 reply; 9+ messages in thread
From: Jarkko Sakkinen @ 2020-06-26 13:08 UTC (permalink / raw)
  To: linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote:
> On Fri Jun 26 20, Jarkko Sakkinen wrote:
> > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
> > > On Thu Jun 25 20, Jarkko Sakkinen wrote:
> > > > Acer C720 running Linux v5.3 reports this in klog:
> > > >
> > > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
> > > > tpm tpm0: tpm_try_transmit: send(): error -5
> > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> > > > tpm_tis tpm_tis: Could not get TPM timeouts and durations
> > > > tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
> > > > tpm tpm0: tpm_try_transmit: send(): error -5
> > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> > > > tpm_tis 00:08: Could not get TPM timeouts and durations
> > > > ima: No TPM chip found, activating TPM-bypass!
> > > > tpm_inf_pnp 00:08: Found TPM with ID IFX0102
> > > >
> > > > % git --no-pager grep IFX0102 drivers/char/tpm
> > > > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> > > > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
> > > >
> > > > Obviously IFX0102 was added to the HID table for the TCG TIS driver by
> > > > mistake.
> > > >
> > > > Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
> > > > Cc: Kylene Jo Hall <kjhall@us.ibm.com>
> > > > Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > 
> > > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> > 
> > Bugzilla has an example of similar behavior with v4.15. I'll apply this
> > asap.
> > 
> > /Jarkko
> > 
> 
> Any idea what happened to git.infradead.org? It was offline the other day,
> and at the moment not all repos from before seem to be there.

Now the kernel tree is back online.

/Jarkko

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-25 21:23       ` James Bottomley
@ 2020-06-26 13:15         ` Jarkko Sakkinen
  2020-06-26 14:36           ` James Bottomley
  0 siblings, 1 reply; 9+ messages in thread
From: Jarkko Sakkinen @ 2020-06-26 13:15 UTC (permalink / raw)
  To: James Bottomley
  Cc: Jerry Snitselaar, linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Thu, Jun 25, 2020 at 02:23:59PM -0700, James Bottomley wrote:
> On Thu, 2020-06-25 at 14:19 -0700, Jerry Snitselaar wrote:
> > On Fri Jun 26 20, Jarkko Sakkinen wrote:
> > > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
> > > > On Thu Jun 25 20, Jarkko Sakkinen wrote:
> > > > > Acer C720 running Linux v5.3 reports this in klog:
> > > > > 
> > > > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
> > > > > tpm tpm0: tpm_try_transmit: send(): error -5
> > > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the
> > > > > timeouts
> > > > > tpm_tis tpm_tis: Could not get TPM timeouts and durations
> > > > > tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
> > > > > tpm tpm0: tpm_try_transmit: send(): error -5
> > > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the
> > > > > timeouts
> > > > > tpm_tis 00:08: Could not get TPM timeouts and durations
> > > > > ima: No TPM chip found, activating TPM-bypass!
> > > > > tpm_inf_pnp 00:08: Found TPM with ID IFX0102
> > > > > 
> > > > > % git --no-pager grep IFX0102 drivers/char/tpm
> > > > > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
> > > > > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		
> > > > > /* Infineon */
> > > > > 
> > > > > Obviously IFX0102 was added to the HID table for the TCG TIS
> > > > > driver by
> > > > > mistake.
> > > > > 
> > > > > Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
> > > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
> > > > > Cc: Kylene Jo Hall <kjhall@us.ibm.com>
> > > > > Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
> > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com
> > > > > >
> > > > 
> > > > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
> > > 
> > > Bugzilla has an example of similar behavior with v4.15. I'll apply
> > > this asap.
> > > 
> > > /Jarkko
> > > 
> > 
> > Any idea what happened to git.infradead.org? It was offline the other
> > day, and at the moment not all repos from before seem to be there.
> 
> Infradead has been playing up for a while on other things (non git
> services I use).
> 
> Perhaps it's time to get a kernel.org repository ...

I have an obstacle with that.

I lost my previous PGP key a year ago and created a new one, which is
not trusted yet by anyone [*]. I've backed this up now and have it
stored inside Nitrokey Pro 2 in order to prevent this happening again.

Now the problem is that in order to get a kernel.org account, I need
to be in the web of trust of the kernel maintainers.

I can request an accunt only after I see face to face another kernel
maintainers, so that I can proof that I am I.

[*] http://keys.gnupg.net/pks/lookup?op=get&search=0x3AB05486C7752FE1

/Jarkko

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-26 13:15         ` Jarkko Sakkinen
@ 2020-06-26 14:36           ` James Bottomley
  0 siblings, 0 replies; 9+ messages in thread
From: James Bottomley @ 2020-06-26 14:36 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: Jerry Snitselaar, linux-integrity, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Fri, 2020-06-26 at 16:15 +0300, Jarkko Sakkinen wrote:
> I have an obstacle with that.
> 
> I lost my previous PGP key a year ago and created a new one, which is
> not trusted yet by anyone [*]. I've backed this up now and have it
> stored inside Nitrokey Pro 2 in order to prevent this happening
> again.

I wouldn't do that.  If the nitro key gets lost or breaks, you'll be in
the same position.  Best practice is to have your key offline somewhere
in a secure vault (like an encrypted USB key in a bank vault) so you
can restore in case of loss and then present inside a token (so I use
the TPM2 for mine).

> Now the problem is that in order to get a kernel.org account, I need
> to be in the web of trust of the kernel maintainers.
> 
> I can request an accunt only after I see face to face another kernel
> maintainers, so that I can proof that I am I.
> 
> [*] http://keys.gnupg.net/pks/lookup?op=get&search=0x3AB05486C7752FE1

Well, I would sign this and send it back to you, except I can't.  The
verification procedures require an encrypted email and you don't have a
working encryption key:

gpg --export -a 3AB05486C7752FE1 | gpg --encrypt -r 3AB05486C7752FE1 -a --output 3AB05486C7752FE1.gpg 
gpg: 3AB05486C7752FE1: skipped: Unusable public key
gpg: [stdin]: encryption failed: Unusable public key

The reason is your main key is certification only (as is should be):

pub  rsa4096/3AB05486C7752FE1
     created: 2019-06-24  expires: 2023-06-24  usage: C   
     trust: unknown       validity: full

but your only encryption subkey is revoked:

sub  rsa2048/3A4EC6E56FDD3158
     created: 2019-06-25  revoked: 2019-10-22  usage: E   

You seem to have only one unrevoked, unexpired subkey which is an
authentication one, so you wouldn't even be able to sign with that key:

sub  rsa2048/962F0565523E5DC5
     created: 2019-06-26  expires: 2021-06-25  usage: A   

James


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH v2] tpm_tis: Remove the HID IFX0102
  2020-06-26 13:08       ` Jarkko Sakkinen
@ 2020-06-30 19:15         ` Jerry Snitselaar
  0 siblings, 0 replies; 9+ messages in thread
From: Jerry Snitselaar @ 2020-06-30 19:15 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: linux-integrity, Kylene Jo Hall, Ferry Toth :,
	Peter Huewe, Jason Gunthorpe, Arnd Bergmann, Greg Kroah-Hartman,
	Andrew Morton, open list

On Fri Jun 26 20, Jarkko Sakkinen wrote:
>On Thu, Jun 25, 2020 at 02:19:23PM -0700, Jerry Snitselaar wrote:
>> On Fri Jun 26 20, Jarkko Sakkinen wrote:
>> > On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
>> > > On Thu Jun 25 20, Jarkko Sakkinen wrote:
>> > > > Acer C720 running Linux v5.3 reports this in klog:
>> > > >
>> > > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
>> > > > tpm tpm0: tpm_try_transmit: send(): error -5
>> > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>> > > > tpm_tis tpm_tis: Could not get TPM timeouts and durations
>> > > > tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
>> > > > tpm tpm0: tpm_try_transmit: send(): error -5
>> > > > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
>> > > > tpm_tis 00:08: Could not get TPM timeouts and durations
>> > > > ima: No TPM chip found, activating TPM-bypass!
>> > > > tpm_inf_pnp 00:08: Found TPM with ID IFX0102
>> > > >
>> > > > % git --no-pager grep IFX0102 drivers/char/tpm
>> > > > drivers/char/tpm/tpm_infineon.c:	{"IFX0102", 0},
>> > > > drivers/char/tpm/tpm_tis.c:	{"IFX0102", 0},		/* Infineon */
>> > > >
>> > > > Obviously IFX0102 was added to the HID table for the TCG TIS driver by
>> > > > mistake.
>> > > >
>> > > > Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
>> > > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
>> > > > Cc: Kylene Jo Hall <kjhall@us.ibm.com>
>> > > > Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
>> > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>> > >
>> > > Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
>> >
>> > Bugzilla has an example of similar behavior with v4.15. I'll apply this
>> > asap.
>> >
>> > /Jarkko
>> >
>>
>> Any idea what happened to git.infradead.org? It was offline the other day,
>> and at the moment not all repos from before seem to be there.
>
>Now the kernel tree is back online.
>
>/Jarkko
>

Hi Jarkko, I still see your linux-tpmdd repository as not being online:

git remote show tpmdd
fatal: remote error: access denied or repository not exported: /users/jjs/linux-tpmdd.git

Regards,
Jerry


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25  2:31 [PATCH v2] tpm_tis: Remove the HID IFX0102 Jarkko Sakkinen
2020-06-25  6:21 ` Jerry Snitselaar
2020-06-25 21:02   ` Jarkko Sakkinen
2020-06-25 21:19     ` Jerry Snitselaar
2020-06-25 21:23       ` James Bottomley
2020-06-26 13:15         ` Jarkko Sakkinen
2020-06-26 14:36           ` James Bottomley
2020-06-26 13:08       ` Jarkko Sakkinen
2020-06-30 19:15         ` Jerry Snitselaar

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git