device tree "compatible" string value for Nuvoton TPM 75xxx

device tree "compatible" string value for Nuvoton TPM 75xxx

[Nayna]

Hi,

Currently, the kernel supports "nuvoton,npct601" for Nuvoton TPM 2.

I was wondering what will be the compatible string value for Nuvoton TPM 
75xx models.

Thanks & Regards,

      - Nayna

RE: device tree "compatible" string value for Nuvoton TPM 75xxx

[Dan.Morav]

Hi,

I've added Oshri who has been working on the driver, and Dana who is the TPM applications for follow up.
I'd suggest "npct75x" to continue with the same line.

Regards,
Dan.

-----Original Message-----
From: Nayna <nayna@linux.vnet.ibm.com>
Sent: Friday, 18 January, 2019 17:35
To: IS30 Dan Morav <Dan.Morav@nuvoton.com>
Cc: linux-integrity@vger.kernel.org; gcwilson@us.ibm.com
Subject: device tree "compatible" string value for Nuvoton TPM 75xxx

Hi,

Currently, the kernel supports "nuvoton,npct601" for Nuvoton TPM 2.

I was wondering what will be the compatible string value for Nuvoton TPM 75xx models.

Thanks & Regards,

      - Nayna



===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

Re: device tree "compatible" string value for Nuvoton TPM 75xxx

[Jason Gunthorpe]

On Sun, Jan 20, 2019 at 03:53:46PM +0000, Dan.Morav@nuvoton.com wrote:
> Hi,
> 
> I've added Oshri who has been working on the driver, and Dana who is the TPM applications for follow up.
> I'd suggest "npct75x" to continue with the same line.

There are rules for the compatible strings.. Generaly they shouldn't
include x's if I recall.

If future chips are compatible with a first release then it should be
something like

'nuvoton,npct751','nuvoton,npct750'

Be sure to check with the device tree people

Jason

RE: device tree "compatible" string value for Nuvoton TPM 75xxx

[Dan.Morav]

Jason,

Thank you for the feedback. We will follow.

Regards,
Dan.


-----Original Message-----
From: Jason Gunthorpe <jgg@ziepe.ca>
Sent: Monday, 21 January, 2019 04:27
To: IS30 Dan Morav <Dan.Morav@nuvoton.com>
Cc: nayna@linux.vnet.ibm.com; IS20 Oshri Alkoby <oshri.alkoby@nuvoton.com>; IS30 Dana Cohen <dana.cohen@nuvoton.com>; linux-integrity@vger.kernel.org; gcwilson@us.ibm.com
Subject: Re: device tree "compatible" string value for Nuvoton TPM 75xxx

On Sun, Jan 20, 2019 at 03:53:46PM +0000, Dan.Morav@nuvoton.com wrote:
> Hi,
>
> I've added Oshri who has been working on the driver, and Dana who is the TPM applications for follow up.
> I'd suggest "npct75x" to continue with the same line.

There are rules for the compatible strings.. Generaly they shouldn't include x's if I recall.

If future chips are compatible with a first release then it should be something like

'nuvoton,npct751','nuvoton,npct750'

Be sure to check with the device tree people

Jason


===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

RE: device tree "compatible" string value for Nuvoton TPM 75xxx

[oshri.alkoby]

Hi Jason,

Since the driver implements the I2C interface defined by the TCG PTP, wouldn't it be better to set the string to be something like 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)?
Any TPM that implements this protocol can use this driver.

Oshri

-----Original Message-----
From: IS30 Dan Morav
Sent: Monday, January 21, 2019 7:52 AM
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: nayna@linux.vnet.ibm.com; IS20 Oshri Alkoby <oshri.alkoby@nuvoton.com>; IS30 Dana Cohen <dana.cohen@nuvoton.com>; linux-integrity@vger.kernel.org; gcwilson@us.ibm.com
Subject: RE: device tree "compatible" string value for Nuvoton TPM 75xxx

Jason,

Thank you for the feedback. We will follow.

Regards,
Dan.


-----Original Message-----
From: Jason Gunthorpe <jgg@ziepe.ca>
Sent: Monday, 21 January, 2019 04:27
To: IS30 Dan Morav <Dan.Morav@nuvoton.com>
Cc: nayna@linux.vnet.ibm.com; IS20 Oshri Alkoby <oshri.alkoby@nuvoton.com>; IS30 Dana Cohen <dana.cohen@nuvoton.com>; linux-integrity@vger.kernel.org; gcwilson@us.ibm.com
Subject: Re: device tree "compatible" string value for Nuvoton TPM 75xxx

On Sun, Jan 20, 2019 at 03:53:46PM +0000, Dan.Morav@nuvoton.com wrote:
> Hi,
>
> I've added Oshri who has been working on the driver, and Dana who is the TPM applications for follow up.
> I'd suggest "npct75x" to continue with the same line.

There are rules for the compatible strings.. Generaly they shouldn't include x's if I recall.

If future chips are compatible with a first release then it should be something like

'nuvoton,npct751','nuvoton,npct750'

Be sure to check with the device tree people

Jason


===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.

Re: device tree "compatible" string value for Nuvoton TPM 75xxx

[Jason Gunthorpe]

On Mon, Jan 21, 2019 at 04:55:23PM +0000, oshri.alkoby@nuvoton.com wrote:
> Hi Jason,
> 
> Since the driver implements the I2C interface defined by the TCG
> PTP, wouldn't it be better to set the string to be something like
> 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)?  Any TPM that
> implements this protocol can use this driver.

Yes, probably, we've done that for LPC ..

But the device compatabile string should still be something like:

 'nuvoton,npct751','tcg,tpm-i2c-ptp'

In that case

Jason

Re: device tree "compatible" string value for Nuvoton TPM 75xxx

[Peter Huewe]

Am 21. Januar 2019 17:58:48 MEZ schrieb Jason Gunthorpe <jgg@ziepe.ca>:
>On Mon, Jan 21, 2019 at 04:55:23PM +0000, oshri.alkoby@nuvoton.com
>wrote:
>> Hi Jason,
>> 
>> Since the driver implements the I2C interface defined by the TCG
>> PTP, wouldn't it be better to set the string to be something like
>> 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)? 
I think this is a good idea.

>> Any TPM that
>> implements this protocol can use this driver.

If it implements the tcg i2c protocol without too many deviations I would propose renaming the driver im the same step.
>
>Yes, probably, we've done that for LPC ..
>
>But the device compatabile string should still be something like:
>
> 'nuvoton,npct751','tcg,tpm-i2c-ptp'
Since there are no quirks and no existing bindings, I would advise for tcg,tpm-i2c-ptp only.

Peter
-- 
Sent from my mobile

Re: device tree "compatible" string value for Nuvoton TPM 75xxx

[Jason Gunthorpe]

On Mon, Jan 21, 2019 at 08:16:04PM +0100, Peter Huewe wrote:
> Am 21. Januar 2019 17:58:48 MEZ schrieb Jason Gunthorpe <jgg@ziepe.ca>:

> >But the device compatabile string should still be something like:
> >
> > 'nuvoton,npct751','tcg,tpm-i2c-ptp'

> Since there are no quirks and no existing bindings, I would advise
> for tcg,tpm-i2c-ptp only.

At least at one point the advise was to always add a very specific
compatible string to the binding - this way if we find a problem with
that chip in the future the driver can match that string.

Jason

Re: device tree "compatible" string value for Nuvoton TPM 75xxx

[Nayna]

On 01/21/2019 11:55 AM, oshri.alkoby@nuvoton.com wrote:
> Hi Jason,
>
> Since the driver implements the I2C interface defined by the TCG PTP, wouldn't it be better to set the string to be something like 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)?
> Any TPM that implements this protocol can use this driver.

It might be nice to have a generic name if it is also compliant with the 
device tree specification.
However, I was wondering if it will not require driver code changes as 
well before this generic name can be used by any TPM implementing i2c 
protocol ?

Thanks & Regards,
        - Nayna

Re: device tree "compatible" string value for Nuvoton TPM 75xxx

[Nayna]

On 01/23/2019 03:22 PM, Nayna wrote:
>
>
> On 01/21/2019 11:55 AM, oshri.alkoby@nuvoton.com wrote:
>> Hi Jason,
>>
>> Since the driver implements the I2C interface defined by the TCG PTP, 
>> wouldn't it be better to set the string to be something like 
>> 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)?
>> Any TPM that implements this protocol can use this driver.
>
> It might be nice to have a generic name if it is also compliant with 
> the device tree specification.
> However, I was wondering if it will not require driver code changes as 
> well before this generic name can be used by any TPM implementing i2c 
> protocol ?

I am wondering if anything got decided on this ?

Thanks & Regards,
        - Nayna

RE: device tree "compatible" string value for Nuvoton TPM 75xxx

[oshri.alkoby]

From our end we are fine with what Jason suggested, we can add a specific device:
'nuvoton,npct750','tcg,tpm-i2c-ptp'

Oshri

-----Original Message-----
From: Nayna [mailto:nayna@linux.vnet.ibm.com]
Sent: Thursday, January 31, 2019 3:46 PM
To: IS20 Oshri Alkoby <oshri.alkoby@nuvoton.com>; IS30 Dan Morav <Dan.Morav@nuvoton.com>; jgg@ziepe.ca
Cc: IS30 Dana Cohen <dana.cohen@nuvoton.com>; linux-integrity@vger.kernel.org; gcwilson@us.ibm.com
Subject: Re: device tree "compatible" string value for Nuvoton TPM 75xxx



On 01/23/2019 03:22 PM, Nayna wrote:
>
>
> On 01/21/2019 11:55 AM, oshri.alkoby@nuvoton.com wrote:
>> Hi Jason,
>>
>> Since the driver implements the I2C interface defined by the TCG PTP,
>> wouldn't it be better to set the string to be something like
>> 'tcg,tpm-i2c-ptp' (as 'tcg,tpm-tis-mmio' for tpm-tis)?
>> Any TPM that implements this protocol can use this driver.
>
> It might be nice to have a generic name if it is also compliant with
> the device tree specification.
> However, I was wondering if it will not require driver code changes as
> well before this generic name can be used by any TPM implementing i2c
> protocol ?

I am wondering if anything got decided on this ?

Thanks & Regards,
        - Nayna



===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.