Linux-Integrity Archive on lore.kernel.org
 help / Atom feed
* [PATCH] tpm: remove tpm_dev_wq_lock
@ 2019-02-11 10:58 Sebastian Andrzej Siewior
  2019-02-11 14:11 ` Jarkko Sakkinen
  2019-02-12  1:45 ` Tadeusz Struk
  0 siblings, 2 replies; 3+ messages in thread
From: Sebastian Andrzej Siewior @ 2019-02-11 10:58 UTC (permalink / raw)
  To: linux-integrity
  Cc: tglx, Jason Gunthorpe, Sebastian Andrzej Siewior, Philip Tricca,
	Tadeusz Struk, Jarkko Sakkinen

Added in commit

  9e1b74a63f776 ("tpm: add support for nonblocking operation")

but never actually used it.

Cc: Philip Tricca <philip.b.tricca@intel.com>
Cc: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
 drivers/char/tpm/tpm-dev-common.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/tpm/tpm-dev-common.c b/drivers/char/tpm/tpm-dev-common.c
index 5eecad233ea1d..eca96e8c669c9 100644
--- a/drivers/char/tpm/tpm-dev-common.c
+++ b/drivers/char/tpm/tpm-dev-common.c
@@ -25,7 +25,6 @@
 #include "tpm-dev.h"
 
 static struct workqueue_struct *tpm_dev_wq;
-static DEFINE_MUTEX(tpm_dev_wq_lock);
 
 static void tpm_async_work(struct work_struct *work)
 {
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tpm: remove tpm_dev_wq_lock
  2019-02-11 10:58 [PATCH] tpm: remove tpm_dev_wq_lock Sebastian Andrzej Siewior
@ 2019-02-11 14:11 ` Jarkko Sakkinen
  2019-02-12  1:45 ` Tadeusz Struk
  1 sibling, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2019-02-11 14:11 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior
  Cc: linux-integrity, tglx, Jason Gunthorpe, Philip Tricca, Tadeusz Struk

On Mon, Feb 11, 2019 at 11:58:35AM +0100, Sebastian Andrzej Siewior wrote:
> Added in commit
> 
>   9e1b74a63f776 ("tpm: add support for nonblocking operation")
> 
> but never actually used it.
> 
> Cc: Philip Tricca <philip.b.tricca@intel.com>
> Cc: Tadeusz Struk <tadeusz.struk@intel.com>
> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>

You should use Fixes-tag e.g.

Fixes: <12 first chars from SHA-1> ("<short summary>")

/Jarkko

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tpm: remove tpm_dev_wq_lock
  2019-02-11 10:58 [PATCH] tpm: remove tpm_dev_wq_lock Sebastian Andrzej Siewior
  2019-02-11 14:11 ` Jarkko Sakkinen
@ 2019-02-12  1:45 ` Tadeusz Struk
  1 sibling, 0 replies; 3+ messages in thread
From: Tadeusz Struk @ 2019-02-12  1:45 UTC (permalink / raw)
  To: Sebastian Andrzej Siewior, linux-integrity
  Cc: tglx, Jason Gunthorpe, Philip Tricca, Jarkko Sakkinen

On 2/11/19 2:58 AM, Sebastian Andrzej Siewior wrote:
> Added in commit
> 
>   9e1b74a63f776 ("tpm: add support for nonblocking operation")
> 
> but never actually used it.

It was used in one of the early versions of this patch
https://patchwork.kernel.org/patch/10559151/

Not needed later. 

Acked-by: Tadeusz Struk <tadeusz.struk@intel.com>
Thanks,
-- 
Tadeusz

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-11 10:58 [PATCH] tpm: remove tpm_dev_wq_lock Sebastian Andrzej Siewior
2019-02-11 14:11 ` Jarkko Sakkinen
2019-02-12  1:45 ` Tadeusz Struk

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org linux-integrity@archiver.kernel.org
	public-inbox-index linux-integrity


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/ public-inbox