Linux-Integrity Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
@ 2020-03-04 16:03 Lukas Bulwahn
  2020-03-04 16:12 ` James Bottomley
  2020-03-05 11:25 ` Jarkko Sakkinen
  0 siblings, 2 replies; 7+ messages in thread
From: Lukas Bulwahn @ 2020-03-04 16:03 UTC (permalink / raw)
  To: Sumit Garg, James Bottomley, Jarkko Sakkinen, Mimi Zohar
  Cc: linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel, Lukas Bulwahn

Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
to trusted-keys/trusted_tpm1.c in security/keys/.

Since then, ./scripts/get_maintainer.pl --self-test complains:

  warning: no file matches F: security/keys/trusted.c
  warning: no file matches F: include/keys/trusted.h

Rectify the KEYS-TRUSTED entry in MAINTAINERS now.

Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Sumit, please ack.
Jarkko, please pick this patch.

 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5c755e03ddee..cf389058ca76 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9276,8 +9276,8 @@ L:	keyrings@vger.kernel.org
 S:	Supported
 F:	Documentation/security/keys/trusted-encrypted.rst
 F:	include/keys/trusted-type.h
-F:	security/keys/trusted.c
-F:	include/keys/trusted.h
+F:	include/keys/trusted_tpm.h
+F:	security/keys/trusted-keys/trusted_tpm1.c
 
 KEYS/KEYRINGS
 M:	David Howells <dhowells@redhat.com>
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-04 16:03 [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
@ 2020-03-04 16:12 ` James Bottomley
  2020-03-04 21:15   ` Lukas Bulwahn
  2020-03-05 11:25 ` Jarkko Sakkinen
  1 sibling, 1 reply; 7+ messages in thread
From: James Bottomley @ 2020-03-04 16:12 UTC (permalink / raw)
  To: Lukas Bulwahn, Sumit Garg, Jarkko Sakkinen, Mimi Zohar
  Cc: linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel

On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved
> trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: security/keys/trusted.c
>   warning: no file matches F: include/keys/trusted.h
> 
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
> 
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Sumit, please ack.
> Jarkko, please pick this patch.
> 
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5c755e03ddee..cf389058ca76 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9276,8 +9276,8 @@ L:	keyrings@vger.kernel.org
>  S:	Supported
>  F:	Documentation/security/keys/trusted-encrypted.rst
>  F:	include/keys/trusted-type.h
> -F:	security/keys/trusted.c
> -F:	include/keys/trusted.h
> +F:	include/keys/trusted_tpm.h
> +F:	security/keys/trusted-keys/trusted_tpm1.c

Everything under trusted-keys is part of the subsystem, so this should
be a glob not a single file.

James


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-04 16:12 ` James Bottomley
@ 2020-03-04 21:15   ` Lukas Bulwahn
  0 siblings, 0 replies; 7+ messages in thread
From: Lukas Bulwahn @ 2020-03-04 21:15 UTC (permalink / raw)
  To: James Bottomley
  Cc: Lukas Bulwahn, Sumit Garg, Jarkko Sakkinen, Mimi Zohar,
	linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel


On Wed, 4 Mar 2020, James Bottomley wrote:

> On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> > +F:	include/keys/trusted_tpm.h
> > +F:	security/keys/trusted-keys/trusted_tpm1.c
> 
> Everything under trusted-keys is part of the subsystem, so this should
> be a glob not a single file.
> 

Agree. I sent out a PATCH v2 for that:

https://lore.kernel.org/linux-integrity/20200304211254.5127-1-lukas.bulwahn@gmail.com/T/#u

Please ignore this v1 here and pick v2.

Thanks,

Lukas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-04 16:03 [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
  2020-03-04 16:12 ` James Bottomley
@ 2020-03-05 11:25 ` Jarkko Sakkinen
  2020-03-05 20:34   ` Lukas Bulwahn
  1 sibling, 1 reply; 7+ messages in thread
From: Jarkko Sakkinen @ 2020-03-05 11:25 UTC (permalink / raw)
  To: Lukas Bulwahn, Sumit Garg, James Bottomley, Mimi Zohar
  Cc: linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel

On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> to trusted-keys/trusted_tpm1.c in security/keys/.
> 
> Since then, ./scripts/get_maintainer.pl --self-test complains:
> 
>   warning: no file matches F: security/keys/trusted.c
>   warning: no file matches F: include/keys/trusted.h
> 
> Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
> 
> Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Sumit, please ack.
> Jarkko, please pick this patch.

I'll pick it when it is done. I acknowledge the regression but I
see no reason for rushing as this does not break any systems in
the wild.

/Jarkko


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-05 11:25 ` Jarkko Sakkinen
@ 2020-03-05 20:34   ` Lukas Bulwahn
  2020-03-05 20:46     ` James Bottomley
  0 siblings, 1 reply; 7+ messages in thread
From: Lukas Bulwahn @ 2020-03-05 20:34 UTC (permalink / raw)
  To: Jarkko Sakkinen
  Cc: Lukas Bulwahn, Sumit Garg, James Bottomley, Mimi Zohar,
	linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel



On Thu, 5 Mar 2020, Jarkko Sakkinen wrote:

> On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys subsystem")
> > renamed trusted.h to trusted_tpm.h in include/keys/, and moved trusted.c
> > to trusted-keys/trusted_tpm1.c in security/keys/.
> > 
> > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > 
> >   warning: no file matches F: security/keys/trusted.c
> >   warning: no file matches F: include/keys/trusted.h
> > 
> > Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
> > 
> > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > ---
> > Sumit, please ack.
> > Jarkko, please pick this patch.
> 
> I'll pick it when it is done. I acknowledge the regression but I
> see no reason for rushing as this does not break any systems in
> the wild.
> 

Agree. No need to rush this. I sent out a v3, and I hope to get Sumit's 
ACK and then you can pick it for the next merge window.


Lukas

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-05 20:34   ` Lukas Bulwahn
@ 2020-03-05 20:46     ` James Bottomley
  2020-03-05 21:10       ` Lukas Bulwahn
  0 siblings, 1 reply; 7+ messages in thread
From: James Bottomley @ 2020-03-05 20:46 UTC (permalink / raw)
  To: Lukas Bulwahn, Jarkko Sakkinen
  Cc: Sumit Garg, Mimi Zohar, linux-integrity, keyrings,
	Sebastian Duda, Joe Perches, kernel-janitors, linux-kernel

On Thu, 2020-03-05 at 21:34 +0100, Lukas Bulwahn wrote:
> 
> On Thu, 5 Mar 2020, Jarkko Sakkinen wrote:
> 
> > On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> > > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys
> > > subsystem")
> > > renamed trusted.h to trusted_tpm.h in include/keys/, and moved
> > > trusted.c
> > > to trusted-keys/trusted_tpm1.c in security/keys/.
> > > 
> > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > > 
> > >   warning: no file matches F: security/keys/trusted.c
> > >   warning: no file matches F: include/keys/trusted.h
> > > 
> > > Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
> > > 
> > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > ---
> > > Sumit, please ack.
> > > Jarkko, please pick this patch.
> > 
> > I'll pick it when it is done. I acknowledge the regression but I
> > see no reason for rushing as this does not break any systems in
> > the wild.
> > 
> 
> Agree. No need to rush this. I sent out a v3, and I hope to get
> Sumit's ACK and then you can pick it for the next merge window.

From a process point of view, I don't quite understand this.  You're
altering an entry in the MAINTAINERS file which belongs to the three
maintainers of trusted keys, you only need our ack to do that, which
picking up via the trusted key tree will substitute for.  It would be
useful to have Sumit review this because he moved the files and there
may be something we missed, but a reviewed-by: is a nice to have and
not a block on the process.

James


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation
  2020-03-05 20:46     ` James Bottomley
@ 2020-03-05 21:10       ` Lukas Bulwahn
  0 siblings, 0 replies; 7+ messages in thread
From: Lukas Bulwahn @ 2020-03-05 21:10 UTC (permalink / raw)
  To: James Bottomley
  Cc: Lukas Bulwahn, Jarkko Sakkinen, Sumit Garg, Mimi Zohar,
	linux-integrity, keyrings, Sebastian Duda, Joe Perches,
	kernel-janitors, linux-kernel



On Thu, 5 Mar 2020, James Bottomley wrote:

> On Thu, 2020-03-05 at 21:34 +0100, Lukas Bulwahn wrote:
> > 
> > On Thu, 5 Mar 2020, Jarkko Sakkinen wrote:
> > 
> > > On Wed, 2020-03-04 at 17:03 +0100, Lukas Bulwahn wrote:
> > > > Commit 47f9c2796891 ("KEYS: trusted: Create trusted keys
> > > > subsystem")
> > > > renamed trusted.h to trusted_tpm.h in include/keys/, and moved
> > > > trusted.c
> > > > to trusted-keys/trusted_tpm1.c in security/keys/.
> > > > 
> > > > Since then, ./scripts/get_maintainer.pl --self-test complains:
> > > > 
> > > >   warning: no file matches F: security/keys/trusted.c
> > > >   warning: no file matches F: include/keys/trusted.h
> > > > 
> > > > Rectify the KEYS-TRUSTED entry in MAINTAINERS now.
> > > > 
> > > > Co-developed-by: Sebastian Duda <sebastian.duda@fau.de>
> > > > Signed-off-by: Sebastian Duda <sebastian.duda@fau.de>
> > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> > > > ---
> > > > Sumit, please ack.
> > > > Jarkko, please pick this patch.
> > > 
> > > I'll pick it when it is done. I acknowledge the regression but I
> > > see no reason for rushing as this does not break any systems in
> > > the wild.
> > > 
> > 
> > Agree. No need to rush this. I sent out a v3, and I hope to get
> > Sumit's ACK and then you can pick it for the next merge window.
> 
> From a process point of view, I don't quite understand this.  You're
> altering an entry in the MAINTAINERS file which belongs to the three
> maintainers of trusted keys, you only need our ack to do that, which
> picking up via the trusted key tree will substitute for.  It would be
> useful to have Sumit review this because he moved the files and there
> may be something we missed, but a reviewed-by: is a nice to have and
> not a block on the process.
>

Agree. I expect Sumit to acknowledge that the PATCH v3 "fixes" what he 
missed in his commit from his point of view. I do not use the Fixes: tag, 
because it just some basic administrative clean-up, but not any 
functional change; commits with Fixes: tags are quickly picked up for 
stable, but this patch should not be picked up, because changes to 
MAINTAINERS do not need to be reflected in stable branches.

There is no rush and no blocker here.

Lukas

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04 16:03 [PATCH] MAINTAINERS: adjust to trusted keys subsystem creation Lukas Bulwahn
2020-03-04 16:12 ` James Bottomley
2020-03-04 21:15   ` Lukas Bulwahn
2020-03-05 11:25 ` Jarkko Sakkinen
2020-03-05 20:34   ` Lukas Bulwahn
2020-03-05 20:46     ` James Bottomley
2020-03-05 21:10       ` Lukas Bulwahn

Linux-Integrity Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-integrity/0 linux-integrity/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-integrity linux-integrity/ https://lore.kernel.org/linux-integrity \
		linux-integrity@vger.kernel.org
	public-inbox-index linux-integrity

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-integrity


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git