iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86
@ 2019-10-17  0:57 Boqun Feng
  2019-10-17 23:31 ` Michael Kelley via iommu
  2019-10-28 16:20 ` Sasha Levin
  0 siblings, 2 replies; 3+ messages in thread
From: Boqun Feng @ 2019-10-17  0:57 UTC (permalink / raw)
  To: iommu, linux-kernel; +Cc: Boqun Feng, Lan Tianyu, linux-hyperv, Michael Kelley

Currently hyperv-iommu is implemented in a x86 specific way, for
example, apic is used. So make the HYPERV_IOMMU Kconfig depend on X86
as a preparation for enabling HyperV on architecture other than x86.

Cc: Lan Tianyu <Tianyu.Lan@microsoft.com>
Cc: Michael Kelley <mikelley@microsoft.com>
Cc: linux-hyperv@vger.kernel.org
Signed-off-by: Boqun Feng (Microsoft) <boqun.feng@gmail.com>
---

Without this patch, I could observe compile error:

| drivers/iommu/hyperv-iommu.c:17:10: fatal error: asm/apic.h: No such
| file or directory
|   17 | #include <asm/apic.h>
|      |          ^~~~~~~~~~~~

, after apply Michael's ARM64 on HyperV enablement patchset.

 drivers/iommu/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
index e3842eabcfdd..f1086eaed41c 100644
--- a/drivers/iommu/Kconfig
+++ b/drivers/iommu/Kconfig
@@ -467,7 +467,7 @@ config QCOM_IOMMU
 
 config HYPERV_IOMMU
 	bool "Hyper-V x2APIC IRQ Handling"
-	depends on HYPERV
+	depends on HYPERV && X86
 	select IOMMU_API
 	default HYPERV
 	help
-- 
2.23.0

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86
  2019-10-17  0:57 [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86 Boqun Feng
@ 2019-10-17 23:31 ` Michael Kelley via iommu
  2019-10-28 16:20 ` Sasha Levin
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Kelley via iommu @ 2019-10-17 23:31 UTC (permalink / raw)
  To: boqun.feng, iommu, linux-kernel; +Cc: boqun.feng, Tianyu Lan, linux-hyperv

From: Boqun Feng <boqun.feng@gmail.com> Sent: Wednesday, October 16, 2019 5:57 PM
> 
> Currently hyperv-iommu is implemented in a x86 specific way, for
> example, apic is used. So make the HYPERV_IOMMU Kconfig depend on X86
> as a preparation for enabling HyperV on architecture other than x86.
> 
> Cc: Lan Tianyu <Tianyu.Lan@microsoft.com>
> Cc: Michael Kelley <mikelley@microsoft.com>
> Cc: linux-hyperv@vger.kernel.org
> Signed-off-by: Boqun Feng (Microsoft) <boqun.feng@gmail.com>
> ---
> 
> Without this patch, I could observe compile error:
> 
> | drivers/iommu/hyperv-iommu.c:17:10: fatal error: asm/apic.h: No such
> | file or directory
> |   17 | #include <asm/apic.h>
> |      |          ^~~~~~~~~~~~
> 
> , after apply Michael's ARM64 on HyperV enablement patchset.
> 
>  drivers/iommu/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig
> index e3842eabcfdd..f1086eaed41c 100644
> --- a/drivers/iommu/Kconfig
> +++ b/drivers/iommu/Kconfig
> @@ -467,7 +467,7 @@ config QCOM_IOMMU
> 
>  config HYPERV_IOMMU
>  	bool "Hyper-V x2APIC IRQ Handling"
> -	depends on HYPERV
> +	depends on HYPERV && X86
>  	select IOMMU_API
>  	default HYPERV
>  	help
> --
> 2.23.0

Reviewed-by: Michael Kelley <mikelley@microsoft.com>

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86
  2019-10-17  0:57 [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86 Boqun Feng
  2019-10-17 23:31 ` Michael Kelley via iommu
@ 2019-10-28 16:20 ` Sasha Levin
  1 sibling, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2019-10-28 16:20 UTC (permalink / raw)
  To: Boqun Feng; +Cc: linux-hyperv, Lan Tianyu, linux-kernel, Michael Kelley, iommu

On Thu, Oct 17, 2019 at 08:57:03AM +0800, Boqun Feng wrote:
>Currently hyperv-iommu is implemented in a x86 specific way, for
>example, apic is used. So make the HYPERV_IOMMU Kconfig depend on X86
>as a preparation for enabling HyperV on architecture other than x86.
>
>Cc: Lan Tianyu <Tianyu.Lan@microsoft.com>
>Cc: Michael Kelley <mikelley@microsoft.com>
>Cc: linux-hyperv@vger.kernel.org
>Signed-off-by: Boqun Feng (Microsoft) <boqun.feng@gmail.com>

Queued up for hyperv-fixes, thanks!

-- 
Thanks,
Sasha
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-28 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-17  0:57 [PATCH] drivers: iommu: hyperv: Make HYPERV_IOMMU only available on x86 Boqun Feng
2019-10-17 23:31 ` Michael Kelley via iommu
2019-10-28 16:20 ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).