iommu.lists.linux-foundation.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Baolu Lu <baolu.lu@linux.intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
	Christoph Hellwig <hch@infradead.org>,
	Kevin Tian <kevin.tian@intel.com>,
	Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.com>,
	Dave Jiang <dave.jiang@intel.com>, Vinod Koul <vkoul@kernel.org>,
	Eric Auger <eric.auger@redhat.com>, Liu Yi L <yi.l.liu@intel.com>,
	Jacob jun Pan <jacob.jun.pan@intel.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	Zhu Tony <tony.zhu@intel.com>,
	iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
	Jean-Philippe Brucker <jean-philippe@linaro.org>
Subject: Re: [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu interface
Date: Wed, 3 Aug 2022 16:03:23 -0300	[thread overview]
Message-ID: <YurGexaP/Q+N02dT@nvidia.com> (raw)
In-Reply-To: <3eb62531-fa1c-4c78-c1d2-526a3758a033@linux.intel.com>

On Wed, Aug 03, 2022 at 09:07:35PM +0800, Baolu Lu wrote:
> +/**
> + * iommu_device_claim_pasid_owner() - Set ownership of a pasid on device
> + * @dev: the device.
> + * @pasid: the pasid of the device.
> + * @owner: caller specified pointer. Used for exclusive ownership.
> + *
> + * Return 0 if it is allowed, otherwise an error.
> + */
> +int iommu_device_claim_pasid_owner(struct device *dev, ioasid_t pasid, void
> *owner)

I don't see a use case for a special "pasid owner"

PASID is no different from normal DMA. If the calling driver already
has the proper ownership of the device/group then it is fine for that
driver to use any kind of IOMMU attachment, RID, PASID, whatever. It
doesn't matter *how* the attachment is made.

Remember the series that got dropped about converting all the drivers
to the new ownership scheme? That is how it should work - owernship
and domain attach are two different operations and do not get mixed
confusingly together. (and are you going to repost that series? It
would be great to get it done)

Jason

  reply	other threads:[~2022-08-03 19:03 UTC|newest]

Thread overview: 90+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-05  5:06 [PATCH v10 00/12] iommu: SVA and IOPF refactoring Lu Baolu
2022-07-05  5:06 ` [PATCH v10 01/12] iommu: Add max_pasids field in struct iommu_device Lu Baolu
2022-07-23 13:57   ` Jason Gunthorpe
2022-07-31 11:54   ` Yi Liu
2022-07-31 13:33     ` Baolu Lu
2022-07-05  5:07 ` [PATCH v10 02/12] iommu: Add max_pasids field in struct dev_iommu Lu Baolu
2022-07-23 14:02   ` Jason Gunthorpe
2022-07-31 11:55   ` Yi Liu
2022-07-05  5:07 ` [PATCH v10 03/12] iommu: Remove SVM_FLAG_SUPERVISOR_MODE support Lu Baolu
2022-07-31 12:01   ` Yi Liu
2022-07-31 13:39     ` Baolu Lu
2022-07-05  5:07 ` [PATCH v10 04/12] iommu: Add attach/detach_dev_pasid iommu interface Lu Baolu
2022-07-07  1:51   ` Tian, Kevin
2022-07-23 14:11   ` Jason Gunthorpe
2022-07-24  7:03     ` Baolu Lu
2022-07-25 14:40       ` Jason Gunthorpe
2022-07-26  6:23         ` Baolu Lu
2022-07-26 13:57           ` Jason Gunthorpe
2022-07-27  3:20             ` Tian, Kevin
2022-07-27 11:53               ` Jason Gunthorpe
2022-07-28  3:06                 ` Tian, Kevin
2022-07-28 11:59                   ` Jason Gunthorpe
2022-07-29  2:49                     ` Baolu Lu
2022-07-29  2:56                       ` Tian, Kevin
2022-07-29  3:20                         ` Baolu Lu
2022-07-29  4:22                           ` Tian, Kevin
2022-07-30  6:17                             ` Baolu Lu
2022-07-29  2:51                     ` Tian, Kevin
2022-07-29 12:22                       ` Jason Gunthorpe
2022-07-30  6:23                         ` Baolu Lu
2022-07-28  2:44             ` Baolu Lu
2022-07-28  6:27               ` Baolu Lu
2022-08-02  2:19             ` Baolu Lu
2022-08-02 12:37               ` Jason Gunthorpe
2022-08-03 13:07                 ` Baolu Lu
2022-08-03 19:03                   ` Jason Gunthorpe [this message]
2022-08-04  2:03                     ` Tian, Kevin
2022-08-04  2:42                     ` Baolu Lu
2022-07-24  7:23     ` Baolu Lu
2022-07-24  8:39     ` Baolu Lu
2022-07-24  9:13     ` Baolu Lu
2022-07-25  7:46       ` Tian, Kevin
2022-07-25 10:11         ` Baolu Lu
2022-07-31 12:10   ` Yi Liu
2022-07-05  5:07 ` [PATCH v10 05/12] iommu: Add IOMMU SVA domain support Lu Baolu
2022-07-07  1:52   ` Tian, Kevin
2022-07-07  3:01     ` Baolu Lu
2022-07-23 14:15   ` Jason Gunthorpe
2022-07-31 12:19   ` Yi Liu
2022-07-05  5:07 ` [PATCH v10 06/12] iommu/vt-d: Add " Lu Baolu
2022-07-23 14:16   ` Jason Gunthorpe
2022-07-31 12:20   ` Yi Liu
2022-07-05  5:07 ` [PATCH v10 07/12] arm-smmu-v3/sva: " Lu Baolu
2022-07-23 14:20   ` Jason Gunthorpe
2022-07-24 11:58     ` Baolu Lu
2022-07-05  5:07 ` [PATCH v10 08/12] iommu/sva: Refactoring iommu_sva_bind/unbind_device() Lu Baolu
2022-07-05 17:43   ` Jean-Philippe Brucker
2022-07-07  1:56   ` Tian, Kevin
2022-07-07  3:02     ` Baolu Lu
2022-07-23 14:26   ` Jason Gunthorpe
2022-07-24 13:48     ` Baolu Lu
2022-07-25  7:39       ` Jean-Philippe Brucker
2022-07-25  8:02         ` Tian, Kevin
2022-07-25  8:47           ` Jean-Philippe Brucker
2022-07-25  9:33         ` Baolu Lu
2022-07-25  9:52           ` Jean-Philippe Brucker
2022-07-25 14:46             ` Jason Gunthorpe
2022-07-25  7:50       ` Tian, Kevin
2022-07-25 10:22         ` Baolu Lu
2022-07-25 14:47           ` Jason Gunthorpe
2022-07-26  8:47             ` Baolu Lu
2022-07-31 12:36   ` Yi Liu
2022-07-31 13:45     ` Baolu Lu
2022-07-31 12:55   ` Yi Liu
2022-07-31 13:51     ` Baolu Lu
2022-07-05  5:07 ` [PATCH v10 09/12] iommu: Remove SVA related callbacks from iommu ops Lu Baolu
2022-07-23 14:27   ` Jason Gunthorpe
2022-07-31 12:38   ` Yi Liu
2022-07-05  5:07 ` [PATCH v10 10/12] iommu: Prepare IOMMU domain for IOPF Lu Baolu
2022-07-07  1:58   ` Tian, Kevin
2022-07-23 14:33   ` Jason Gunthorpe
2022-07-24 14:04     ` Baolu Lu
2022-07-25 14:49       ` Jason Gunthorpe
2022-07-31 12:50   ` Yi Liu
2022-07-31 13:47     ` Baolu Lu
2022-07-05  5:07 ` [PATCH v10 11/12] iommu: Per-domain I/O page fault handling Lu Baolu
2022-07-07  2:06   ` Tian, Kevin
2022-07-23 14:34   ` Jason Gunthorpe
2022-07-05  5:07 ` [PATCH v10 12/12] iommu: Rename iommu-sva-lib.{c,h} Lu Baolu
2022-07-23 14:34   ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YurGexaP/Q+N02dT@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dave.jiang@intel.com \
    --cc=eric.auger@redhat.com \
    --cc=hch@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=jacob.jun.pan@intel.com \
    --cc=jean-philippe@linaro.com \
    --cc=jean-philippe@linaro.org \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=tony.zhu@intel.com \
    --cc=vkoul@kernel.org \
    --cc=will@kernel.org \
    --cc=yi.l.liu@intel.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).