From: Lu Baolu <baolu.lu@linux.intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>, Tom Murphy <murphyt7@tcd.ie>,
David Woodhouse <dwmw2@infradead.org>,
Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, Intel-gfx@lists.freedesktop.org,
Ashok Raj <ashok.raj@intel.com>,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH v3 0/6] Convert the intel iommu driver to the dma-iommu api
Date: Thu, 24 Sep 2020 10:35:55 +0800 [thread overview]
Message-ID: <a689dd8f-5390-fd4e-ab91-5ba5549faa9c@linux.intel.com> (raw)
In-Reply-To: <9173fed9-e60f-5189-e17d-b23bfabdaa38@linux.intel.com>
Hi Tvrtko,
On 9/15/20 4:31 PM, Tvrtko Ursulin wrote:
>>> With the previous version of the series I hit a problem on Ivybridge
>>> where apparently the dma engine width is not respected. At least that
>>> is my layman interpretation of the errors. From the older thread:
>>>
>>> <3> [209.526605] DMAR: intel_iommu_map: iommu width (39) is not
>>> sufficient for the mapped address (ffff008000)
>>>
>>> Relevant iommu boot related messages are:
>>>
>>> <6>[ 0.184234] DMAR: Host address width 36
>>> <6>[ 0.184245] DMAR: DRHD base: 0x000000fed90000 flags: 0x0
>>> <6>[ 0.184288] DMAR: dmar0: reg_base_addr fed90000 ver 1:0 cap
>>> c0000020e60262 ecap f0101a
>>> <6>[ 0.184308] DMAR: DRHD base: 0x000000fed91000 flags: 0x1
>>> <6>[ 0.184337] DMAR: dmar1: reg_base_addr fed91000 ver 1:0 cap
>>> c9008020660262 ecap f0105a
>>> <6>[ 0.184357] DMAR: RMRR base: 0x000000d8d28000 end:
>>> 0x000000d8d46fff
>>> <6>[ 0.184377] DMAR: RMRR base: 0x000000db000000 end:
>>> 0x000000df1fffff
>>> <6>[ 0.184398] DMAR-IR: IOAPIC id 2 under DRHD base 0xfed91000
>>> IOMMU 1
>>> <6>[ 0.184414] DMAR-IR: HPET id 0 under DRHD base 0xfed91000
>>> <6>[ 0.184428] DMAR-IR: Queued invalidation will be enabled to
>>> support x2apic and Intr-remapping.
>>> <6>[ 0.185173] DMAR-IR: Enabled IRQ remapping in x2apic mode
>>>
>>> <6>[ 0.878934] DMAR: No ATSR found
>>> <6>[ 0.878966] DMAR: dmar0: Using Queued invalidation
>>> <6>[ 0.879007] DMAR: dmar1: Using Queued invalidation
>>>
>>> <6>[ 0.915032] DMAR: Intel(R) Virtualization Technology for
>>> Directed I/O
>>> <6>[ 0.915060] PCI-DMA: Using software bounce buffering for IO
>>> (SWIOTLB)
>>> <6>[ 0.915084] software IO TLB: mapped [mem 0xc80d4000-0xcc0d4000]
>>> (64MB)
>>>
>>> (Full boot log at
>>> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_7054/fi-ivb-3770/boot0.txt,
>>> failures at
>>> https://intel-gfx-ci.01.org/tree/drm-tip/Trybot_7054/fi-ivb-3770/igt@i915_selftest@live@blt.html.)
>>>
>>>
>>> Does this look familiar or at least plausible to you? Is this
>>> something your new series has fixed?
>>
>> This happens during attaching a domain to device. It has nothing to do
>> with this patch series. I will look into this issue, but not in this
>> email thread context.
>
> I am not sure what step is attaching domain to device, but these type
> messages:
>
> <3> [209.526605] DMAR: intel_iommu_map: iommu width (39) is not
> >> sufficient for the mapped address (ffff008000)
>
> They definitely appear to happen at runtime, as i915 is getting
> exercised by userspace.
Can you please check whether below change helps here?
diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index c8323a9f8bde..0484c539debc 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -724,6 +724,7 @@ static int domain_update_device_node(struct
dmar_domain *domain)
/* Some capabilities may be different across iommus */
static void domain_update_iommu_cap(struct dmar_domain *domain)
{
+ domain->geometry.aperture_end = __DOMAIN_MAX_ADDR(dmar_domain->gaw);
domain_update_iommu_coherency(domain);
domain->iommu_snooping = domain_update_iommu_snooping(NULL);
domain->iommu_superpage = domain_update_iommu_superpage(domain,
NULL);
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-09-24 2:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-12 3:21 [PATCH v3 0/6] Convert the intel iommu driver to the dma-iommu api Lu Baolu
2020-09-12 3:21 ` [PATCH v3 1/6] iommu: Handle freelists when using deferred flushing in iommu drivers Lu Baolu
2020-09-12 3:21 ` [PATCH v3 2/6] iommu: Add iommu_dma_free_cpu_cached_iovas() Lu Baolu
2020-09-12 3:21 ` [PATCH v3 3/6] iommu: Allow the dma-iommu api to use bounce buffers Lu Baolu
2020-09-12 3:21 ` [PATCH v3 4/6] iommu: Add quirk for Intel graphic devices in map_sg Lu Baolu
2020-09-12 3:21 ` [PATCH v3 5/6] iommu/vt-d: Convert intel iommu driver to the iommu ops Lu Baolu
2020-09-12 3:22 ` [PATCH v3 6/6] iommu/vt-d: Cleanup after converting to dma-iommu ops Lu Baolu
2020-09-14 8:04 ` [PATCH v3 0/6] Convert the intel iommu driver to the dma-iommu api Tvrtko Ursulin
2020-09-15 1:47 ` Lu Baolu
2020-09-15 8:31 ` Tvrtko Ursulin
2020-09-22 11:05 ` Robin Murphy
2020-09-23 5:38 ` Lu Baolu
2020-09-24 2:35 ` Lu Baolu [this message]
2020-09-18 20:47 ` [Intel-gfx] " Logan Gunthorpe
2020-09-20 6:36 ` Lu Baolu
2020-09-21 15:48 ` Logan Gunthorpe
2020-09-22 0:24 ` Lu Baolu
2020-09-22 15:38 ` Logan Gunthorpe
2020-09-22 9:51 ` Robin Murphy
2020-09-22 18:45 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a689dd8f-5390-fd4e-ab91-5ba5549faa9c@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=ashok.raj@intel.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).