From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Rohit Agarwal <quic_rohiagar@quicinc.com>,
agross@kernel.org, andersson@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
rafael@kernel.org, viresh.kumar@linaro.org, tglx@linutronix.de,
maz@kernel.org, will@kernel.org, robin.murphy@arm.com,
joro@8bytes.org, mani@kernel.org, robimarko@gmail.com
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev
Subject: Re: [PATCH v2 08/10] arm64: dts: qcom: Add QUPv3 UART console node for SDX75
Date: Mon, 5 Jun 2023 20:17:27 +0200 [thread overview]
Message-ID: <d8c9b229-47ab-cedd-3515-4faf3146e6f8@linaro.org> (raw)
In-Reply-To: <1685982557-28326-9-git-send-email-quic_rohiagar@quicinc.com>
On 5.06.2023 18:29, Rohit Agarwal wrote:
> Add the debug uart console node in devicetree.
>
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sdx75.dtsi | 49 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 49 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> index f83eef8..47170ae 100644
> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> @@ -385,6 +385,34 @@
> #power-domain-cells = <1>;
> };
>
> + qupv3_id_0: geniqup@9c0000 {
> + compatible = "qcom,geni-se-qup";
> + reg = <0x0 0x009c0000 0x0 0x2000>;
> + clocks = <&gcc GCC_QUPV3_WRAP_0_M_AHB_CLK>,
> + <&gcc GCC_QUPV3_WRAP_0_S_AHB_CLK>;
> + clock-names = "m-ahb",
> + "s-ahb";
> + iommus = <&apps_smmu 0xe3 0x0>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> + status = "disabled";
> +
> + uart1: serial@984000 {
> + compatible = "qcom,geni-debug-uart";
> + reg = <0x0 0x00984000 0x0 0x4000>;
> + clock-names = "se";
> + clocks = <&gcc GCC_QUPV3_WRAP0_S1_CLK>;
> + interrupts = <GIC_SPI 338 IRQ_TYPE_LEVEL_HIGH>;
> + pinctrl-0 = <&qupv3_se1_2uart_tx_active>,
> + <&qupv3_se1_2uart_rx_active>;
> + pinctrl-1 = <&qupv3_se1_2uart_sleep>;
> + pinctrl-names = "default",
> + "sleep";
> + status = "disabled";
> + };
> + };
> +
> tcsr_mutex: hwlock@1f40000 {
> compatible = "qcom,tcsr-mutex";
> reg = <0x0 0x01f40000 0x0 0x40000>;
> @@ -413,6 +441,27 @@
> interrupt-controller;
> #interrupt-cells = <2>;
> wakeup-parent = <&pdc>;
> +
> + qupv3_se1_2uart_tx_active: qupv3-se1-2uart-tx-active-state {
> + pins = "gpio12";
> + function = "qup_se1_l2_mira";
> + drive-strength= <2>;
> + bias-disable;
> + };
You can bunch these two up like this:
qupv3_se1_2uart_active: qup.... {
tx {
pins = ...
foo = ...
};
rx {
pins = ...
bar = ...
};
};
Konrad
> +
> + qupv3_se1_2uart_rx_active: qupv3-se1-2uart-rx-active-state {
> + pins = "gpio13";
> + function = "qup_se1_l3_mira";
> + drive-strength= <2>;
> + bias-disable;
> + };
> +
> + qupv3_se1_2uart_sleep: qupv3-se1-2uart-sleep-state {
> + pins = "gpio12", "gpio13";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> };
>
> apps_smmu: iommu@15000000 {
next prev parent reply other threads:[~2023-06-05 18:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 16:29 [PATCH v2 00/10] Add devicetree support for SDX75 Modem and IDP Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 01/10] dt-bindings: arm: qcom: Document SDX75 platform and boards Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 02/10] dt-bindings: firmware: scm: Add compatible for SDX75 Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 03/10] dt-bindings: interrupt-controller: Add SDX75 PDC compatible Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 04/10] dt-bindings: arm-smmu: Add SDX75 SMMU compatible Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 05/10] dt-bindings: cpufreq: cpufreq-qcom-hw: Add SDX75 compatible Rohit Agarwal
2023-06-06 5:09 ` Viresh Kumar
2023-06-06 6:04 ` Krzysztof Kozlowski
2023-06-05 16:29 ` [PATCH v2 06/10] arm64: dts: qcom: Add SDX75 platform and IDP board support Rohit Agarwal
2023-06-05 18:15 ` Konrad Dybcio
2023-06-06 8:04 ` Rohit Agarwal
2023-06-06 9:36 ` Konrad Dybcio
2023-06-06 11:42 ` Rohit Agarwal
2023-06-06 12:18 ` Konrad Dybcio
2023-06-07 7:01 ` Rohit Agarwal
[not found] ` <ffaa2700-27d1-f406-bcef-ac042ad1af61@quicinc.com>
2023-06-07 8:43 ` Konrad Dybcio
2023-06-07 8:51 ` Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 07/10] arm64: dts: qcom: Add support for GCC and RPMHCC for SDX75 Rohit Agarwal
2023-06-05 18:16 ` Konrad Dybcio
2023-06-05 18:30 ` Dmitry Baryshkov
2023-06-06 6:45 ` Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 08/10] arm64: dts: qcom: Add QUPv3 UART console node " Rohit Agarwal
2023-06-05 18:17 ` Konrad Dybcio [this message]
2023-06-06 8:06 ` Rohit Agarwal
2023-06-06 6:06 ` Krzysztof Kozlowski
2023-06-06 6:33 ` Rohit Agarwal
2023-06-05 16:29 ` [PATCH v2 09/10] arm64: dts: qcom: Enable the QUPv3 UART console " Rohit Agarwal
2023-06-06 6:06 ` Krzysztof Kozlowski
2023-06-05 16:29 ` [PATCH v2 10/10] arm64: dts: qcom: Add the support of cpufreq on SDX75 Rohit Agarwal
2023-06-05 18:21 ` Konrad Dybcio
2023-06-06 9:32 ` Pavan Kondeti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8c9b229-47ab-cedd-3515-4faf3146e6f8@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mani@kernel.org \
--cc=maz@kernel.org \
--cc=quic_rohiagar@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robimarko@gmail.com \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).