* Re: [PATCH] firmware/Makefile: force recompilation if makefile changes [not found] ` <20170119101507.GA18592@kroah.com> @ 2017-01-23 14:59 ` Luis R. Rodriguez 2017-01-23 15:02 ` Greg KH 0 siblings, 1 reply; 12+ messages in thread From: Luis R. Rodriguez @ 2017-01-23 14:59 UTC (permalink / raw) To: Greg KH; +Cc: ming.lei, wagi, dwmw2, linux-kernel, Michal Marek, linux-kbuild On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote: > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote: > > If you modify the target asm we currently do not force the > > recompilation of the firmware files. The target asm is in > > the firmware/Makefile, peg this file as a dependency to > > require re-compilation of firmware targets when the asm > > changes. > > Why would changing the Makefile require the asm to change? The Makefile is the file that provides the assembly logic, so changing the asm should affect recreating the binary. > Anyway, this should go through the kbuild tree, not mine, they know > Makefiles much better than I do... Will send it there. Thanks. Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] firmware/Makefile: force recompilation if makefile changes 2017-01-23 14:59 ` [PATCH] firmware/Makefile: force recompilation if makefile changes Luis R. Rodriguez @ 2017-01-23 15:02 ` Greg KH 2017-01-23 15:04 ` Luis R. Rodriguez 0 siblings, 1 reply; 12+ messages in thread From: Greg KH @ 2017-01-23 15:02 UTC (permalink / raw) To: Luis R. Rodriguez Cc: ming.lei, wagi, dwmw2, linux-kernel, Michal Marek, linux-kbuild On Mon, Jan 23, 2017 at 03:59:52PM +0100, Luis R. Rodriguez wrote: > On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote: > > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote: > > > If you modify the target asm we currently do not force the > > > recompilation of the firmware files. The target asm is in > > > the firmware/Makefile, peg this file as a dependency to > > > require re-compilation of firmware targets when the asm > > > changes. > > > > Why would changing the Makefile require the asm to change? > > The Makefile is the file that provides the assembly logic, so > changing the asm should affect recreating the binary. Ah, I see it now, that's horrid, echoing asm from the Makefile itself :) thanks, greg k-h ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] firmware/Makefile: force recompilation if makefile changes 2017-01-23 15:02 ` Greg KH @ 2017-01-23 15:04 ` Luis R. Rodriguez 0 siblings, 0 replies; 12+ messages in thread From: Luis R. Rodriguez @ 2017-01-23 15:04 UTC (permalink / raw) To: Greg KH Cc: Ming Lei, Daniel Wagner, David Woodhouse, linux-kernel, Michal Marek, linux-kbuild On Mon, Jan 23, 2017 at 9:02 AM, Greg KH <gregkh@linuxfoundation.org> wrote: > On Mon, Jan 23, 2017 at 03:59:52PM +0100, Luis R. Rodriguez wrote: >> On Thu, Jan 19, 2017 at 11:15:07AM +0100, Greg KH wrote: >> > On Wed, Jan 18, 2017 at 09:31:56AM -0800, Luis R. Rodriguez wrote: >> > > If you modify the target asm we currently do not force the >> > > recompilation of the firmware files. The target asm is in >> > > the firmware/Makefile, peg this file as a dependency to >> > > require re-compilation of firmware targets when the asm >> > > changes. >> > >> > Why would changing the Makefile require the asm to change? >> >> The Makefile is the file that provides the assembly logic, so >> changing the asm should affect recreating the binary. > > Ah, I see it now, that's horrid, echoing asm from the Makefile itself :) Yeah, I can change the way that works but I think I would much prefer to make that a separate atomic functional change. Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH v2] firmware/Makefile: force recompilation if makefile changes [not found] <20170118173156.16060-1-mcgrof@kernel.org> [not found] ` <20170119101507.GA18592@kroah.com> @ 2017-01-23 15:07 ` Luis R. Rodriguez 2017-02-06 22:03 ` Luis R. Rodriguez 2017-03-11 5:37 ` Masahiro Yamada 1 sibling, 2 replies; 12+ messages in thread From: Luis R. Rodriguez @ 2017-01-23 15:07 UTC (permalink / raw) To: mmarek Cc: linux-kbuild, ming.lei, gregkh, teg, linux-kernel, dwmw2, Luis R. Rodriguez If you modify the target asm we currently do not force the recompilation of the firmware files. The target asm is in the firmware/Makefile, peg this file as a dependency to require re-compilation of firmware targets when the asm changes. Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- Michal, I had this patch as part of my linker table series [0] but have split it off as its a small atomic separate change and can go in separately. Greg prefers this be reviewed by the kbuild tree so sending it your way. This v2 has no modifications, just resending it to the kbuild tree. [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org firmware/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/firmware/Makefile b/firmware/Makefile index e297e1b52636..fa3e81c2a97b 100644 --- a/firmware/Makefile +++ b/firmware/Makefile @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ include/config/ppc32.h include/config/ppc64.h \ include/config/superh32.h include/config/superh64.h \ - include/config/x86_32.h include/config/x86_64.h) + include/config/x86_32.h include/config/x86_64.h \ + firmware/Makefile) $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) -- 2.11.0 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-01-23 15:07 ` [PATCH v2] " Luis R. Rodriguez @ 2017-02-06 22:03 ` Luis R. Rodriguez 2017-02-14 19:34 ` Luis R. Rodriguez 2017-03-11 5:37 ` Masahiro Yamada 1 sibling, 1 reply; 12+ messages in thread From: Luis R. Rodriguez @ 2017-02-06 22:03 UTC (permalink / raw) To: Luis R. Rodriguez Cc: mmarek, linux-kbuild, ming.lei, gregkh, teg, linux-kernel, dwmw2 On Mon, Jan 23, 2017 at 07:07:27AM -0800, Luis R. Rodriguez wrote: > If you modify the target asm we currently do not force the > recompilation of the firmware files. The target asm is in > the firmware/Makefile, peg this file as a dependency to > require re-compilation of firmware targets when the asm > changes. > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > --- > > Michal, > > I had this patch as part of my linker table series [0] but have split it > off as its a small atomic separate change and can go in separately. Greg > prefers this be reviewed by the kbuild tree so sending it your way. > This v2 has no modifications, just resending it to the kbuild tree. > > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org *Poke* Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-02-06 22:03 ` Luis R. Rodriguez @ 2017-02-14 19:34 ` Luis R. Rodriguez 2017-02-21 19:38 ` Luis R. Rodriguez 0 siblings, 1 reply; 12+ messages in thread From: Luis R. Rodriguez @ 2017-02-14 19:34 UTC (permalink / raw) To: Luis R. Rodriguez Cc: mmarek, linux-kbuild, ming.lei, gregkh, teg, linux-kernel, dwmw2 On Mon, Feb 06, 2017 at 11:03:52PM +0100, Luis R. Rodriguez wrote: > On Mon, Jan 23, 2017 at 07:07:27AM -0800, Luis R. Rodriguez wrote: > > If you modify the target asm we currently do not force the > > recompilation of the firmware files. The target asm is in > > the firmware/Makefile, peg this file as a dependency to > > require re-compilation of firmware targets when the asm > > changes. > > > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > > --- > > > > Michal, > > > > I had this patch as part of my linker table series [0] but have split it > > off as its a small atomic separate change and can go in separately. Greg > > prefers this be reviewed by the kbuild tree so sending it your way. > > This v2 has no modifications, just resending it to the kbuild tree. > > > > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org > > *Poke* *Re-poke* Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-02-14 19:34 ` Luis R. Rodriguez @ 2017-02-21 19:38 ` Luis R. Rodriguez 0 siblings, 0 replies; 12+ messages in thread From: Luis R. Rodriguez @ 2017-02-21 19:38 UTC (permalink / raw) To: Luis R. Rodriguez Cc: mmarek, linux-kbuild, ming.lei, gregkh, teg, linux-kernel, dwmw2, Andrew Morton On Tue, Feb 14, 2017 at 08:34:15PM +0100, Luis R. Rodriguez wrote: > On Mon, Feb 06, 2017 at 11:03:52PM +0100, Luis R. Rodriguez wrote: > > On Mon, Jan 23, 2017 at 07:07:27AM -0800, Luis R. Rodriguez wrote: > > > If you modify the target asm we currently do not force the > > > recompilation of the firmware files. The target asm is in > > > the firmware/Makefile, peg this file as a dependency to > > > require re-compilation of firmware targets when the asm > > > changes. > > > > > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > > > --- > > > > > > Michal, > > > > > > I had this patch as part of my linker table series [0] but have split it > > > off as its a small atomic separate change and can go in separately. Greg > > > prefers this be reviewed by the kbuild tree so sending it your way. > > > This v2 has no modifications, just resending it to the kbuild tree. > > > > > > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org > > > > *Poke* > > *Re-poke* *Re-re-poke* Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-01-23 15:07 ` [PATCH v2] " Luis R. Rodriguez 2017-02-06 22:03 ` Luis R. Rodriguez @ 2017-03-11 5:37 ` Masahiro Yamada 2017-03-15 0:53 ` Luis R. Rodriguez 1 sibling, 1 reply; 12+ messages in thread From: Masahiro Yamada @ 2017-03-11 5:37 UTC (permalink / raw) To: Luis R. Rodriguez Cc: Michal Marek, Linux Kbuild mailing list, ming.lei, Greg Kroah-Hartman, teg, Linux Kernel Mailing List, David Woodhouse Hi Luis, 2017-01-24 0:07 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: > If you modify the target asm we currently do not force the > recompilation of the firmware files. The target asm is in > the firmware/Makefile, peg this file as a dependency to > require re-compilation of firmware targets when the asm > changes. > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > --- > > Michal, > > I had this patch as part of my linker table series [0] but have split it > off as its a small atomic separate change and can go in separately. Greg > prefers this be reviewed by the kbuild tree so sending it your way. > This v2 has no modifications, just resending it to the kbuild tree. > > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org > > firmware/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/firmware/Makefile b/firmware/Makefile > index e297e1b52636..fa3e81c2a97b 100644 > --- a/firmware/Makefile > +++ b/firmware/Makefile > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ > include/config/ppc32.h include/config/ppc64.h \ > include/config/superh32.h include/config/superh64.h \ > - include/config/x86_32.h include/config/x86_64.h) > + include/config/x86_32.h include/config/x86_64.h \ > + firmware/Makefile) > > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) Why don't you use $(call filechk,...) or $(call if_changed,...) instead of wordsize_deps ? -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-03-11 5:37 ` Masahiro Yamada @ 2017-03-15 0:53 ` Luis R. Rodriguez 2017-03-16 17:43 ` Masahiro Yamada 0 siblings, 1 reply; 12+ messages in thread From: Luis R. Rodriguez @ 2017-03-15 0:53 UTC (permalink / raw) To: Masahiro Yamada Cc: Luis R. Rodriguez, Michal Marek, Linux Kbuild mailing list, ming.lei, Greg Kroah-Hartman, teg, Linux Kernel Mailing List, David Woodhouse On Sat, Mar 11, 2017 at 02:37:02PM +0900, Masahiro Yamada wrote: > Hi Luis, > > > 2017-01-24 0:07 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: > > If you modify the target asm we currently do not force the > > recompilation of the firmware files. The target asm is in > > the firmware/Makefile, peg this file as a dependency to > > require re-compilation of firmware targets when the asm > > changes. > > > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> > > --- > > > > Michal, > > > > I had this patch as part of my linker table series [0] but have split it > > off as its a small atomic separate change and can go in separately. Greg > > prefers this be reviewed by the kbuild tree so sending it your way. > > This v2 has no modifications, just resending it to the kbuild tree. > > > > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org > > > > firmware/Makefile | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/firmware/Makefile b/firmware/Makefile > > index e297e1b52636..fa3e81c2a97b 100644 > > --- a/firmware/Makefile > > +++ b/firmware/Makefile > > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ > > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ > > include/config/ppc32.h include/config/ppc64.h \ > > include/config/superh32.h include/config/superh64.h \ > > - include/config/x86_32.h include/config/x86_64.h) > > + include/config/x86_32.h include/config/x86_64.h \ > > + firmware/Makefile) > > > > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) > > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) > > > Why don't you use $(call filechk,...) or $(call if_changed,...) > instead of wordsize_deps ? Care to send a patch? Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-03-15 0:53 ` Luis R. Rodriguez @ 2017-03-16 17:43 ` Masahiro Yamada 2017-03-16 17:55 ` Luis R. Rodriguez 0 siblings, 1 reply; 12+ messages in thread From: Masahiro Yamada @ 2017-03-16 17:43 UTC (permalink / raw) To: Luis R. Rodriguez Cc: Michal Marek, Linux Kbuild mailing list, ming.lei, Greg Kroah-Hartman, Tom Gundersen, Linux Kernel Mailing List, David Woodhouse Hi Luis, 2017-03-15 9:53 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: > On Sat, Mar 11, 2017 at 02:37:02PM +0900, Masahiro Yamada wrote: >> Hi Luis, >> >> >> 2017-01-24 0:07 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: >> > If you modify the target asm we currently do not force the >> > recompilation of the firmware files. The target asm is in >> > the firmware/Makefile, peg this file as a dependency to >> > require re-compilation of firmware targets when the asm >> > changes. >> > >> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> >> > --- >> > >> > Michal, >> > >> > I had this patch as part of my linker table series [0] but have split it >> > off as its a small atomic separate change and can go in separately. Greg >> > prefers this be reviewed by the kbuild tree so sending it your way. >> > This v2 has no modifications, just resending it to the kbuild tree. >> > >> > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org >> > >> > firmware/Makefile | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/firmware/Makefile b/firmware/Makefile >> > index e297e1b52636..fa3e81c2a97b 100644 >> > --- a/firmware/Makefile >> > +++ b/firmware/Makefile >> > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ >> > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ >> > include/config/ppc32.h include/config/ppc64.h \ >> > include/config/superh32.h include/config/superh64.h \ >> > - include/config/x86_32.h include/config/x86_64.h) >> > + include/config/x86_32.h include/config/x86_64.h \ >> > + firmware/Makefile) >> > >> > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) >> > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) >> >> >> Why don't you use $(call filechk,...) or $(call if_changed,...) >> instead of wordsize_deps ? > > Care to send a patch? Sorry for my late reply. Yes, if you want, I will give it a try. But, please wait until this weekend... -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-03-16 17:43 ` Masahiro Yamada @ 2017-03-16 17:55 ` Luis R. Rodriguez 2017-03-18 13:32 ` Masahiro Yamada 0 siblings, 1 reply; 12+ messages in thread From: Luis R. Rodriguez @ 2017-03-16 17:55 UTC (permalink / raw) To: Masahiro Yamada, Andrew Morton Cc: Michal Marek, Linux Kbuild mailing list, Ming Lei, Greg Kroah-Hartman, Tom Gundersen, Linux Kernel Mailing List, David Woodhouse On Thu, Mar 16, 2017 at 10:43 AM, Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Hi Luis, > > 2017-03-15 9:53 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: >> On Sat, Mar 11, 2017 at 02:37:02PM +0900, Masahiro Yamada wrote: >>> Hi Luis, >>> >>> >>> 2017-01-24 0:07 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: >>> > If you modify the target asm we currently do not force the >>> > recompilation of the firmware files. The target asm is in >>> > the firmware/Makefile, peg this file as a dependency to >>> > require re-compilation of firmware targets when the asm >>> > changes. >>> > >>> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> >>> > --- >>> > >>> > Michal, >>> > >>> > I had this patch as part of my linker table series [0] but have split it >>> > off as its a small atomic separate change and can go in separately. Greg >>> > prefers this be reviewed by the kbuild tree so sending it your way. >>> > This v2 has no modifications, just resending it to the kbuild tree. >>> > >>> > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org >>> > >>> > firmware/Makefile | 3 ++- >>> > 1 file changed, 2 insertions(+), 1 deletion(-) >>> > >>> > diff --git a/firmware/Makefile b/firmware/Makefile >>> > index e297e1b52636..fa3e81c2a97b 100644 >>> > --- a/firmware/Makefile >>> > +++ b/firmware/Makefile >>> > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ >>> > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ >>> > include/config/ppc32.h include/config/ppc64.h \ >>> > include/config/superh32.h include/config/superh64.h \ >>> > - include/config/x86_32.h include/config/x86_64.h) >>> > + include/config/x86_32.h include/config/x86_64.h \ >>> > + firmware/Makefile) >>> > >>> > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) >>> > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) >>> >>> >>> Why don't you use $(call filechk,...) or $(call if_changed,...) >>> instead of wordsize_deps ? >> >> Care to send a patch? > > > Sorry for my late reply. > > Yes, if you want, I will give it a try. > > But, please wait until this weekend... Andrew picked up my patch already as its been sitting in limbo without any feedback for a long time --- so you can work off of what is on linux-next or we can request Andrew to drop this patch once and if you get a replacement as its not yet on Linus' tree. Luis ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH v2] firmware/Makefile: force recompilation if makefile changes 2017-03-16 17:55 ` Luis R. Rodriguez @ 2017-03-18 13:32 ` Masahiro Yamada 0 siblings, 0 replies; 12+ messages in thread From: Masahiro Yamada @ 2017-03-18 13:32 UTC (permalink / raw) To: Luis R. Rodriguez Cc: Andrew Morton, Michal Marek, Linux Kbuild mailing list, Ming Lei, Greg Kroah-Hartman, Tom Gundersen, Linux Kernel Mailing List, David Woodhouse Hi Luis, 2017-03-17 2:55 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: > On Thu, Mar 16, 2017 at 10:43 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> Hi Luis, >> >> 2017-03-15 9:53 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: >>> On Sat, Mar 11, 2017 at 02:37:02PM +0900, Masahiro Yamada wrote: >>>> Hi Luis, >>>> >>>> >>>> 2017-01-24 0:07 GMT+09:00 Luis R. Rodriguez <mcgrof@kernel.org>: >>>> > If you modify the target asm we currently do not force the >>>> > recompilation of the firmware files. The target asm is in >>>> > the firmware/Makefile, peg this file as a dependency to >>>> > require re-compilation of firmware targets when the asm >>>> > changes. >>>> > >>>> > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> >>>> > --- >>>> > >>>> > Michal, >>>> > >>>> > I had this patch as part of my linker table series [0] but have split it >>>> > off as its a small atomic separate change and can go in separately. Greg >>>> > prefers this be reviewed by the kbuild tree so sending it your way. >>>> > This v2 has no modifications, just resending it to the kbuild tree. >>>> > >>>> > [0] https://lkml.kernel.org/r/20170115211057.17167-1-mcgrof@kernel.org >>>> > >>>> > firmware/Makefile | 3 ++- >>>> > 1 file changed, 2 insertions(+), 1 deletion(-) >>>> > >>>> > diff --git a/firmware/Makefile b/firmware/Makefile >>>> > index e297e1b52636..fa3e81c2a97b 100644 >>>> > --- a/firmware/Makefile >>>> > +++ b/firmware/Makefile >>>> > @@ -176,7 +176,8 @@ quiet_cmd_fwbin = MK_FW $@ >>>> > wordsize_deps := $(wildcard include/config/64bit.h include/config/32bit.h \ >>>> > include/config/ppc32.h include/config/ppc64.h \ >>>> > include/config/superh32.h include/config/superh64.h \ >>>> > - include/config/x86_32.h include/config/x86_64.h) >>>> > + include/config/x86_32.h include/config/x86_64.h \ >>>> > + firmware/Makefile) >>>> > >>>> > $(patsubst %,$(obj)/%.gen.S, $(fw-shipped-y)): %: $(wordsize_deps) >>>> > $(call cmd,fwbin,$(patsubst %.gen.S,%,$@)) >>>> >>>> >>>> Why don't you use $(call filechk,...) or $(call if_changed,...) >>>> instead of wordsize_deps ? >>> >>> Care to send a patch? >> >> >> Sorry for my late reply. >> >> Yes, if you want, I will give it a try. >> >> But, please wait until this weekend... > > Andrew picked up my patch already as its been sitting in limbo without > any feedback for a long time OK. (and, sorry for the delay.) It is not a good idea to make your work stuck even longer. > --- so you can work off of what is on > linux-next or we can request Andrew to drop this patch once and if you > get a replacement as its not yet on Linus' tree. > Please go ahead with your patch. When I find time to take a close look, I may come back to firmware/Makefile. But, I guess it will not happen soon. -- Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2017-03-18 13:48 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20170118173156.16060-1-mcgrof@kernel.org>
[not found] ` <20170119101507.GA18592@kroah.com>
2017-01-23 14:59 ` [PATCH] firmware/Makefile: force recompilation if makefile changes Luis R. Rodriguez
2017-01-23 15:02 ` Greg KH
2017-01-23 15:04 ` Luis R. Rodriguez
2017-01-23 15:07 ` [PATCH v2] " Luis R. Rodriguez
2017-02-06 22:03 ` Luis R. Rodriguez
2017-02-14 19:34 ` Luis R. Rodriguez
2017-02-21 19:38 ` Luis R. Rodriguez
2017-03-11 5:37 ` Masahiro Yamada
2017-03-15 0:53 ` Luis R. Rodriguez
2017-03-16 17:43 ` Masahiro Yamada
2017-03-16 17:55 ` Luis R. Rodriguez
2017-03-18 13:32 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).