From: skunberg.kelsey@gmail.com (Kelsey Skunberg)
Subject: [Linux-kernel-mentees] [PATCH v3 3/4] PCI: sysfs: Change DEVICE_ATTR() to DEVICE_ATTR_WO()
Date: Thu, 15 Aug 2019 09:33:52 -0600 [thread overview]
Message-ID: <20190815153352.86143-4-skunberg.kelsey@gmail.com> (raw)
Message-ID: <20190815153352.RTOJWUssZRxgpHOUueExhxU7azpCwLrpOxYZPhqUN6g@z> (raw)
In-Reply-To: <20190813204513.4790-1-skunberg.kelsey@gmail.com>
DEVICE_ATTR() should only be used when files have unusual permissions.
Change DEVICE_ATTR() with '0220' permissions to DEVICE_ATTR_WO().
Example of old:
static DEVICE_ATTR(_name, 0220, NULL, _store);
Example of new:
static DEVICE_ATTR_WO(_name);
Since _store is no longer passed, make the _name passed by
DEVICE_ATTR_WO() and the related _name##_store() name match with each
other.
Example:
DEVICE_ATTR_WO(bus_rescan) must be able to call bus_rescan_store()
Signed-off-by: Kelsey Skunberg <skunberg.kelsey at gmail.com>
---
drivers/pci/pci-sysfs.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index 346193ca4826..5bb301efec98 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -464,7 +464,7 @@ static ssize_t dev_rescan_store(struct device *dev,
}
return count;
}
-static DEVICE_ATTR(rescan, 0220, NULL, dev_rescan_store);
+static DEVICE_ATTR_WO(dev_rescan);
static ssize_t remove_store(struct device *dev, struct device_attribute *attr,
const char *buf, size_t count)
@@ -481,9 +481,9 @@ static ssize_t remove_store(struct device *dev, struct device_attribute *attr,
static DEVICE_ATTR_IGNORE_LOCKDEP(remove, 0220, NULL,
remove_store);
-static ssize_t dev_bus_rescan_store(struct device *dev,
- struct device_attribute *attr,
- const char *buf, size_t count)
+static ssize_t bus_rescan_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
{
unsigned long val;
struct pci_bus *bus = to_pci_bus(dev);
@@ -501,7 +501,7 @@ static ssize_t dev_bus_rescan_store(struct device *dev,
}
return count;
}
-static DEVICE_ATTR(bus_rescan, 0220, NULL, dev_bus_rescan_store);
+static DEVICE_ATTR_WO(bus_rescan);
#if defined(CONFIG_PM) && defined(CONFIG_ACPI)
static ssize_t d3cold_allowed_store(struct device *dev,
@@ -1619,7 +1619,7 @@ static umode_t pci_dev_attrs_are_visible(struct kobject *kobj,
static struct attribute *pci_dev_hp_attrs[] = {
&dev_attr_remove.attr,
- &dev_attr_rescan.attr,
+ &dev_attr_dev_rescan.attr,
NULL,
};
--
2.20.1
next prev parent reply other threads:[~2019-08-15 15:33 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 19:57 [Linux-kernel-mentees] [PATCH] PCI/IOV: Move sysfs SR-IOV functions to iov.c skunberg.kelsey
2019-08-09 19:57 ` Kelsey Skunberg
2019-08-10 7:17 ` greg
2019-08-10 7:17 ` Greg KH
2019-08-10 17:15 ` helgaas
2019-08-10 17:15 ` Bjorn Helgaas
2019-08-10 17:24 ` greg
2019-08-10 17:24 ` Greg KH
2019-08-10 21:32 ` skunberg.kelsey
2019-08-10 21:32 ` Kelsey Skunberg
2019-08-13 20:45 ` [Linux-kernel-mentees] [PATCH v2 0/3] PCI: pci-sysfs.c cleanup skunberg.kelsey
2019-08-13 20:45 ` Kelsey Skunberg
2019-08-13 20:45 ` [Linux-kernel-mentees] [PATCH v2 1/3] PCI: sysfs: Define device attributes with DEVICE_ATTR*() skunberg.kelsey
2019-08-13 20:45 ` Kelsey Skunberg
2019-08-14 7:52 ` gregkh
2019-08-14 7:52 ` Greg KH
2019-08-14 23:14 ` skunberg.kelsey
2019-08-14 23:14 ` Kelsey Skunberg
2019-08-15 15:54 ` skunberg.kelsey
2019-08-15 15:54 ` Kelsey Skunberg
2019-08-13 20:45 ` [Linux-kernel-mentees] [PATCH v2 2/3] PCI: sysfs: Change permissions from symbolic to octal skunberg.kelsey
2019-08-13 20:45 ` Kelsey Skunberg
2019-08-14 5:38 ` helgaas
2019-08-14 5:38 ` Bjorn Helgaas
2019-08-14 7:53 ` gregkh
2019-08-14 7:53 ` Greg Kroah-Hartman
2019-08-15 14:37 ` ddutile
2019-08-15 14:37 ` Don Dutile
2019-09-04 6:22 ` skunberg.kelsey
2019-09-04 6:22 ` Kelsey Skunberg
2019-09-04 15:32 ` ddutile
2019-09-04 15:32 ` Don Dutile
2019-09-04 18:33 ` ddutile
2019-09-04 18:33 ` Don Dutile
2019-09-05 4:04 ` skunberg.kelsey
2019-09-05 4:04 ` Kelsey Skunberg
2019-08-13 20:45 ` [Linux-kernel-mentees] [PATCH v2 3/3] PCI/IOV: Move sysfs SR-IOV functions to iov.c skunberg.kelsey
2019-08-13 20:45 ` Kelsey Skunberg
2019-08-14 5:40 ` [Linux-kernel-mentees] [PATCH v2 0/3] PCI: pci-sysfs.c cleanup helgaas
2019-08-14 5:40 ` Bjorn Helgaas
2019-08-15 15:33 ` [Linux-kernel-mentees] [PATCH v3 0/4] PCI: Clean up pci-sysfs.c skunberg.kelsey
2019-08-15 15:33 ` Kelsey Skunberg
2019-08-15 16:08 ` gregkh
2019-08-15 16:08 ` Greg KH
2019-08-16 4:22 ` ddutile
2019-08-16 4:22 ` Don Dutile
2019-08-19 22:42 ` helgaas
2019-08-19 22:42 ` Bjorn Helgaas
2019-08-15 15:33 ` [Linux-kernel-mentees] [PATCH v3 1/4] PCI: sysfs: Define device attributes with DEVICE_ATTR* skunberg.kelsey
2019-08-15 15:33 ` Kelsey Skunberg
2020-03-14 10:51 ` Ruslan Bilovol
2020-03-14 11:20 ` Greg Kroah-Hartman
2020-03-24 6:10 ` Kelsey
2020-03-24 6:24 ` Greg Kroah-Hartman
2020-03-24 23:53 ` Kelsey
2020-03-25 7:17 ` Greg Kroah-Hartman
2020-03-25 15:15 ` Kelsey
2019-08-15 15:33 ` [Linux-kernel-mentees] [PATCH v3 2/4] PCI: sysfs: Change permissions from symbolic to octal skunberg.kelsey
2019-08-15 15:33 ` Kelsey Skunberg
2019-08-15 15:33 ` skunberg.kelsey [this message]
2019-08-15 15:33 ` [Linux-kernel-mentees] [PATCH v3 3/4] PCI: sysfs: Change DEVICE_ATTR() to DEVICE_ATTR_WO() Kelsey Skunberg
2019-08-15 15:33 ` [Linux-kernel-mentees] [PATCH v3 4/4] PCI/IOV: Move sysfs SR-IOV functions to iov.c skunberg.kelsey
2019-08-15 15:33 ` Kelsey Skunberg
2019-08-15 17:34 ` sathyanarayanan.kuppuswamy
2019-08-15 17:34 ` sathyanarayanan kuppuswamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190815153352.86143-4-skunberg.kelsey@gmail.com \
--to=skunberg.kelsey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).