linux-kernel-mentees.lists.linuxfoundation.org archive mirror
 help / color / mirror / Atom feed
From: Pragat Pandya <pragat.pandya@gmail.com>
To: gregkh@linuxfoundation.org, valdis.kletnieks@vt.edu
Cc: devel@driverdev.osuosl.org,
	Pragat Pandya <pragat.pandya@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org
Subject: [Linux-kernel-mentees] [PATCH 15/19] staging: exfat: Rename variable 'Attr' to 'attr'
Date: Wed, 29 Jan 2020 22:28:28 +0530	[thread overview]
Message-ID: <20200129165832.10574-16-pragat.pandya@gmail.com> (raw)
In-Reply-To: <20200129165832.10574-1-pragat.pandya@gmail.com>

Fix checkpatch warning: Avoid CamelCase.
Change all occurrences of identifier "Attr" to "attr"

Signed-off-by: Pragat Pandya <pragat.pandya@gmail.com>
---
 drivers/staging/exfat/exfat.h       |  2 +-
 drivers/staging/exfat/exfat_super.c | 24 ++++++++++++------------
 2 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/drivers/staging/exfat/exfat.h b/drivers/staging/exfat/exfat.h
index 099730e5b9f1..f1fa4d19a2e2 100644
--- a/drivers/staging/exfat/exfat.h
+++ b/drivers/staging/exfat/exfat.h
@@ -275,7 +275,7 @@ struct dir_entry_t {
 	/* used only for FAT12/16/32, not used for exFAT */
 	char short_name[DOS_NAME_LENGTH + 2];
 
-	u32 Attr;
+	u32 attr;
 	u64 Size;
 	u32 NumSubdirs;
 	struct date_time_t CreateTimestamp;
diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
index e155079722c8..73d116b8d769 100644
--- a/drivers/staging/exfat/exfat_super.c
+++ b/drivers/staging/exfat/exfat_super.c
@@ -1457,7 +1457,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
 	if (is_dir) {
 		if ((fid->dir.dir == p_fs->root_dir) &&
 		    (fid->entry == -1)) {
-			info->Attr = ATTR_SUBDIR;
+			info->attr = ATTR_SUBDIR;
 			memset((char *)&info->CreateTimestamp, 0,
 			       sizeof(struct date_time_t));
 			memset((char *)&info->ModifyTimestamp, 0,
@@ -1502,7 +1502,7 @@ static int ffsReadStat(struct inode *inode, struct dir_entry_t *info)
 	ep2 = ep + 1;
 
 	/* set FILE_INFO structure using the acquired struct dentry_t */
-	info->Attr = p_fs->fs_func->get_entry_attr(ep);
+	info->attr = p_fs->fs_func->get_entry_attr(ep);
 
 	p_fs->fs_func->get_entry_time(ep, &tm, TM_CREATE);
 	info->CreateTimestamp.year = tm.year;
@@ -1602,7 +1602,7 @@ static int ffsWriteStat(struct inode *inode, struct dir_entry_t *info)
 	}
 	ep2 = ep + 1;
 
-	p_fs->fs_func->set_entry_attr(ep, info->Attr);
+	p_fs->fs_func->set_entry_attr(ep, info->attr);
 
 	/* set FILE_INFO structure using the acquired struct dentry_t */
 	tm.sec  = info->CreateTimestamp.second;
@@ -1922,7 +1922,7 @@ static int ffsReadDir(struct inode *inode, struct dir_entry_t *dir_entry)
 				continue;
 
 			exfat_buf_lock(sb, sector);
-			dir_entry->Attr = fs_func->get_entry_attr(ep);
+			dir_entry->attr = fs_func->get_entry_attr(ep);
 
 			fs_func->get_entry_time(ep, &tm, TM_CREATE);
 			dir_entry->CreateTimestamp.year = tm.year;
@@ -2150,7 +2150,7 @@ static int exfat_readdir(struct file *filp, struct dir_context *ctx)
 	}
 
 	if (!dir_emit(ctx, de.name, strlen(de.name), inum,
-		      (de.Attr & ATTR_SUBDIR) ? DT_DIR : DT_REG))
+		      (de.attr & ATTR_SUBDIR) ? DT_DIR : DT_REG))
 		goto out;
 
 	ctx->pos = cpos;
@@ -3159,25 +3159,25 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
 	INC_IVERSION(inode);
 	inode->i_generation = prandom_u32();
 
-	if (info.Attr & ATTR_SUBDIR) { /* directory */
+	if (info.attr & ATTR_SUBDIR) { /* directory */
 		inode->i_generation &= ~1;
-		inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777);
+		inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
 		inode->i_op = &exfat_dir_inode_operations;
 		inode->i_fop = &exfat_dir_operations;
 
 		i_size_write(inode, info.Size);
 		EXFAT_I(inode)->mmu_private = i_size_read(inode);
 		set_nlink(inode, info.NumSubdirs);
-	} else if (info.Attr & ATTR_SYMLINK) { /* symbolic link */
+	} else if (info.attr & ATTR_SYMLINK) { /* symbolic link */
 		inode->i_generation |= 1;
-		inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777);
+		inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
 		inode->i_op = &exfat_symlink_inode_operations;
 
 		i_size_write(inode, info.Size);
 		EXFAT_I(inode)->mmu_private = i_size_read(inode);
 	} else { /* regular file */
 		inode->i_generation |= 1;
-		inode->i_mode = exfat_make_mode(sbi, info.Attr, 0777);
+		inode->i_mode = exfat_make_mode(sbi, info.attr, 0777);
 		inode->i_op = &exfat_file_inode_operations;
 		inode->i_fop = &exfat_file_operations;
 		inode->i_mapping->a_ops = &exfat_aops;
@@ -3186,7 +3186,7 @@ static int exfat_fill_inode(struct inode *inode, struct file_id_t *fid)
 		i_size_write(inode, info.Size);
 		EXFAT_I(inode)->mmu_private = i_size_read(inode);
 	}
-	exfat_save_attr(inode, info.Attr);
+	exfat_save_attr(inode, info.attr);
 
 	inode->i_blocks = ((i_size_read(inode) + (p_fs->cluster_size - 1))
 				& ~((loff_t)p_fs->cluster_size - 1)) >> 9;
@@ -3259,7 +3259,7 @@ static int exfat_write_inode(struct inode *inode, struct writeback_control *wbc)
 	if (inode->i_ino == EXFAT_ROOT_INO)
 		return 0;
 
-	info.Attr = exfat_make_attr(inode);
+	info.attr = exfat_make_attr(inode);
 	info.Size = i_size_read(inode);
 
 	exfat_time_unix2fat(&inode->i_mtime, &info.ModifyTimestamp);
-- 
2.17.1

_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  parent reply	other threads:[~2020-01-29 17:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-29 16:58 [Linux-kernel-mentees] [PATCH 00/19] Renaming some identifiers Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 01/19] staging: exfat: Rename variable 'Year' to 'year' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 02/19] staging: exfat: Rename variable 'Month' to 'month' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 03/19] staging: exfat: Rename variable 'Day' to 'day' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 04/19] staging: exfat: Rename variable 'Hour' to 'hour' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 05/19] staging: exfat: Rename variable 'Minute' to 'minute' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 06/19] staging: exfat: Rename variable 'Second' to 'second' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 07/19] staging: exfat: Rename variable 'MilliSecond' to 'millisecond' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 08/19] staging: exfat: Rename variable 'FatType' to 'fat_type' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 09/19] staging: exfat: Rename variable 'ClusterSize' to 'cluster_size' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 10/19] staging: exfat: Rename variable 'NumClusters' to 'num_cluster' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 11/19] staging: exfat: Rename variable 'FreeClusters' to 'free_clusters' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 12/19] staging: exfat: Rename variable 'UsedClusters' to 'used_clusters' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 13/19] staging: exfat: Rename variable 'Name' to 'name' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 14/19] staging: exfat: Rename variable 'ShortName' to 'short_name' Pragat Pandya
2020-01-29 16:58 ` Pragat Pandya [this message]
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 16/19] staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 17/19] staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 18/19] staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp' Pragat Pandya
2020-01-29 16:58 ` [Linux-kernel-mentees] [PATCH 19/19] staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp' Pragat Pandya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200129165832.10574-16-pragat.pandya@gmail.com \
    --to=pragat.pandya@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).