* [Linux-kernel-mentees] [PATCH v2 0/3] ethernet: amd: Convert to generic power management
@ 2020-06-22 11:11 Vaibhav Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Vaibhav Gupta @ 2020-06-22 11:11 UTC (permalink / raw)
To: Bjorn Helgaas, Bjorn Helgaas, bjorn, Vaibhav Gupta,
David S. Miller, Jakub Kicinski, Don Fry, Tom Lendacky
Cc: netdev, linux-kernel-mentees, linux-kernel, Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management.
The purpose of this patch series is to remove legacy power management callbacks
from amd ethernet drivers.
The callbacks performing suspend() and resume() operations are still calling
pci_save_state(), pci_set_power_state(), etc. and handling the power management
themselves, which is not recommended.
The conversion requires the removal of the those function calls and change the
callback definition accordingly and make use of dev_pm_ops structure.
All patches are compile-tested only.
Vaibhav Gupta (3):
pcnet32: Convert to generic power management
amd8111e: Convert to generic power management
amd-xgbe: Convert to generic power management
drivers/net/ethernet/amd/amd8111e.c | 30 +++++++++---------------
drivers/net/ethernet/amd/pcnet32.c | 22 ++++++++---------
drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 19 +++++++--------
3 files changed, 31 insertions(+), 40 deletions(-)
--
2.27.0
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH v2 0/3] ethernet: amd: Convert to generic power management
2020-06-24 3:31 ` David Miller
@ 2020-06-24 16:33 ` Vaibhav Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Vaibhav Gupta @ 2020-06-24 16:33 UTC (permalink / raw)
To: David Miller
Cc: thomas.lendacky, Vaibhav Gupta, netdev,
Linux Kernel Mailing List, pcnet32, Bjorn Helgaas, Bjorn Helgaas,
Jakub Kicinski, linux-kernel-mentees
On Wed, 24 Jun 2020 at 09:01, David Miller <davem@davemloft.net> wrote:
>
> From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> Date: Mon, 22 Jun 2020 16:43:57 +0530
>
> > Linux Kernel Mentee: Remove Legacy Power Management.
> >
> > The purpose of this patch series is to remove legacy power management callbacks
> > from amd ethernet drivers.
> >
> > The callbacks performing suspend() and resume() operations are still calling
> > pci_save_state(), pci_set_power_state(), etc. and handling the power management
> > themselves, which is not recommended.
> >
> > The conversion requires the removal of the those function calls and change the
> > callback definition accordingly and make use of dev_pm_ops structure.
> >
> > All patches are compile-tested only.
>
> Series applied
Thank You !
-- Vaibhav Gupta
> , thanks.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Linux-kernel-mentees] [PATCH v2 0/3] ethernet: amd: Convert to generic power management
2020-06-22 11:13 Vaibhav Gupta
@ 2020-06-24 3:31 ` David Miller
2020-06-24 16:33 ` Vaibhav Gupta
0 siblings, 1 reply; 4+ messages in thread
From: David Miller @ 2020-06-24 3:31 UTC (permalink / raw)
To: vaibhavgupta40
Cc: thomas.lendacky, linux-kernel, pcnet32, helgaas, netdev,
bhelgaas, kuba, linux-kernel-mentees
From: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Date: Mon, 22 Jun 2020 16:43:57 +0530
> Linux Kernel Mentee: Remove Legacy Power Management.
>
> The purpose of this patch series is to remove legacy power management callbacks
> from amd ethernet drivers.
>
> The callbacks performing suspend() and resume() operations are still calling
> pci_save_state(), pci_set_power_state(), etc. and handling the power management
> themselves, which is not recommended.
>
> The conversion requires the removal of the those function calls and change the
> callback definition accordingly and make use of dev_pm_ops structure.
>
> All patches are compile-tested only.
Series applied, thanks.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Linux-kernel-mentees] [PATCH v2 0/3] ethernet: amd: Convert to generic power management
@ 2020-06-22 11:13 Vaibhav Gupta
2020-06-24 3:31 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Vaibhav Gupta @ 2020-06-22 11:13 UTC (permalink / raw)
To: Bjorn Helgaas, Bjorn Helgaas, bjorn, Vaibhav Gupta,
David S. Miller, Jakub Kicinski, Don Fry, Tom Lendacky
Cc: netdev, linux-kernel-mentees, linux-kernel, Vaibhav Gupta
Linux Kernel Mentee: Remove Legacy Power Management.
The purpose of this patch series is to remove legacy power management callbacks
from amd ethernet drivers.
The callbacks performing suspend() and resume() operations are still calling
pci_save_state(), pci_set_power_state(), etc. and handling the power management
themselves, which is not recommended.
The conversion requires the removal of the those function calls and change the
callback definition accordingly and make use of dev_pm_ops structure.
All patches are compile-tested only.
Vaibhav Gupta (3):
pcnet32: Convert to generic power management
amd8111e: Convert to generic power management
amd-xgbe: Convert to generic power management
drivers/net/ethernet/amd/amd8111e.c | 30 +++++++++---------------
drivers/net/ethernet/amd/pcnet32.c | 22 ++++++++---------
drivers/net/ethernet/amd/xgbe/xgbe-pci.c | 19 +++++++--------
3 files changed, 31 insertions(+), 40 deletions(-)
--
2.27.0
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-24 16:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 11:11 [Linux-kernel-mentees] [PATCH v2 0/3] ethernet: amd: Convert to generic power management Vaibhav Gupta
2020-06-22 11:13 Vaibhav Gupta
2020-06-24 3:31 ` David Miller
2020-06-24 16:33 ` Vaibhav Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).