From: Johannes Berg <johannes@sipsolutions.net>
To: madhuparnabhowmik10@gmail.com, davem@davemloft.net, kuba@kernel.org
Cc: paulmck@kernel.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
joel@joelfernandes.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH 2/4] net: mac80211: scan.c: Fix RCU list related warnings.
Date: Fri, 24 Apr 2020 11:21:27 +0200 [thread overview]
Message-ID: <8d6fd8bfa0fb66f8ee4bfd34738a349bb1b7ee59.camel@sipsolutions.net> (raw)
In-Reply-To: <20200409082849.27372-1-madhuparnabhowmik10@gmail.com> (sfid-20200409_102909_206741_272D703E)
On Thu, 2020-04-09 at 13:58 +0530, madhuparnabhowmik10@gmail.com wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
>
> This patch fixes the following warning:
>
> WARNING: suspicious RCU usage
> [ 84.530619] 5.6.0+ #4 Not tainted
> [ 84.530637] -----------------------------
> [ 84.530658] net/mac80211/scan.c:454 RCU-list traversed in non-reader section!!
>
> As local->mtx is held in __ieee80211_scan_completed()
Yeah, but is that really the right lock? I think it should be RTNL or
iflist_mtx for the interface list.
(Not that this is necessarily a good idea - we perhaps should clean up
and significantly reduce the number of locks used here.)
johannes
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
prev parent reply other threads:[~2020-04-24 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 8:28 [Linux-kernel-mentees] [PATCH 2/4] net: mac80211: scan.c: Fix RCU list related warnings madhuparnabhowmik10
2020-04-24 9:21 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d6fd8bfa0fb66f8ee4bfd34738a349bb1b7ee59.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=joel@joelfernandes.org \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=madhuparnabhowmik10@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=paulmck@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).