From: hverkuil at xs4all.nl (Hans Verkuil) Subject: [Linux-kernel-mentees] [PATCH 1/2] v4l2-core: Add new metadata format Date: Thu, 3 Oct 2019 09:24:47 +0200 [thread overview] Message-ID: <9439560a-dbc7-9aeb-a27b-314ace85dc81@xs4all.nl> (raw) In-Reply-To: <20191003071856.23664-2-bnvandana@gmail.com> On 10/3/19 9:18 AM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN <bnvandana at gmail.com> > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 20b3107dd4e8..34c1a2bd7f28 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1340,6 +1340,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_VSP1_HGT: descr = "R-Car VSP1 2-D Histogram"; break; > case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break; > case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break; > + case V4L2_META_FMT_VIVID: descr = "Vivid Output Metadata"; break; Drop 'Output'. As mentioned in my previous reply, this format can be used for capture as well (and I think we should implement this). > > default: > /* Compressed formats */ > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 530638dffd93..a32335fcd064 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -755,6 +755,7 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_VSP1_HGT v4l2_fourcc('V', 'S', 'P', 'T') /* R-Car VSP1 2-D Histogram */ > #define V4L2_META_FMT_UVC v4l2_fourcc('U', 'V', 'C', 'H') /* UVC Payload Header metadata */ > #define V4L2_META_FMT_D4XX v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */ > +#define V4L2_META_FMT_VIVID v4l2_fourcc('V', 'I', 'V', 'D') /* Vivid Output Metadata */ Drop 'Output' in the comment. > > /* priv field value to indicates that subsequent fields are valid. */ > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > Regards, Hans
WARNING: multiple messages have this Message-ID (diff)
From: hverkuil@xs4all.nl (Hans Verkuil) Subject: [Linux-kernel-mentees] [PATCH 1/2] v4l2-core: Add new metadata format Date: Thu, 3 Oct 2019 09:24:47 +0200 [thread overview] Message-ID: <9439560a-dbc7-9aeb-a27b-314ace85dc81@xs4all.nl> (raw) Message-ID: <20191003072447.fw3Iokji6sbFW6xkV82J89kMeLKuVlMNpi_2HzS5acQ@z> (raw) In-Reply-To: <20191003071856.23664-2-bnvandana@gmail.com> On 10/3/19 9:18 AM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN <bnvandana at gmail.com> > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-ioctl.c > index 20b3107dd4e8..34c1a2bd7f28 100644 > --- a/drivers/media/v4l2-core/v4l2-ioctl.c > +++ b/drivers/media/v4l2-core/v4l2-ioctl.c > @@ -1340,6 +1340,7 @@ static void v4l_fill_fmtdesc(struct v4l2_fmtdesc *fmt) > case V4L2_META_FMT_VSP1_HGT: descr = "R-Car VSP1 2-D Histogram"; break; > case V4L2_META_FMT_UVC: descr = "UVC Payload Header Metadata"; break; > case V4L2_META_FMT_D4XX: descr = "Intel D4xx UVC Metadata"; break; > + case V4L2_META_FMT_VIVID: descr = "Vivid Output Metadata"; break; Drop 'Output'. As mentioned in my previous reply, this format can be used for capture as well (and I think we should implement this). > > default: > /* Compressed formats */ > diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h > index 530638dffd93..a32335fcd064 100644 > --- a/include/uapi/linux/videodev2.h > +++ b/include/uapi/linux/videodev2.h > @@ -755,6 +755,7 @@ struct v4l2_pix_format { > #define V4L2_META_FMT_VSP1_HGT v4l2_fourcc('V', 'S', 'P', 'T') /* R-Car VSP1 2-D Histogram */ > #define V4L2_META_FMT_UVC v4l2_fourcc('U', 'V', 'C', 'H') /* UVC Payload Header metadata */ > #define V4L2_META_FMT_D4XX v4l2_fourcc('D', '4', 'X', 'X') /* D4XX Payload Header metadata */ > +#define V4L2_META_FMT_VIVID v4l2_fourcc('V', 'I', 'V', 'D') /* Vivid Output Metadata */ Drop 'Output' in the comment. > > /* priv field value to indicates that subsequent fields are valid. */ > #define V4L2_PIX_FMT_PRIV_MAGIC 0xfeedcafe > Regards, Hans
next prev parent reply other threads:[~2019-10-03 7:24 UTC|newest] Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-03 7:18 [Linux-kernel-mentees] [PATCH 0/2] vivid: Metadata output support bnvandana 2019-10-03 7:18 ` Vandana BN 2019-10-03 7:18 ` [Linux-kernel-mentees] [PATCH 1/2] v4l2-core: Add new metadata format bnvandana 2019-10-03 7:18 ` Vandana BN 2019-10-03 7:23 ` hverkuil 2019-10-03 7:23 ` Hans Verkuil 2019-10-03 7:24 ` hverkuil [this message] 2019-10-03 7:24 ` Hans Verkuil 2019-10-03 11:08 ` [Linux-kernel-mentees] [PATCH v2 0/2] vivid: Metadata output support bnvandana 2019-10-03 11:08 ` Vandana BN 2019-10-03 11:08 ` [Linux-kernel-mentees] [PATCH v2 1/2] v4l2-core: Add new metadata format bnvandana 2019-10-03 11:08 ` Vandana BN 2019-10-03 12:58 ` hverkuil 2019-10-03 12:58 ` Hans Verkuil 2019-10-03 16:22 ` skhan 2019-10-03 16:22 ` Shuah Khan 2019-10-03 11:08 ` [Linux-kernel-mentees] [PATCH v2 2/2] vivid: Add metadata output support bnvandana 2019-10-03 11:08 ` Vandana BN 2019-10-03 13:06 ` hverkuil 2019-10-03 13:06 ` Hans Verkuil 2019-10-03 17:38 ` skhan 2019-10-03 17:38 ` Shuah Khan 2019-10-04 9:55 ` hverkuil 2019-10-04 9:55 ` Hans Verkuil 2019-10-04 12:08 ` [Linux-kernel-mentees] [PATCH v3 0/2] vivid: Metadata " bnvandana 2019-10-04 12:08 ` Vandana BN 2019-10-04 12:08 ` [Linux-kernel-mentees] [PATCH v3 1/2] v4l2-core: Add new metadata format bnvandana 2019-10-04 12:08 ` Vandana BN 2019-10-04 12:08 ` [Linux-kernel-mentees] [PATCH v3 2/2] vivid: Add metadata output support bnvandana 2019-10-04 12:08 ` Vandana BN 2019-10-07 14:26 ` hverkuil 2019-10-07 14:26 ` Hans Verkuil 2019-10-03 7:18 ` [Linux-kernel-mentees] [PATCH " bnvandana 2019-10-03 7:18 ` Vandana BN
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=9439560a-dbc7-9aeb-a27b-314ace85dc81@xs4all.nl \ --to=linux-kernel-mentees@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).