* [RFC PATCH 0/1] Fix KASAN: slab-out-of-bounds Read in sk_psock_get
@ 2022-07-13 6:32 Khalid Masum
2022-07-13 6:32 ` [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache Khalid Masum
0 siblings, 1 reply; 6+ messages in thread
From: Khalid Masum @ 2022-07-13 6:32 UTC (permalink / raw)
To: linux-kernel-mentees, linux-usb, linux-kernel, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Florian Fainelli, Pavel Skripkin, Alexei Starovoitov,
syzbot+1fa91bcd05206ff8cbb5, Marc Kleine-Budde,
Nikolay Aleksandrov, Stefano Garzarella
Using size of sk_psock as the size for kcm_psock_cache size no longer
reproduces the issue. There might be a better way to solve this issue
though so I would like to ask for feedback.
Reported-and-tested-by: syzbot+1fa91bcd05206ff8cbb5@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=1fa91bcd05206ff8cbb5
Khalid Masum (1):
net: kcm: Use sk_psock size for kcm_psock_cache
net/kcm/kcmsock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.36.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache
2022-07-13 6:32 [RFC PATCH 0/1] Fix KASAN: slab-out-of-bounds Read in sk_psock_get Khalid Masum
@ 2022-07-13 6:32 ` Khalid Masum
2022-07-13 6:37 ` Greg KH
2022-07-13 18:16 ` Jakub Kicinski
0 siblings, 2 replies; 6+ messages in thread
From: Khalid Masum @ 2022-07-13 6:32 UTC (permalink / raw)
To: linux-kernel-mentees, linux-usb, linux-kernel, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: Florian Fainelli, Pavel Skripkin, Alexei Starovoitov,
syzbot+1fa91bcd05206ff8cbb5, Marc Kleine-Budde,
Nikolay Aleksandrov, Stefano Garzarella
`struct sock` has a member `sk_user_data`, which got its memory allocated
in `kcm_attach` by `kcm_psock_cache` with the size of `kcm_psock`. Which
is not enough when the member is used as `sk_psock` causing out of bound
read.
Use `sk_psock` size to allocate memory instead for `sk_user_data`.
Reported-by: syzbot+1fa91bcd05206ff8cbb5@syzkaller.appspotmail.com
Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
---
net/kcm/kcmsock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
index 71899e5a5a11..688bee56f90c 100644
--- a/net/kcm/kcmsock.c
+++ b/net/kcm/kcmsock.c
@@ -23,6 +23,7 @@
#include <linux/workqueue.h>
#include <linux/syscalls.h>
#include <linux/sched/signal.h>
+#include <linux/skmsg.h>
#include <net/kcm.h>
#include <net/netns/generic.h>
@@ -2041,7 +2042,7 @@ static int __init kcm_init(void)
goto fail;
kcm_psockp = kmem_cache_create("kcm_psock_cache",
- sizeof(struct kcm_psock), 0,
+ sizeof(struct sk_psock), 0,
SLAB_HWCACHE_ALIGN, NULL);
if (!kcm_psockp)
goto fail;
--
2.36.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache
2022-07-13 6:32 ` [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache Khalid Masum
@ 2022-07-13 6:37 ` Greg KH
2022-07-13 18:16 ` Jakub Kicinski
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2022-07-13 6:37 UTC (permalink / raw)
To: Khalid Masum
Cc: Florian Fainelli, Pavel Skripkin, linux-usb, linux-kernel,
Alexei Starovoitov, Eric Dumazet, Marc Kleine-Budde,
Nikolay Aleksandrov, Jakub Kicinski, syzbot+1fa91bcd05206ff8cbb5,
Paolo Abeni, linux-kernel-mentees, David S . Miller,
Stefano Garzarella
On Wed, Jul 13, 2022 at 12:32:04PM +0600, Khalid Masum wrote:
> `struct sock` has a member `sk_user_data`, which got its memory allocated
> in `kcm_attach` by `kcm_psock_cache` with the size of `kcm_psock`. Which
> is not enough when the member is used as `sk_psock` causing out of bound
> read.
>
> Use `sk_psock` size to allocate memory instead for `sk_user_data`.
>
> Reported-by: syzbot+1fa91bcd05206ff8cbb5@syzkaller.appspotmail.com
> Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
> ---
> net/kcm/kcmsock.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
What commit id does this fix?
thanks,
greg k-h
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache
2022-07-13 6:32 ` [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache Khalid Masum
2022-07-13 6:37 ` Greg KH
@ 2022-07-13 18:16 ` Jakub Kicinski
2022-07-13 18:25 ` Khalid Masum
1 sibling, 1 reply; 6+ messages in thread
From: Jakub Kicinski @ 2022-07-13 18:16 UTC (permalink / raw)
To: Khalid Masum
Cc: Florian Fainelli, Pavel Skripkin, linux-usb, linux-kernel,
Alexei Starovoitov, Eric Dumazet, Marc Kleine-Budde,
Nikolay Aleksandrov, syzbot+1fa91bcd05206ff8cbb5, Paolo Abeni,
linux-kernel-mentees, David S . Miller, Stefano Garzarella
On Wed, 13 Jul 2022 12:32:04 +0600 Khalid Masum wrote:
> `struct sock` has a member `sk_user_data`, which got its memory allocated
> in `kcm_attach` by `kcm_psock_cache` with the size of `kcm_psock`. Which
> is not enough when the member is used as `sk_psock` causing out of bound
> read.
>
> Use `sk_psock` size to allocate memory instead for `sk_user_data`.
>
> Reported-by: syzbot+1fa91bcd05206ff8cbb5@syzkaller.appspotmail.com
> Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
Odd CC list, it looks like a netdev problem but netdev@ is not copied.
We had an other parson looking at this on netdev. Is this happening
when legit kernel socket gets mixed with BPF sockmap?
Does this fix work?
https://lore.kernel.org/netdev/165030056960.5073.6664402939918720250.stgit@oracle-102.nfsv4.dev/
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache
2022-07-13 18:16 ` Jakub Kicinski
@ 2022-07-13 18:25 ` Khalid Masum
0 siblings, 0 replies; 6+ messages in thread
From: Khalid Masum @ 2022-07-13 18:25 UTC (permalink / raw)
To: Jakub Kicinski
Cc: Florian Fainelli, Pavel Skripkin, linux-usb, linux-kernel,
Alexei Starovoitov, Eric Dumazet, Marc Kleine-Budde,
Nikolay Aleksandrov, syzbot+1fa91bcd05206ff8cbb5, Paolo Abeni,
linux-kernel-mentees, David S . Miller, Stefano Garzarella
On Thu, Jul 14, 2022 at 12:16 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 13 Jul 2022 12:32:04 +0600 Khalid Masum wrote:
> > `struct sock` has a member `sk_user_data`, which got its memory allocated
> > in `kcm_attach` by `kcm_psock_cache` with the size of `kcm_psock`. Which
> > is not enough when the member is used as `sk_psock` causing out of bound
> > read.
> >
> > Use `sk_psock` size to allocate memory instead for `sk_user_data`.
> >
> > Reported-by: syzbot+1fa91bcd05206ff8cbb5@syzkaller.appspotmail.com
> > Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
>
> Odd CC list, it looks like a netdev problem but netdev@ is not copied.
I am sorry for the inconvenience. I resent the patch with netdev in CC here:
https://lore.kernel.org/netdev/20220713181324.14228-2-khalid.masum.92@gmail.com/
> We had an other parson looking at this on netdev. Is this happening
> when legit kernel socket gets mixed with BPF sockmap?
>
> Does this fix work?
I will take a look at it.
> https://lore.kernel.org/netdev/165030056960.5073.6664402939918720250.stgit@oracle-102.nfsv4.dev/
Thanks,
Khalid Masum
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache
2022-07-13 18:13 [RFC PATCH 0/1][RESEND] Fix KASAN: slab-out-of-bounds Read in sk_psock_get Khalid Masum
@ 2022-07-13 18:13 ` Khalid Masum
0 siblings, 0 replies; 6+ messages in thread
From: Khalid Masum @ 2022-07-13 18:13 UTC (permalink / raw)
To: linux-kernel-mentees, linux-kernel, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, netdev
Cc: Florian Fainelli, Pavel Skripkin, Alexei Starovoitov,
syzbot+1fa91bcd05206ff8cbb5, Marc Kleine-Budde,
Nikolay Aleksandrov, Stefano Garzarella
`struct sock` has a member `sk_user_data`, which got its memory allocated
in `kcm_attach` by `kcm_psock_cache` with the size of `kcm_psock`. Which
is not enough when the member is used as `sk_psock` causing out of bound
read.
Use `sk_psock` size to allocate memory instead for `sk_user_data`.
Reported-by: syzbot+1fa91bcd05206ff8cbb5@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?extid=1fa91bcd05206ff8cbb5
Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
---
net/kcm/kcmsock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/kcm/kcmsock.c b/net/kcm/kcmsock.c
index 71899e5a5a11..688bee56f90c 100644
--- a/net/kcm/kcmsock.c
+++ b/net/kcm/kcmsock.c
@@ -23,6 +23,7 @@
#include <linux/workqueue.h>
#include <linux/syscalls.h>
#include <linux/sched/signal.h>
+#include <linux/skmsg.h>
#include <net/kcm.h>
#include <net/netns/generic.h>
@@ -2041,7 +2042,7 @@ static int __init kcm_init(void)
goto fail;
kcm_psockp = kmem_cache_create("kcm_psock_cache",
- sizeof(struct kcm_psock), 0,
+ sizeof(struct sk_psock), 0,
SLAB_HWCACHE_ALIGN, NULL);
if (!kcm_psockp)
goto fail;
--
2.36.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-13 18:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-13 6:32 [RFC PATCH 0/1] Fix KASAN: slab-out-of-bounds Read in sk_psock_get Khalid Masum
2022-07-13 6:32 ` [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache Khalid Masum
2022-07-13 6:37 ` Greg KH
2022-07-13 18:16 ` Jakub Kicinski
2022-07-13 18:25 ` Khalid Masum
2022-07-13 18:13 [RFC PATCH 0/1][RESEND] Fix KASAN: slab-out-of-bounds Read in sk_psock_get Khalid Masum
2022-07-13 18:13 ` [RFC PATCH 1/1] net: kcm: Use sk_psock size for kcm_psock_cache Khalid Masum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).