Re: Regarding LFX Mentorship Project

Re: Regarding LFX Mentorship Project

[Dwaipayan Ray]

On Sat, Jul 17, 2021 at 1:09 PM Ashutosh Sharma
<b18010@students.iitmandi.ac.in> wrote:
>
> Hello Dwaipayan,
> I am writing this email to you regarding the Linux Kernel: Checkpatch Documentation project. I am interested in the Checkpatch Documentation mentorship program and I would like to work on the tasks for the mentee selection.
> I have been a SDE intern at Amazon where I have worked on AWS, React and Java, Other than that I have also worked as a student developer in GSoC 2020 under The Mifos Initiative organisation. Currently, I am looking for opportunities to learn and grow my skill set. I am really excited about the project.
> Hoping for a positive response.
> Thank you
> Ashutosh Sharma

Dear Ashutosh,
Thanks for your interest in working with the checkpatch documentation.

The zeroth task is to learn suitable netiquette for the communication with
the kernel community. Below are some basic rules and pointers for this
mentorship. More information on kernel netiquette is also at
https://people.kernel.org/tglx/notes-about-netiquette.

First, please do not top-post.

    A: Because we read from top to bottom, left to right.
    Q: Why should I start my reply below the quoted text?

    A: Because it messes up the order in which people normally read text.
    Q: Why is top-posting such a bad thing?

    A: The lost context.
    Q: What makes top-posted replies harder to read than bottom-posted?

    A: Yes.
    Q: Should I trim down the quoted part of an email to which I'm replying?

Second, please always CC: linux-kernel-mentees@lists.linuxfoundation.org.

Third, set up your email client according to the kernel community
rules. Here is some information to that:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
https://www.kernel.org/doc/html/latest/process/email-clients.html

Generally more information on submitting patches and responding on
replies is at https://www.kernel.org/doc/html/latest/process/submitting-patches.html

Once the zeroth task is understood, you can now move on to the first
task: Running checkpatch on a specific file.

Get a clone of the Linux kernel repository.
The script checkpatch.pl is under the scripts directory.

Then, the first task is to run checkpatch.pl on a few files below
andshare the results:

drivers/scsi/bfa/bfad_bsg.c
drivers/soc/fsl/dpio/dpio-service.c

Which information on these rules that checkpatch warns about
is available in the Checkpatch Documentation?

If documentation of these rules is available, explain your
understanding of the rules in your own words.
If no information is available in the documentation,
explain your understanding of the rule.

In any case, explain the violation that is checked and raised in the
checkpatch script, i.e., what is implemented in checkpatch to check
the rule and possible violations. Which code in the checkpatch script
is raising the warning? What does it check and how is that
implemented?

Explain how to possibly fix this code with regards to that violation.

Once you succeed on this first task, we inform you about the further
second and third task. If you fail on any of those tasks, you are out
of the selection process.

The selection of the mentee will happen according to schedule,
at earliest on August 12th and at latest at the end of August.
More information is available at
https://docs.linuxfoundation.org/lfx/mentorship/mentorship-program-timelines.

Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: Regarding LFX Mentorship Project

[Lukas Bulwahn]

On Sat, Jul 17, 2021 at 6:02 PM Ashutosh Sharma
<b18010@students.iitmandi.ac.in> wrote:
>
> Hello,
> I am enclosing my submission for assignment 1. For this assignment I went through the checkpatch documentation which I found on https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html and then I looked at the implementation of checkpatch and tried to understand what is happening by the comments.
> Thanks
> Ashutosh

Ashutosh, you unfortunately failed on step 0 to learn suitable
netiquette for the communication with the kernel community. Sorry, we
will not answer your email and not continue to exchange with you until
the suitable netiquette for the communication with the kernel
community is followed. Please go back to step 0, consider the rules
for communication with the kernel, check what you did wrong and
improve all those issues and try sending your email properly again.

Our mentorship program is an offer to learn; so read the available
documentation on communication with the kernel community, and give it
another try. When you learn now at the beginning, your continued
journey in the kernel community will be much more successful later on.

Good luck.

Lukas

>
> On Sat, Jul 17, 2021 at 1:29 PM Dwaipayan Ray <dwaipayanray1@gmail.com> wrote:
>>
>> On Sat, Jul 17, 2021 at 1:09 PM Ashutosh Sharma
>> <b18010@students.iitmandi.ac.in> wrote:
>> >
>> > Hello Dwaipayan,
>> > I am writing this email to you regarding the Linux Kernel: Checkpatch Documentation project. I am interested in the Checkpatch Documentation mentorship program and I would like to work on the tasks for the mentee selection.
>> > I have been a SDE intern at Amazon where I have worked on AWS, React and Java, Other than that I have also worked as a student developer in GSoC 2020 under The Mifos Initiative organisation. Currently, I am looking for opportunities to learn and grow my skill set. I am really excited about the project.
>> > Hoping for a positive response.
>> > Thank you
>> > Ashutosh Sharma
>>
>> Dear Ashutosh,
>> Thanks for your interest in working with the checkpatch documentation.
>>
>> The zeroth task is to learn suitable netiquette for the communication with
>> the kernel community. Below are some basic rules and pointers for this
>> mentorship. More information on kernel netiquette is also at
>> https://people.kernel.org/tglx/notes-about-netiquette.
>>
>> First, please do not top-post.
>>
>>     A: Because we read from top to bottom, left to right.
>>     Q: Why should I start my reply below the quoted text?
>>
>>     A: Because it messes up the order in which people normally read text.
>>     Q: Why is top-posting such a bad thing?
>>
>>     A: The lost context.
>>     Q: What makes top-posted replies harder to read than bottom-posted?
>>
>>     A: Yes.
>>     Q: Should I trim down the quoted part of an email to which I'm replying?
>>
>> Second, please always CC: linux-kernel-mentees@lists.linuxfoundation.org.
>>
>> Third, set up your email client according to the kernel community
>> rules. Here is some information to that:
>>
>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#no-mime-no-links-no-compression-no-attachments-just-plain-text
>> https://www.kernel.org/doc/html/latest/process/email-clients.html
>>
>> Generally more information on submitting patches and responding on
>> replies is at https://www.kernel.org/doc/html/latest/process/submitting-patches.html
>>
>> Once the zeroth task is understood, you can now move on to the first
>> task: Running checkpatch on a specific file.
>>
>> Get a clone of the Linux kernel repository.
>> The script checkpatch.pl is under the scripts directory.
>>
>> Then, the first task is to run checkpatch.pl on a few files below
>> andshare the results:
>>
>> drivers/scsi/bfa/bfad_bsg.c
>> drivers/soc/fsl/dpio/dpio-service.c
>>
>> Which information on these rules that checkpatch warns about
>> is available in the Checkpatch Documentation?
>>
>> If documentation of these rules is available, explain your
>> understanding of the rules in your own words.
>> If no information is available in the documentation,
>> explain your understanding of the rule.
>>
>> In any case, explain the violation that is checked and raised in the
>> checkpatch script, i.e., what is implemented in checkpatch to check
>> the rule and possible violations. Which code in the checkpatch script
>> is raising the warning? What does it check and how is that
>> implemented?
>>
>> Explain how to possibly fix this code with regards to that violation.
>>
>> Once you succeed on this first task, we inform you about the further
>> second and third task. If you fail on any of those tasks, you are out
>> of the selection process.
>>
>> The selection of the mentee will happen according to schedule,
>> at earliest on August 12th and at latest at the end of August.
>> More information is available at
>> https://docs.linuxfoundation.org/lfx/mentorship/mentorship-program-timelines.
>>
>> Dwaipayan.
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

Re: Regarding LFX Mentorship Project

[Dwaipayan Ray]

On Sat, Jul 17, 2021 at 9:46 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> On Sat, Jul 17, 2021 at 6:02 PM Ashutosh Sharma
> <b18010@students.iitmandi.ac.in> wrote:
> >
> > Hello,
> > I am enclosing my submission for assignment 1. For this assignment I went through the checkpatch documentation which I found on https://www.kernel.org/doc/html/latest/dev-tools/checkpatch.html and then I looked at the implementation of checkpatch and tried to understand what is happening by the comments.
> > Thanks
> > Ashutosh
>
> Ashutosh, you unfortunately failed on step 0 to learn suitable
> netiquette for the communication with the kernel community. Sorry, we
> will not answer your email and not continue to exchange with you until
> the suitable netiquette for the communication with the kernel
> community is followed. Please go back to step 0, consider the rules
> for communication with the kernel, check what you did wrong and
> improve all those issues and try sending your email properly again.
>

Same as what Lukas said. Please read the zeroth task and then attempt
again at the first task.

Also to add, your submission is wrong. See ./scripts/checkpatch.pl --help
to understand why.

Hint is in your output:
ERROR: Does not appear to be a unified-diff format patch

Thanks,
Dwaipayan.

> Our mentorship program is an offer to learn; so read the available
> documentation on communication with the kernel community, and give it
> another try. When you learn now at the beginning, your continued
> journey in the kernel community will be much more successful later on.
>
> Good luck.
>
> Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees