* [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command
@ 2022-07-21 9:30 Khalid Masum
2022-07-21 16:24 ` Doug Anderson
0 siblings, 1 reply; 4+ messages in thread
From: Khalid Masum @ 2022-07-21 9:30 UTC (permalink / raw)
To: linux-kernel-mentees, linux-kernel
Cc: Pavel Skripkin, Douglas Anderson, Stephen Boyd, Jan Kiszka,
Kieran Bingham, Andrew Morton
Currently the command 'lx-symbols' in gdb exits with the error`Function
"do_init_module" not defined in "kernel/module.c"`. This occurs because
the file kernel/module.c was moved to kernel/module/main.c.
Fix this breakage by changing the path to "kernel/module/main.c" in
LoadModuleBreakpoint.
Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
---
scripts/gdb/linux/symbols.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
index 46f7542db08c..dc07b6d12e30 100644
--- a/scripts/gdb/linux/symbols.py
+++ b/scripts/gdb/linux/symbols.py
@@ -180,7 +180,7 @@ lx-symbols command."""
self.breakpoint.delete()
self.breakpoint = None
self.breakpoint = LoadModuleBreakpoint(
- "kernel/module.c:do_init_module", self)
+ "kernel/module/main.c:do_init_module", self)
else:
gdb.write("Note: symbol update on module loading not supported "
"with this gdb version\n")
--
2.36.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command
2022-07-21 9:30 [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command Khalid Masum
@ 2022-07-21 16:24 ` Doug Anderson
2022-07-21 16:33 ` Luis Chamberlain
0 siblings, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2022-07-21 16:24 UTC (permalink / raw)
To: Khalid Masum
Cc: Aaron Tomlin, Pavel Skripkin, LKML, Stephen Boyd,
Luis Chamberlain, Jan Kiszka, Kieran Bingham, kgdb-bugreport,
Andrew Morton, linux-kernel-mentees
Hi,
On Thu, Jul 21, 2022 at 2:31 AM Khalid Masum <khalid.masum.92@gmail.com> wrote:
>
> Currently the command 'lx-symbols' in gdb exits with the error`Function
> "do_init_module" not defined in "kernel/module.c"`. This occurs because
> the file kernel/module.c was moved to kernel/module/main.c.
>
> Fix this breakage by changing the path to "kernel/module/main.c" in
> LoadModuleBreakpoint.
>
> Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
> ---
> scripts/gdb/linux/symbols.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index 46f7542db08c..dc07b6d12e30 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -180,7 +180,7 @@ lx-symbols command."""
> self.breakpoint.delete()
> self.breakpoint = None
> self.breakpoint = LoadModuleBreakpoint(
> - "kernel/module.c:do_init_module", self)
> + "kernel/module/main.c:do_init_module", self)
Fixes: cfc1d277891e ("module: Move all into module/")
Reviewed-by: Douglas Anderson <dianders@chromium.org>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command
2022-07-21 16:24 ` Doug Anderson
@ 2022-07-21 16:33 ` Luis Chamberlain
2022-07-21 17:41 ` Linus Torvalds
0 siblings, 1 reply; 4+ messages in thread
From: Luis Chamberlain @ 2022-07-21 16:33 UTC (permalink / raw)
To: Doug Anderson, Linus Torvalds
Cc: Pavel Skripkin, Aaron Tomlin, Kieran Bingham, LKML, Stephen Boyd,
Jan Kiszka, kgdb-bugreport, Andrew Morton, linux-kernel-mentees
On Thu, Jul 21, 2022 at 09:24:31AM -0700, Doug Anderson wrote:
> Hi,
>
> On Thu, Jul 21, 2022 at 2:31 AM Khalid Masum <khalid.masum.92@gmail.com> wrote:
> >
> > Currently the command 'lx-symbols' in gdb exits with the error`Function
> > "do_init_module" not defined in "kernel/module.c"`. This occurs because
> > the file kernel/module.c was moved to kernel/module/main.c.
> >
> > Fix this breakage by changing the path to "kernel/module/main.c" in
> > LoadModuleBreakpoint.
> >
> > Signed-off-by: Khalid Masum <khalid.masum.92@gmail.com>
> > ---
> > scripts/gdb/linux/symbols.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> > index 46f7542db08c..dc07b6d12e30 100644
> > --- a/scripts/gdb/linux/symbols.py
> > +++ b/scripts/gdb/linux/symbols.py
> > @@ -180,7 +180,7 @@ lx-symbols command."""
> > self.breakpoint.delete()
> > self.breakpoint = None
> > self.breakpoint = LoadModuleBreakpoint(
> > - "kernel/module.c:do_init_module", self)
> > + "kernel/module/main.c:do_init_module", self)
>
> Fixes: cfc1d277891e ("module: Move all into module/")
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
This should go to Linus prior to the next rc. Linus, I think this is
with picking up now as I smell a final release soon.
FWIW a git grep of "kernel/module\.c" reveals no other code users of
this path.
Luis
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command
2022-07-21 16:33 ` Luis Chamberlain
@ 2022-07-21 17:41 ` Linus Torvalds
0 siblings, 0 replies; 4+ messages in thread
From: Linus Torvalds @ 2022-07-21 17:41 UTC (permalink / raw)
To: Luis Chamberlain
Cc: Pavel Skripkin, Aaron Tomlin, Kieran Bingham, LKML,
Doug Anderson, Jan Kiszka, kgdb-bugreport, Andrew Morton,
Stephen Boyd, linux-kernel-mentees
On Thu, Jul 21, 2022 at 9:33 AM Luis Chamberlain <mcgrof@kernel.org> wrote:
>
>
> This should go to Linus prior to the next rc. Linus, I think this is
> worth picking up now as I smell a final release soon.
Applied. Thanks,
Linus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-21 17:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-21 9:30 [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command Khalid Masum
2022-07-21 16:24 ` Doug Anderson
2022-07-21 16:33 ` Luis Chamberlain
2022-07-21 17:41 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).