* [Linux-kernel-mentees] [fixup] kunit: use --build_dir=.kunit as default
@ 2020-05-26 18:34 Vitor Massaru Iha
2020-05-26 22:29 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Vitor Massaru Iha @ 2020-05-26 18:34 UTC (permalink / raw)
To: kunit-dev, skhan
Cc: linux-kernel-mentees, brendanhiggins, linux-kernel, linux-kselftest
To make KUnit easier to use, and to avoid overwriting object and
.config files, the default KUnit build directory is set to .kunit
* Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205221
Fixed up minor merge conflicts - Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
version after merge on kunit brach:
* fix identation (tabs instead of spaces)
---
tools/testing/kunit/kunit.py | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
index b01838b6f5f9..b3490271a103 100755
--- a/tools/testing/kunit/kunit.py
+++ b/tools/testing/kunit/kunit.py
@@ -169,7 +169,7 @@ def add_common_opts(parser):
parser.add_argument('--build_dir',
help='As in the make command, it specifies the build '
'directory.',
- type=str, default='', metavar='build_dir')
+ type=str, default='.kunit', metavar='build_dir')
parser.add_argument('--make_options',
help='X=Y make option, can be repeated.',
action='append')
@@ -245,12 +245,11 @@ def main(argv, linux=None):
cli_args = parser.parse_args(argv)
if cli_args.subcommand == 'run':
- if cli_args.build_dir:
- if not os.path.exists(cli_args.build_dir):
- os.mkdir(cli_args.build_dir)
- kunit_kernel.kunitconfig_path = os.path.join(
- cli_args.build_dir,
- kunit_kernel.kunitconfig_path)
+ if not os.path.exists(cli_args.build_dir):
+ os.mkdir(cli_args.build_dir)
+ kunit_kernel.kunitconfig_path = os.path.join(
+ cli_args.build_dir,
+ kunit_kernel.kunitconfig_path)
if not linux:
linux = kunit_kernel.LinuxSourceTree()
--
2.26.2
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Linux-kernel-mentees] [fixup] kunit: use --build_dir=.kunit as default
2020-05-26 18:34 [Linux-kernel-mentees] [fixup] kunit: use --build_dir=.kunit as default Vitor Massaru Iha
@ 2020-05-26 22:29 ` Shuah Khan
2020-05-26 23:41 ` Vitor Massaru Iha
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2020-05-26 22:29 UTC (permalink / raw)
To: Vitor Massaru Iha, kunit-dev
Cc: linux-kernel-mentees, brendanhiggins, linux-kernel, linux-kselftest
On 5/26/20 12:34 PM, Vitor Massaru Iha wrote:
> To make KUnit easier to use, and to avoid overwriting object and
> .config files, the default KUnit build directory is set to .kunit
>
> * Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205221
>
> Fixed up minor merge conflicts - Shuah Khan <skhan@linuxfoundation.org>
>
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> ---
> version after merge on kunit brach:
> * fix identation (tabs instead of spaces)
You mentioned spaces breaking python. Please include the python
errors and make it clear in the change log what is fixes.
thanks,
-- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Linux-kernel-mentees] [fixup] kunit: use --build_dir=.kunit as default
2020-05-26 22:29 ` Shuah Khan
@ 2020-05-26 23:41 ` Vitor Massaru Iha
0 siblings, 0 replies; 3+ messages in thread
From: Vitor Massaru Iha @ 2020-05-26 23:41 UTC (permalink / raw)
To: Shuah Khan, kunit-dev
Cc: linux-kernel-mentees, brendanhiggins, linux-kernel, linux-kselftest
On Tue, 2020-05-26 at 16:29 -0600, Shuah Khan wrote:
> On 5/26/20 12:34 PM, Vitor Massaru Iha wrote:
> > To make KUnit easier to use, and to avoid overwriting object and
> > .config files, the default KUnit build directory is set to .kunit
> >
> > * Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205221
> >
> > Fixed up minor merge conflicts - Shuah Khan <
> > skhan@linuxfoundation.org>
> >
> > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> > Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> > Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> > ---
> > version after merge on kunit brach:
> > * fix identation (tabs instead of spaces)
>
> You mentioned spaces breaking python. Please include the python
> errors and make it clear in the change log what is fixes.
Of course, I will add this.
>
> thanks,
> -- Shuah
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-26 23:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-26 18:34 [Linux-kernel-mentees] [fixup] kunit: use --build_dir=.kunit as default Vitor Massaru Iha
2020-05-26 22:29 ` Shuah Khan
2020-05-26 23:41 ` Vitor Massaru Iha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).