* Re: [Linux-kernel-mentees] [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs
@ 2020-01-21 9:56 Markus Elfring
2020-01-21 10:43 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-01-21 9:56 UTC (permalink / raw)
To: Jaskaran Singh, cocci; +Cc: linux-kernel-mentees
> If <typedef> is a known typedef (such as u8 or *_t) then label <macro>
> as a CppMacro. Subsequent cases will label <typedef> correctly as a
> typedef ident.
>
> Also add bool to the list of known typedefs so that cases of
Can a wording like the following be nicer for such a change description?
Label <macro> as a CppMacro if <typedef> is a known type definition
(such as u8 or *_t).
Subsequent cases will label <typedef> correctly as a type definition identifier.
Add bool also to the list of known type definition identifiers so that cases of
Regards,
Markus
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Linux-kernel-mentees] [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs
2020-01-21 9:56 [Linux-kernel-mentees] [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs Markus Elfring
@ 2020-01-21 10:43 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2020-01-21 10:43 UTC (permalink / raw)
To: Markus Elfring; +Cc: Jaskaran Singh, linux-kernel-mentees, cocci
On Tue, 21 Jan 2020, Markus Elfring wrote:
> > If <typedef> is a known typedef (such as u8 or *_t) then label <macro>
> > as a CppMacro. Subsequent cases will label <typedef> correctly as a
> > typedef ident.
> >
> > Also add bool to the list of known typedefs so that cases of
>
> Can a wording like the following be nicer for such a change description?
>
> Label <macro> as a CppMacro if <typedef> is a known type definition
> (such as u8 or *_t).
> Subsequent cases will label <typedef> correctly as a type definition identifier.
Actually, there is a piece of important information that is missing in
both of these messages. It would be nice to say "Subsequent cases will
continue to label...".
julia
>
> Add bool also to the list of known type definition identifiers so that cases of
>
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-21 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 9:56 [Linux-kernel-mentees] [Cocci] [PATCH v2 0/3] cocci: Improve management of macros before typedefs Markus Elfring
2020-01-21 10:43 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).