From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Mrinal Pandey <mrinalmni@gmail.com>
Cc: linux-kernel@vger.kernel.org, joe@perches.com, apw@canonical.com,
Linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH] checkpatch: Fix the usage of capture group ( ... )
Date: Mon, 13 Jul 2020 21:31:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2007132130360.11844@felia> (raw)
In-Reply-To: <20200713043230.d7rhv6znvswt2h4u@mrinalpandey>
On Mon, 13 Jul 2020, Mrinal Pandey wrote:
> The usage of "capture group (...)" in the immediate condition after `&&`
> results in `$1` being uninitialized. This issues a warning "Use of
> uninitialized value $1 in regexp compilation at ./scripts/checkpatch.pl
> line 2638".
>
> I noticed this bug while running checkpatch on the set of commits from
> v5.7 to v5.8-rc1 of the kernel on the commits with a diff content in
> their commit message.
>
> This bug was introduced in the script by commit e518e9a59ec3
> ("checkpatch: emit an error when there's a diff in a changelog"). It has
> been in the script since then.
>
> The author intended to store the match made by capture group in variable
> `$1`. This should have contained the name of the file as `[\w/]+` matched.
> However, this couldn't be accomplished due to usage of capture group and
> `$1` in the same regular expression.
>
> Fix this by placing the capture group in the condition before `&&`.
> Thus, `$1` can be initialized to the text that capture group matches
> thereby setting it to the desired and required value.
>
> Signed-off-by: Mrinal Pandey <mrinalmni@gmail.com>
> ---
I have discussed the change on the mentees list before. So:
Reviewed-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
I ran ./scripts/checkpatch.pl on:
commit 6b3e0e2e0461 ("perf tools: Support CAP_PERFMON capability")
commit 19ce2321739d ("perf flamegraph: Use /bin/bash for report and record scripts")
before and after applying this patch.
On those two patches, checkpatch.pl emits the warning before,
and does not emit after this change. So:
Tested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Lukas
> scripts/checkpatch.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 4c820607540b..e73e998d582a 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2636,8 +2636,8 @@ sub process {
>
> # Check if the commit log has what seems like a diff which can confuse patch
> if ($in_commit_log && !$commit_log_has_diff &&
> - (($line =~ m@^\s+diff\b.*a/[\w/]+@ &&
> - $line =~ m@^\s+diff\b.*a/([\w/]+)\s+b/$1\b@) ||
> + (($line =~ m@^\s+diff\b.*a/([\w/]+)@ &&
> + $line =~ m@^\s+diff\b.*a/[\w/]+\s+b/$1\b@) ||
> $line =~ m@^\s*(?:\-\-\-\s+a/|\+\+\+\s+b/)@ ||
> $line =~ m/^\s*\@\@ \-\d+,\d+ \+\d+,\d+ \@\@/)) {
> ERROR("DIFF_IN_COMMIT_MSG",
> --
> 2.25.1
>
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-13 19:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 4:32 [Linux-kernel-mentees] [PATCH] checkpatch: Fix the usage of capture group ( ... ) Mrinal Pandey
2020-07-13 19:31 ` Lukas Bulwahn [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-11 15:44 Mrinal Pandey
2020-07-11 19:14 ` Lukas Bulwahn
2020-07-12 5:18 ` Mrinal Pandey
2020-07-12 7:18 ` Lukas Bulwahn
2020-07-12 12:19 ` Mrinal Pandey
2020-07-12 17:36 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2007132130360.11844@felia \
--to=lukas.bulwahn@gmail.com \
--cc=Linux-kernel-mentees@lists.linuxfoundation.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrinalmni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).