Re: [Linux-kernel-mentees] [PATCH RFC] kconfig: use interpreters to invoke scripts

[Lukas Bulwahn <lukas.bulwahn@gmail.com>]

On Sat, 3 Oct 2020, Ujjwal Kumar wrote:

> On 03/10/20 12:35 pm, Lukas Bulwahn wrote:
> > 
> > 
> > On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> > 
> >> On 02/10/20 9:20 am, Lukas Bulwahn wrote:
> >>>
> >>>
> >>> On Fri, 2 Oct 2020, Ujjwal Kumar wrote:
> >>>
> >>>> We cannot rely on execute bits to be set on files in the repository.
> >>>> The build script should use the explicit interpreter when invoking any 
> >>>> script from the repository.
> >>>>
> >>>> Link: https://lore.kernel.org/lkml/20200830174409.c24c3f67addcce0cea9a9d4c@linux-foundation.org/
> >>>> Link: https://lore.kernel.org/lkml/202008271102.FEB906C88@keescook/
> >>>>
> >>>> Suggested-by: Andrew Morton <akpm@linux-foundation.org>
> >>>> Suggested-by: Kees Cook <keescook@chromium.org>
> >>>> Suggested-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> >>>> Signed-off-by: Ujjwal Kumar <ujjwalkumar0501@gmail.com>
> >>>
> >>>
> >>> Ujjwal, you have nicely split the patches. I suggest you send out this 
> >>> patch and the patch "kbuild: use interpreters to incoke scripts" together 
> >>> as one patch series.
> >>>
> >>> You just need to write a cover letter and explain there which steps you 
> >>> did to find this being wrong before and what you did to test that it is 
> >>> now corrected.
> >>>
> >>> Also, can you please share on this list to whom/which lists you would send 
> >>> this patch series?Running 'get_maintainer.pl' script I get the following list.
> >>
> >> kconfig: use interpreters to invoke scripts-
> >>
> > 
> > Make those people explicitly to:
> > 
> >> Nathan Chancellor <natechancellor@gmail.com>
> >> Nick Desaulniers <ndesaulniers@google.com>
> > 
> > Nathan and Nick were working on the multi-compier support.
> > 
> >> Masahiro Yamada <masahiroy@kernel.org>
> > 
> > Masahiro-san is the important maintainer here.
> > also add Michal Marek.
> > 
> > I guess they are all optional:
> > 
> >> "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >> Masami Hiramatsu <mhiramat@kernel.org>
> >> Daniel Borkmann <daniel@iogearbox.net>
> >> Andrew Morton <akpm@linux-foundation.org>
> >> Krzysztof Kozlowski <krzk@kernel.org>
> >> Valentin Schneider <valentin.schneider@arm.com>
> >> Nick Terrell <terrelln@fb.com>
> >> "Eric W. Biederman" <ebiederm@xmission.com>
> >> Johannes Weiner <hannes@cmpxchg.org>
> > 
> > 
> > Yes, the mailing lists should be added:
> > 
> >> linux-kernel@vger.kernel.org
> >> clang-built-linux@googlegroups.com
> >>
> > 
> > also add the linux-kbuild mailing list.
> > 
> >>
> >> kbuild: use interpreters to invoke scripts-
> >>
> > 
> > These are the important maintainers:
> > 
> >> Masahiro Yamada <masahiroy@kernel.org>
> >> Michal Marek <michal.lkml@markovi.net>
> > 
> > 
> > I think these are mainly developers that some of the lines;
> > 
> > maybe just put them CC:
> > 
> >> Catalin Marinas <catalin.marinas@arm.com>
> >> Will Deacon <will@kernel.org>
> >> Tony Luck <tony.luck@intel.com>
> >> Fenghua Yu <fenghua.yu@intel.com>
> >> Nick Hu <nickhu@andestech.com>
> >> Greentime Hu <green.hu@gmail.com>
> >> Vincent Chen <deanbo422@gmail.com>
> >> Vincenzo Frascino <vincenzo.frascino@arm.com>
> >> Kees Cook <keescook@chromium.org>
> >> Nick Desaulniers <ndesaulniers@google.com>
> >> Alexander Popov <alex.popov@linux.com>
> >> Mark Brown <broonie@kernel.org>
> >> Sami Tolvanen <samitolvanen@google.com>
> >> Nathan Chancellor <natechancellor@gmail.com>
> >> Denis Efremov <efremov@linux.com>
> > 
> > 
> > Mailing lists looks good:
> > 
> >> linux-kbuild@vger.kernel.org
> >> linux-kernel@vger.kernel.org
> >> linux-arm-kernel@lists.infradead.org
> >> linux-ia64@vger.kernel.org
> >>
> > 
> > I think you have a good list.
> 
> For PATCH 1/2:
> Nathan Chancellor <natechancellor@gmail.com>
> Nick Desaulniers <ndesaulniers@google.com>
> Masahiro Yamada <masahiroy@kernel.org>
> Michal Marek <michal.lkml@markovi.net>
> linux-kbuild@vger.kernel.org
> linux-kernel@vger.kernel.org
> clang-built-linux@googlegroups.com
> linux-kernel-mentees@lists.linuxfoundation.org
> 
> For PATCH 2/2:
> Nathan Chancellor <natechancellor@gmail.com>
> Nick Desaulniers <ndesaulniers@google.com>
> Masahiro Yamada <masahiroy@kernel.org>
> Michal Marek <michal.lkml@markovi.net>
> linux-kbuild@vger.kernel.org
> linux-kernel@vger.kernel.org
> linux-arm-kernel@lists.infradead.org
> linux-ia64@vger.kernel.org
> linux-kernel-mentees@lists.linuxfoundation.org
> 
> Is it okay to send one patch from the series to a recipient and skip 
> the other patches?
> Should I merge recipients for each patch into one to create a common list 
> of recipients for all the patches (with cover letter) in the series?
> And send all the patches (with cover letter) to that common list.
>

Both options are fine. I think it is up to your personal preference.


Merging them is probably just easier to write a git send-email command.

Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees