From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org,
Ujjwal Kumar <ujjwalkumar0501@gmail.com>
Subject: Re: [Linux-kernel-mentees] [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS
Date: Wed, 14 Oct 2020 09:17:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.2010140908240.6186@felia> (raw)
In-Reply-To: <084a2dabe5463a3528bb052515555f939235c012.camel@perches.com>
On Tue, 13 Oct 2020, Joe Perches wrote:
> On Wed, 2020-10-14 at 08:47 +0200, Lukas Bulwahn wrote:
> >
> > On Tue, 13 Oct 2020, Joe Perches wrote:
> >
> > > On Wed, 2020-10-14 at 08:36 +0200, Lukas Bulwahn wrote:
> > > > On Tue, 13 Oct 2020, Joe Perches wrote:
> > > >
> > > > > On Wed, 2020-10-14 at 08:21 +0200, Lukas Bulwahn wrote:
> > > > > > What does checkpatch.pl warn about and what does clang-format still warn
> > > > > > about, which is generally accepted okay as style in the kernel?
> > > > >
> > > > > clang-format doesn't warn at all, it just reformats.
> > > > >
> > > > You can run clang-format with --dry-run and then it would just state the
> > > > proposed changes, right?
> > >
> > > clang-format through at least version 10 does not have
> > > a --dry-run option.
> > >
> > >
> >
> > Just a quick check:
> >
> > version 9 does not have the --dry-run option:
> >
> > https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormat.html
> >
> > version 10 does:
> >
> > https://releases.llvm.org/10.0.0/tools/clang/docs/ClangFormat.html
>
> Perhaps some version 10 variants do, but 10.0.0 does not.
>
> $ which clang-format
> /usr/local/bin/clang-format
> $ clang-format --version
> clang-format version 10.0.0 (git://github.com/llvm/llvm-project.git 305b961f64b75e73110e309341535f6d5a48ed72)
> $ clang-format --dry-run
> clang-format: Unknown command line argument '--dry-run'. Try: 'clang-format --help'
> clang-format: Did you mean ' --debug'?
>
Hmm... either the documentation is wrong; or the clang-format version
10.0.0 you are was an early version 10 during development before the
release and did not have that feature yet?
$ clang-format-10 --version
Ubuntu clang-format version
10.0.1-++20200928083909+ef32c611aa2-1~exp1~20200928185400.194
$ clang-format-10 --help | grep 'dry-run'
--dry-run - If set, do not actually make the formatting
changes
--ferror-limit=<uint> - Set the maximum number of clang-format
errors to emit before stopping (0 = no limit). Used only with --dry-run or -n
-n - Alias for --dry-run
You have probably seen that clang/llvm-11 was released; I guess a good
motivation for us to update our clang setup? :)
Lukas
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-10-14 7:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 12:01 [Linux-kernel-mentees] [RFC PATCH v2] checkpatch: add shebang check to EXECUTE_PERMISSIONS Ujjwal Kumar
2020-10-13 12:13 ` Ujjwal Kumar
2020-10-13 15:27 ` Joe Perches
2020-10-14 5:46 ` Lukas Bulwahn
2020-10-14 6:01 ` Joe Perches
2020-10-14 6:21 ` Lukas Bulwahn
2020-10-14 6:27 ` Joe Perches
2020-10-14 6:36 ` Lukas Bulwahn
2020-10-14 6:39 ` Joe Perches
2020-10-14 6:47 ` Lukas Bulwahn
2020-10-14 6:58 ` Joe Perches
2020-10-14 7:17 ` Lukas Bulwahn [this message]
2020-10-14 7:35 ` Joe Perches
2020-10-14 17:45 ` Miguel Ojeda
2020-10-14 18:05 ` Joe Perches
2020-10-14 18:32 ` Miguel Ojeda
2020-10-14 18:37 ` Joe Perches
2020-10-14 11:14 ` Ujjwal Kumar
2020-10-16 9:05 ` Ujjwal Kumar
2020-10-16 10:10 ` Lukas Bulwahn
2020-10-16 10:24 ` Dwaipayan Ray
2020-10-16 10:33 ` Lukas Bulwahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010140908240.6186@felia \
--to=lukas.bulwahn@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ujjwalkumar0501@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).