* [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default
@ 2020-04-14 23:09 Vitor Massaru Iha
2020-04-16 23:11 ` Brendan Higgins via Linux-kernel-mentees
0 siblings, 1 reply; 6+ messages in thread
From: Vitor Massaru Iha @ 2020-04-14 23:09 UTC (permalink / raw)
To: kunit-dev
Cc: linux-kernel-mentees, brendanhiggins, linux-kernel, linux-kselftest
To make KUnit easier to use, and to avoid overwriting object and
.config files, the default KUnit build directory is set to .kunit
* Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205221
Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
---
tools/testing/kunit/kunit.py | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
index 7dca74774dd2..5da190c79481 100755
--- a/tools/testing/kunit/kunit.py
+++ b/tools/testing/kunit/kunit.py
@@ -116,7 +116,7 @@ def main(argv, linux=None):
run_parser.add_argument('--build_dir',
help='As in the make command, it specifies the build '
'directory.',
- type=str, default='', metavar='build_dir')
+ type=str, default='.kunit', metavar='build_dir')
run_parser.add_argument('--defconfig',
help='Uses a default .kunitconfig.',
@@ -136,12 +136,11 @@ def main(argv, linux=None):
if get_kernel_root_path():
os.chdir(get_kernel_root_path())
- if cli_args.build_dir:
- if not os.path.exists(cli_args.build_dir):
- os.mkdir(cli_args.build_dir)
- kunit_kernel.kunitconfig_path = os.path.join(
- cli_args.build_dir,
- kunit_kernel.kunitconfig_path)
+ if not os.path.exists(cli_args.build_dir):
+ os.mkdir(cli_args.build_dir)
+ kunit_kernel.kunitconfig_path = os.path.join(
+ cli_args.build_dir,
+ kunit_kernel.kunitconfig_path)
if cli_args.defconfig:
create_default_kunitconfig()
--
2.25.1
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default
2020-04-14 23:09 [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default Vitor Massaru Iha
@ 2020-04-16 23:11 ` Brendan Higgins via Linux-kernel-mentees
2020-05-22 22:40 ` shuah
0 siblings, 1 reply; 6+ messages in thread
From: Brendan Higgins via Linux-kernel-mentees @ 2020-04-16 23:11 UTC (permalink / raw)
To: Vitor Massaru Iha
Cc: linux-kernel-mentees, Linux Kernel Mailing List,
open list:KERNEL SELFTEST FRAMEWORK, KUnit Development
On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <vitor@massaru.org> wrote:
>
> To make KUnit easier to use, and to avoid overwriting object and
> .config files, the default KUnit build directory is set to .kunit
>
> * Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205221
>
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default
2020-04-16 23:11 ` Brendan Higgins via Linux-kernel-mentees
@ 2020-05-22 22:40 ` shuah
2020-05-26 1:52 ` Vitor Massaru Iha
0 siblings, 1 reply; 6+ messages in thread
From: shuah @ 2020-05-22 22:40 UTC (permalink / raw)
To: Brendan Higgins, Vitor Massaru Iha
Cc: open list:KERNEL SELFTEST FRAMEWORK, shuah,
Linux Kernel Mailing List, David Gow, linux-kernel-mentees,
KUnit Development
On 4/16/20 5:11 PM, Brendan Higgins wrote:
> On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <vitor@massaru.org> wrote:
>>
>> To make KUnit easier to use, and to avoid overwriting object and
>> .config files, the default KUnit build directory is set to .kunit
>>
>> * Related bug: https://bugzilla.kernel.org/show_bug.cgi?id=205221
>>
>> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>
Applied the patch to kselftest/kunit on top of
45ba7a893ad89114e773b3dc32f6431354c465d6
kunit: kunit_tool: Separate out config/build/exec/parse
from David's work resolving merge conflicts. Please check if it is
sane.
thanks,
-- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default
2020-05-22 22:40 ` shuah
@ 2020-05-26 1:52 ` Vitor Massaru Iha
2020-05-26 2:27 ` Vitor Massaru Iha
0 siblings, 1 reply; 6+ messages in thread
From: Vitor Massaru Iha @ 2020-05-26 1:52 UTC (permalink / raw)
To: shuah, Brendan Higgins
Cc: open list:KERNEL SELFTEST FRAMEWORK, Linux Kernel Mailing List,
David Gow, linux-kernel-mentees, KUnit Development
Hi Shuah,
On Fri, 2020-05-22 at 16:40 -0600, shuah wrote:
> On 4/16/20 5:11 PM, Brendan Higgins wrote:
> > On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <
> > vitor@massaru.org> wrote:
> > > To make KUnit easier to use, and to avoid overwriting object and
> > > .config files, the default KUnit build directory is set to .kunit
> > >
> > > * Related bug:
> > > https://bugzilla.kernel.org/show_bug.cgi?id=205221
> > >
> > > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> >
> > Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> >
>
> Applied the patch to kselftest/kunit on top of
>
> 45ba7a893ad89114e773b3dc32f6431354c465d6
> kunit: kunit_tool: Separate out config/build/exec/parse
>
> from David's work resolving merge conflicts. Please check if it is
> sane.
>
> thanks,
> -- Shuah
The kunit branch had some problems related to identation. KUnit's code
has mixed identation, and with that, in conflict correction, it ended
up breaking python.
In addition I found a bug: related to the creation of the .kunitconfig
file inside the default build directory. Should I send the patch again?
Or do I make a bugfix patch?
BR,
Vitor
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default
2020-05-26 1:52 ` Vitor Massaru Iha
@ 2020-05-26 2:27 ` Vitor Massaru Iha
2020-05-26 13:58 ` Shuah Khan
0 siblings, 1 reply; 6+ messages in thread
From: Vitor Massaru Iha @ 2020-05-26 2:27 UTC (permalink / raw)
To: shuah, Brendan Higgins
Cc: open list:KERNEL SELFTEST FRAMEWORK, Linux Kernel Mailing List,
David Gow, linux-kernel-mentees, KUnit Development
On Mon, 2020-05-25 at 22:52 -0300, Vitor Massaru Iha wrote:
> Hi Shuah,
>
> On Fri, 2020-05-22 at 16:40 -0600, shuah wrote:
> > On 4/16/20 5:11 PM, Brendan Higgins wrote:
> > > On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <
> > > vitor@massaru.org> wrote:
> > > > To make KUnit easier to use, and to avoid overwriting object
> > > > and
> > > > .config files, the default KUnit build directory is set to
> > > > .kunit
> > > >
> > > > * Related bug:
> > > > https://bugzilla.kernel.org/show_bug.cgi?id=205221
> > > >
> > > > Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> > >
> > > Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> > >
> >
> > Applied the patch to kselftest/kunit on top of
> >
> > 45ba7a893ad89114e773b3dc32f6431354c465d6
> > kunit: kunit_tool: Separate out config/build/exec/parse
> >
> > from David's work resolving merge conflicts. Please check if it is
> > sane.
> >
> > thanks,
> > -- Shuah
>
> The kunit branch had some problems related to identation. KUnit's
> code
> has mixed identation, and with that, in conflict correction, it ended
> up breaking python.
>
> In addition I found a bug: related to the creation of the
> .kunitconfig
> file inside the default build directory.
This is actually related to the other patch "kunit: use KUnit defconfig
by default"
> Should I send the patch again?
> Or do I make a bugfix patch?
>
> BR,
> Vitor
>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default
2020-05-26 2:27 ` Vitor Massaru Iha
@ 2020-05-26 13:58 ` Shuah Khan
0 siblings, 0 replies; 6+ messages in thread
From: Shuah Khan @ 2020-05-26 13:58 UTC (permalink / raw)
To: Vitor Massaru Iha, shuah, Brendan Higgins
Cc: open list:KERNEL SELFTEST FRAMEWORK, Linux Kernel Mailing List,
David Gow, linux-kernel-mentees, KUnit Development
On 5/25/20 8:27 PM, Vitor Massaru Iha wrote:
> On Mon, 2020-05-25 at 22:52 -0300, Vitor Massaru Iha wrote:
>> Hi Shuah,
>>
>> On Fri, 2020-05-22 at 16:40 -0600, shuah wrote:
>>> On 4/16/20 5:11 PM, Brendan Higgins wrote:
>>>> On Tue, Apr 14, 2020 at 4:09 PM Vitor Massaru Iha <
>>>> vitor@massaru.org> wrote:
>>>>> To make KUnit easier to use, and to avoid overwriting object
>>>>> and
>>>>> .config files, the default KUnit build directory is set to
>>>>> .kunit
>>>>>
>>>>> * Related bug:
>>>>> https://bugzilla.kernel.org/show_bug.cgi?id=205221
>>>>>
>>>>> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
>>>>
>>>> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
>>>>
>>>
>>> Applied the patch to kselftest/kunit on top of
>>>
>>> 45ba7a893ad89114e773b3dc32f6431354c465d6
>>> kunit: kunit_tool: Separate out config/build/exec/parse
>>>
>>> from David's work resolving merge conflicts. Please check if it is
>>> sane.
>>>
>>> thanks,
>>> -- Shuah
>>
>> The kunit branch had some problems related to identation. KUnit's
>> code
>> has mixed identation, and with that, in conflict correction, it ended
>> up breaking python.
>>
Thanks for sanity checking my merge.
>> In addition I found a bug: related to the creation of the
>> .kunitconfig
>> file inside the default build directory.
>
> This is actually related to the other patch "kunit: use KUnit defconfig
> by default"
>
>
>> Should I send the patch again?
>> Or do I make a bugfix patch?
>>
Please send the fix.
thanks,
-- Shuah
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-26 13:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-14 23:09 [Linux-kernel-mentees] [RESEND] kunit: use --build_dir=.kunit as default Vitor Massaru Iha
2020-04-16 23:11 ` Brendan Higgins via Linux-kernel-mentees
2020-05-22 22:40 ` shuah
2020-05-26 1:52 ` Vitor Massaru Iha
2020-05-26 2:27 ` Vitor Massaru Iha
2020-05-26 13:58 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).