From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Zdenek Kabelac <zdenek.kabelac@gmail.com>,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [Bug 10030] Suspend doesn't work when SD card is inserted
Date: Wed, 20 Feb 2008 21:51:27 +0100 [thread overview]
Message-ID: <20080220215127.58b8ec70@mjolnir.drzeus.cx> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0802201418520.7056-100000@iolanthe.rowland.org>
On Wed, 20 Feb 2008 14:26:16 -0500 (EST)
Alan Stern <stern@rowland.harvard.edu> wrote:
>
> Do I understand this correctly? You've got special handling for the
> case where a bus handler doesn't have a resume routine, but no special
> handling for the case where it doesn't have a suspend routine?
Hmm... There should be checks for both, but the code seems to suggest otherwise.
> Why bother to remove the device if neither routine exists (there won't be
> any need to revive it since the bus never got suspended)?
The bus always gets suspended. The checks are to determine if state is saved or not. If it isn't, then a suspend/resume is treated as a removal/insertion.
> And why not simply fail the suspend if the resume routine doesn't exist
> and the suspend routine does? Maybe with an error message in the
> system log.
For the asymmetric case, I guess that would do. But I still want to remove devices when the bus handler has no suspend handling.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2008-02-20 20:51 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080219232338.E9A24108068@picon.linux-foundation.org>
2008-02-20 16:42 ` [Bug 10030] Suspend doesn't work when SD card is inserted Alan Stern
2008-02-20 17:30 ` Pierre Ossman
2008-02-20 19:26 ` Alan Stern
2008-02-20 20:51 ` Pierre Ossman [this message]
2008-02-20 20:58 ` Rafael J. Wysocki
2008-02-20 21:06 ` Alan Stern
2008-02-20 22:15 ` Rafael J. Wysocki
2008-02-20 22:24 ` Alan Stern
2008-02-20 22:41 ` Rafael J. Wysocki
2008-02-21 0:02 ` Rafael J. Wysocki
2008-02-21 16:27 ` Alan Stern
2008-02-21 16:38 ` Rafael J. Wysocki
2008-02-21 17:48 ` Alan Stern
2008-02-21 22:47 ` Rafael J. Wysocki
2008-02-21 23:05 ` Alan Stern
2008-02-23 1:30 ` Rafael J. Wysocki
2008-02-23 4:39 ` Alan Stern
2008-02-23 20:16 ` Rafael J. Wysocki
2008-02-23 23:29 ` Alan Stern
2008-02-24 0:19 ` Rafael J. Wysocki
2008-02-24 3:25 ` Alan Stern
2008-02-24 4:26 ` [linux-pm] " Alan Stern
2008-02-24 14:00 ` Rafael J. Wysocki
2008-02-24 15:33 ` Bugs in MMC [was: [Bug 10030] Suspend doesn't work when SD card is inserted] Alan Stern
2008-02-25 17:41 ` Pierre Ossman
2008-02-25 17:58 ` Alan Stern
2008-02-25 18:31 ` Pierre Ossman
2008-02-25 20:00 ` Alan Stern
2008-03-01 14:11 ` Pierre Ossman
2008-03-01 14:36 ` Alan Stern
2008-03-01 14:47 ` Pierre Ossman
2008-02-25 22:51 ` Felipe Balbi
2008-03-03 21:59 ` David Brownell
2008-03-04 6:03 ` Pierre Ossman
2008-03-04 9:44 ` David Brownell
2008-03-04 9:58 ` Pierre Ossman
2008-03-06 21:23 ` David Brownell
2008-03-04 17:53 ` Alan Stern
2008-03-04 18:53 ` David Brownell
2008-03-04 19:51 ` Alan Stern
2008-03-04 20:30 ` David Brownell
2008-03-04 21:00 ` Alan Stern
2008-03-06 15:55 ` Pavel Machek
2008-03-06 20:33 ` Alan Stern
2008-03-06 20:53 ` Zdenek Kabelac
2008-03-06 21:31 ` Rafael J. Wysocki
2008-03-04 17:50 ` Alan Stern
2008-02-24 13:33 ` [Bug 10030] Suspend doesn't work when SD card is inserted Rafael J. Wysocki
2008-02-24 20:25 ` Rafael J. Wysocki
2008-02-24 20:45 ` Alan Stern
2008-02-24 20:56 ` Rafael J. Wysocki
2008-02-24 21:11 ` Alan Stern
2008-02-24 22:18 ` Rafael J. Wysocki
2008-02-24 13:51 ` Rafael J. Wysocki
2008-02-24 19:27 ` Alan Stern
2008-02-24 19:42 ` Zdenek Kabelac
2008-02-24 20:09 ` Rafael J. Wysocki
2008-02-24 18:21 ` Pavel Machek
2008-02-24 19:03 ` Alan Stern
2008-02-24 20:11 ` Pavel Machek
2008-02-24 20:33 ` Alan Stern
2008-02-24 21:42 ` Pavel Machek
2008-02-24 22:21 ` Rafael J. Wysocki
2008-02-25 2:21 ` Alan Stern
2008-02-25 11:41 ` Rafael J. Wysocki
[not found] ` <c4e36d110802250402q7312a488idf752e07db7504e8@mail.gmail.com>
2008-02-25 12:31 ` Rafael J. Wysocki
2008-02-25 2:19 ` Alan Stern
2008-02-25 9:03 ` using long instead of atomic_t when only set/read is required (was Re: [Bug 10030] Suspend doesn't work when SD card is inserted) Pavel Machek
2008-02-25 14:46 ` Alan Stern
2008-03-03 12:08 ` [patch] Re: using long instead of atomic_t when only set/read is required Pavel Machek
2008-03-03 15:42 ` Alan Stern
2008-03-03 15:53 ` Alan Cox
2008-03-03 17:11 ` Alan Stern
2008-03-03 17:26 ` Linus Torvalds
2008-03-03 17:44 ` Pavel Machek
2008-03-03 19:27 ` Alan Stern
2008-03-06 15:58 ` Mark Lord
2008-03-06 16:11 ` Linus Torvalds
2008-03-06 16:27 ` Mark Lord
2008-03-03 17:16 ` Nick Piggin
2008-03-03 17:31 ` Paul E. McKenney
2008-03-03 17:33 ` Alan Cox
2008-03-03 17:22 ` Paul E. McKenney
2008-03-03 15:48 ` Alan Cox
2008-03-03 17:24 ` Pavel Machek
2008-03-03 20:27 ` Rafael J. Wysocki
2008-03-03 21:12 ` Paul E. McKenney
2008-03-03 22:23 ` Linus Torvalds
2008-03-04 23:32 ` Peter Hartley
2008-03-04 23:54 ` Rafael J. Wysocki
2008-03-05 0:26 ` Paul E. McKenney
2008-02-25 11:40 ` [Bug 10030] Suspend doesn't work when SD card is inserted Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080220215127.58b8ec70@mjolnir.drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).