linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@ucw.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Alan Stern <stern@rowland.harvard.edu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@osdl.org>,
	Zdenek Kabelac <zdenek.kabelac@gmail.com>,
	davem@davemloft.net, Pierre Ossman <drzeus-mmc@drzeus.cx>,
	Kernel development list <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Subject: Re: [patch] Re: using long instead of atomic_t when only set/read is required
Date: Mon, 3 Mar 2008 21:27:29 +0100	[thread overview]
Message-ID: <200803032127.30761.rjw@sisk.pl> (raw)
In-Reply-To: <20080303172410.GA13869@elf.ucw.cz>

On Monday, 3 of March 2008, Pavel Machek wrote:
> Hi!
> 
> > > Ok, so linux actually atomicity of long?
>                          ^~-- assumes should be here.
> 
> > No it doesn't. And even if it did you couldn't use long for this because
> > atomic_t also ensures the points operations complete are defined. You
> > might just about get away with volatile long * objects on x86 for simple
> > assignments but for anything else gcc can and will generate code to
> > update values whichever way it feels best - which includes turning
> > 
> > 	long *x = a + b;
> > 
> > into
> > 
> > 	*x = a;
> > 	*x += b;
> 
> Ok, I can understand the gcc side. But do we actually run on an
> architecture where
> 
> long *x;
> 
> *x = 0;
> 
> racing with 
> 
> *x = 0x12345678;
> 
> can produce
> 
> *x == 0x12340000;
> 
> or something like that?

Well something like this could happen, in theory, on a "32-bit" architecture
with a 16-bit bus.  In that case, one can imagine, the first word of the
first write may be sent through the bus immediately followed by the first
word of the second write, followed by the second word of the second
write and by the second word of the first write, in this order.

> I'm told RCU relies on architectures not doing this, and I'd like to get this
> clarified.

Yes, it would be good to know that for sure.

Rafael 

  reply	other threads:[~2008-03-03 20:29 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080219232338.E9A24108068@picon.linux-foundation.org>
2008-02-20 16:42 ` [Bug 10030] Suspend doesn't work when SD card is inserted Alan Stern
2008-02-20 17:30   ` Pierre Ossman
2008-02-20 19:26     ` Alan Stern
2008-02-20 20:51       ` Pierre Ossman
2008-02-20 20:58         ` Rafael J. Wysocki
2008-02-20 21:06         ` Alan Stern
2008-02-20 22:15           ` Rafael J. Wysocki
2008-02-20 22:24             ` Alan Stern
2008-02-20 22:41               ` Rafael J. Wysocki
2008-02-21  0:02               ` Rafael J. Wysocki
2008-02-21 16:27                 ` Alan Stern
2008-02-21 16:38                   ` Rafael J. Wysocki
2008-02-21 17:48                     ` Alan Stern
2008-02-21 22:47                       ` Rafael J. Wysocki
2008-02-21 23:05                         ` Alan Stern
2008-02-23  1:30                           ` Rafael J. Wysocki
2008-02-23  4:39                             ` Alan Stern
2008-02-23 20:16                               ` Rafael J. Wysocki
2008-02-23 23:29                                 ` Alan Stern
2008-02-24  0:19                                   ` Rafael J. Wysocki
2008-02-24  3:25                                     ` Alan Stern
2008-02-24  4:26                                       ` [linux-pm] " Alan Stern
2008-02-24 14:00                                         ` Rafael J. Wysocki
2008-02-24 15:33                                           ` Bugs in MMC [was: [Bug 10030] Suspend doesn't work when SD card is inserted] Alan Stern
2008-02-25 17:41                                             ` Pierre Ossman
2008-02-25 17:58                                               ` Alan Stern
2008-02-25 18:31                                                 ` Pierre Ossman
2008-02-25 20:00                                                   ` Alan Stern
2008-03-01 14:11                                                     ` Pierre Ossman
2008-03-01 14:36                                                       ` Alan Stern
2008-03-01 14:47                                                         ` Pierre Ossman
2008-02-25 22:51                                               ` Felipe Balbi
2008-03-03 21:59                                               ` David Brownell
2008-03-04  6:03                                                 ` Pierre Ossman
2008-03-04  9:44                                                   ` David Brownell
2008-03-04  9:58                                                     ` Pierre Ossman
2008-03-06 21:23                                                       ` David Brownell
2008-03-04 17:53                                                     ` Alan Stern
2008-03-04 18:53                                                       ` David Brownell
2008-03-04 19:51                                                         ` Alan Stern
2008-03-04 20:30                                                           ` David Brownell
2008-03-04 21:00                                                             ` Alan Stern
2008-03-06 15:55                                                               ` Pavel Machek
2008-03-06 20:33                                                                 ` Alan Stern
2008-03-06 20:53                                                                   ` Zdenek Kabelac
2008-03-06 21:31                                                                     ` Rafael J. Wysocki
2008-03-04 17:50                                                 ` Alan Stern
2008-02-24 13:33                                       ` [Bug 10030] Suspend doesn't work when SD card is inserted Rafael J. Wysocki
2008-02-24 20:25                                         ` Rafael J. Wysocki
2008-02-24 20:45                                           ` Alan Stern
2008-02-24 20:56                                             ` Rafael J. Wysocki
2008-02-24 21:11                                               ` Alan Stern
2008-02-24 22:18                                                 ` Rafael J. Wysocki
2008-02-24 13:51                                       ` Rafael J. Wysocki
2008-02-24 19:27                                         ` Alan Stern
2008-02-24 19:42                                           ` Zdenek Kabelac
2008-02-24 20:09                                             ` Rafael J. Wysocki
2008-02-24 18:21                                       ` Pavel Machek
2008-02-24 19:03                                         ` Alan Stern
2008-02-24 20:11                                           ` Pavel Machek
2008-02-24 20:33                                             ` Alan Stern
2008-02-24 21:42                                               ` Pavel Machek
2008-02-24 22:21                                                 ` Rafael J. Wysocki
2008-02-25  2:21                                                   ` Alan Stern
2008-02-25 11:41                                                     ` Rafael J. Wysocki
     [not found]                                                       ` <c4e36d110802250402q7312a488idf752e07db7504e8@mail.gmail.com>
2008-02-25 12:31                                                         ` Rafael J. Wysocki
2008-02-25  2:19                                                 ` Alan Stern
2008-02-25  9:03                                                   ` using long instead of atomic_t when only set/read is required (was Re: [Bug 10030] Suspend doesn't work when SD card is inserted) Pavel Machek
2008-02-25 14:46                                                     ` Alan Stern
2008-03-03 12:08                                                       ` [patch] Re: using long instead of atomic_t when only set/read is required Pavel Machek
2008-03-03 15:42                                                         ` Alan Stern
2008-03-03 15:53                                                           ` Alan Cox
2008-03-03 17:11                                                             ` Alan Stern
2008-03-03 17:26                                                               ` Linus Torvalds
2008-03-03 17:44                                                                 ` Pavel Machek
2008-03-03 19:27                                                                   ` Alan Stern
2008-03-06 15:58                                                                 ` Mark Lord
2008-03-06 16:11                                                                   ` Linus Torvalds
2008-03-06 16:27                                                                     ` Mark Lord
2008-03-03 17:16                                                             ` Nick Piggin
2008-03-03 17:31                                                               ` Paul E. McKenney
2008-03-03 17:33                                                               ` Alan Cox
2008-03-03 17:22                                                           ` Paul E. McKenney
2008-03-03 15:48                                                         ` Alan Cox
2008-03-03 17:24                                                           ` Pavel Machek
2008-03-03 20:27                                                             ` Rafael J. Wysocki [this message]
2008-03-03 21:12                                                               ` Paul E. McKenney
2008-03-03 22:23                                                               ` Linus Torvalds
2008-03-04 23:32                                                             ` Peter Hartley
2008-03-04 23:54                                                               ` Rafael J. Wysocki
2008-03-05  0:26                                                                 ` Paul E. McKenney
2008-02-25 11:40                                                   ` [Bug 10030] Suspend doesn't work when SD card is inserted Rafael J. Wysocki
2008-03-05 17:07 [patch] Re: using long instead of atomic_t when only set/read is required Matti Linnanvuori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803032127.30761.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davem@davemloft.net \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=stern@rowland.harvard.edu \
    --cc=torvalds@linux-foundation.org \
    --cc=zdenek.kabelac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).