From: Palmer Dabbelt <palmer@dabbelt.com>
To: linux-riscv@lists.infradead.org
Cc: daniel.lezcano@linaro.org, tglx@linutronix.de,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Palmer Dabbelt <palmerdabbelt@google.com>,
kernel test robot <lkp@intel.com>
Subject: [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi()
Date: Mon, 21 Dec 2020 21:32:30 -0800 [thread overview]
Message-ID: <20201222053230.3229427-1-palmer@dabbelt.com> (raw)
From: Palmer Dabbelt <palmerdabbelt@google.com>
This cast loses the __iomem qualifier from clint_timer_val, which
triggers an sparse warning.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
drivers/clocksource/timer-clint.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-clint.c b/drivers/clocksource/timer-clint.c
index 6cfe2ab73eb0..83a8b38d46f6 100644
--- a/drivers/clocksource/timer-clint.c
+++ b/drivers/clocksource/timer-clint.c
@@ -63,7 +63,7 @@ static struct riscv_ipi_ops clint_ipi_ops = {
#define clint_get_cycles() readq_relaxed(clint_timer_val)
#else
#define clint_get_cycles() readl_relaxed(clint_timer_val)
-#define clint_get_cycles_hi() readl_relaxed(((u32 *)clint_timer_val) + 1)
+#define clint_get_cycles_hi() readl_relaxed(((u32 __iomem *)clint_timer_val) + 1)
#endif
#ifdef CONFIG_64BIT
--
2.29.2.729.g45daf8777d-goog
next reply other threads:[~2020-12-22 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 5:32 Palmer Dabbelt [this message]
2020-12-22 9:34 ` [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi() David Laight
2020-12-23 8:23 ` Christoph Hellwig
2020-12-24 2:59 ` Palmer Dabbelt
2020-12-24 6:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222053230.3229427-1-palmer@dabbelt.com \
--to=palmer@dabbelt.com \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmerdabbelt@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).