From: Christoph Hellwig <hch@infradead.org>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: linux-riscv@lists.infradead.org, daniel.lezcano@linaro.org,
kernel test robot <lkp@intel.com>,
Palmer Dabbelt <palmerdabbelt@google.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
kernel-team@android.com
Subject: Re: [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi()
Date: Wed, 23 Dec 2020 08:23:30 +0000 [thread overview]
Message-ID: <20201223082330.GA24581@infradead.org> (raw)
In-Reply-To: <20201222053230.3229427-1-palmer@dabbelt.com>
On Mon, Dec 21, 2020 at 09:32:30PM -0800, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> This cast loses the __iomem qualifier from clint_timer_val, which
> triggers an sparse warning.
I'm not a native speaker, but the subject line sounds strange to me.
Shouldn't this be:
"don't cast away the __iommu annotation"
or something similar?
Also this adds an overly long line. Otherwise it looks fine.
next prev parent reply other threads:[~2020-12-23 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 5:32 [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi() Palmer Dabbelt
2020-12-22 9:34 ` David Laight
2020-12-23 8:23 ` Christoph Hellwig [this message]
2020-12-24 2:59 ` Palmer Dabbelt
2020-12-24 6:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223082330.GA24581@infradead.org \
--to=hch@infradead.org \
--cc=daniel.lezcano@linaro.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=palmer@dabbelt.com \
--cc=palmerdabbelt@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).