From: Palmer Dabbelt <palmer@dabbelt.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-riscv@lists.infradead.org, daniel.lezcano@linaro.org,
lkp@intel.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
kernel-team@android.com
Subject: Re: [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi()
Date: Wed, 23 Dec 2020 18:59:34 -0800 (PST) [thread overview]
Message-ID: <mhng-b2cf0325-66e1-4e3c-bfbb-b393963fbb3f@palmerdabbelt-glaptop> (raw)
In-Reply-To: <20201223082330.GA24581@infradead.org>
On Wed, 23 Dec 2020 00:23:30 PST (-0800), Christoph Hellwig wrote:
> On Mon, Dec 21, 2020 at 09:32:30PM -0800, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> This cast loses the __iomem qualifier from clint_timer_val, which
>> triggers an sparse warning.
>
> I'm not a native speaker, but the subject line sounds strange to me.
> Shouldn't this be:
>
> "don't cast away the __iommu annotation"
>
> or something similar?
The title is also nonsense, I was probably trying to do two things at once when
I wrote this. I'll send another one.
> Also this adds an overly long line. Otherwise it looks fine.
Aren't we OK with lines longer than 80 characters now? Or was that some other
project? checkpatch doesn't complain, which I guess is why I didn't notice, so
hopefully that means I'm not crazy (though I guess the commit message and title
don't provide the best argument there... ;)).
next prev parent reply other threads:[~2020-12-24 3:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 5:32 [PATCH] clocksource: clint: Avoid remove __iomem in get_cycles_hi() Palmer Dabbelt
2020-12-22 9:34 ` David Laight
2020-12-23 8:23 ` Christoph Hellwig
2020-12-24 2:59 ` Palmer Dabbelt [this message]
2020-12-24 6:39 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-b2cf0325-66e1-4e3c-bfbb-b393963fbb3f@palmerdabbelt-glaptop \
--to=palmer@dabbelt.com \
--cc=daniel.lezcano@linaro.org \
--cc=hch@infradead.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lkp@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).