* [PATCHv3] selftests/timers: Turn off timeout setting
@ 2020-03-18 2:42 Po-Hsu Lin
2020-07-23 9:01 ` Po-Hsu Lin
2020-08-04 21:38 ` John Stultz
0 siblings, 2 replies; 5+ messages in thread
From: Po-Hsu Lin @ 2020-03-18 2:42 UTC (permalink / raw)
To: linux-kselftest
Cc: shuah, sboyd, tglx, john.stultz, joe.lawrence, linux-kernel
The following 4 tests in timers can take longer than the default 45
seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh:
Add 45 second timeout per test") to run:
* nsleep-lat - 2m7.350s
* set-timer-lat - 2m0.66s
* inconsistency-check - 1m45.074s
* raw_skew - 2m0.013s
Thus they will be marked as failed with the current 45s setting:
not ok 3 selftests: timers: nsleep-lat # TIMEOUT
not ok 4 selftests: timers: set-timer-lat # TIMEOUT
not ok 6 selftests: timers: inconsistency-check # TIMEOUT
not ok 7 selftests: timers: raw_skew # TIMEOUT
Disable the timeout setting for timers can make these tests finish
properly:
ok 3 selftests: timers: nsleep-lat
ok 4 selftests: timers: set-timer-lat
ok 6 selftests: timers: inconsistency-check
ok 7 selftests: timers: raw_skew
https://bugs.launchpad.net/bugs/1864626
Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
tools/testing/selftests/timers/Makefile | 1 +
tools/testing/selftests/timers/settings | 1 +
2 files changed, 2 insertions(+)
create mode 100644 tools/testing/selftests/timers/settings
diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
index 7656c7c..0e73a16 100644
--- a/tools/testing/selftests/timers/Makefile
+++ b/tools/testing/selftests/timers/Makefile
@@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)
+TEST_FILES := settings
include ../lib.mk
diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
new file mode 100644
index 0000000..e7b9417
--- /dev/null
+++ b/tools/testing/selftests/timers/settings
@@ -0,0 +1 @@
+timeout=0
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCHv3] selftests/timers: Turn off timeout setting
2020-03-18 2:42 [PATCHv3] selftests/timers: Turn off timeout setting Po-Hsu Lin
@ 2020-07-23 9:01 ` Po-Hsu Lin
2020-08-04 21:21 ` Shuah Khan
2020-08-04 21:38 ` John Stultz
1 sibling, 1 reply; 5+ messages in thread
From: Po-Hsu Lin @ 2020-07-23 9:01 UTC (permalink / raw)
To: linux-kselftest
Cc: shuah, sboyd, tglx, John Stultz, joe.lawrence, linux-kernel, Shuah Khan
(Adding Shuah's linuxfoundation mail)
Hello,
do you need more changes / tests for this test?
Thanks!
Po-Hsu
On Wed, Mar 18, 2020 at 10:42 AM Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
>
> The following 4 tests in timers can take longer than the default 45
> seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh:
> Add 45 second timeout per test") to run:
> * nsleep-lat - 2m7.350s
> * set-timer-lat - 2m0.66s
> * inconsistency-check - 1m45.074s
> * raw_skew - 2m0.013s
>
> Thus they will be marked as failed with the current 45s setting:
> not ok 3 selftests: timers: nsleep-lat # TIMEOUT
> not ok 4 selftests: timers: set-timer-lat # TIMEOUT
> not ok 6 selftests: timers: inconsistency-check # TIMEOUT
> not ok 7 selftests: timers: raw_skew # TIMEOUT
>
> Disable the timeout setting for timers can make these tests finish
> properly:
> ok 3 selftests: timers: nsleep-lat
> ok 4 selftests: timers: set-timer-lat
> ok 6 selftests: timers: inconsistency-check
> ok 7 selftests: timers: raw_skew
>
> https://bugs.launchpad.net/bugs/1864626
> Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
> tools/testing/selftests/timers/Makefile | 1 +
> tools/testing/selftests/timers/settings | 1 +
> 2 files changed, 2 insertions(+)
> create mode 100644 tools/testing/selftests/timers/settings
>
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index 7656c7c..0e73a16 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
>
> TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)
>
> +TEST_FILES := settings
>
> include ../lib.mk
>
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCHv3] selftests/timers: Turn off timeout setting
2020-07-23 9:01 ` Po-Hsu Lin
@ 2020-08-04 21:21 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2020-08-04 21:21 UTC (permalink / raw)
To: Po-Hsu Lin, linux-kselftest
Cc: shuah, sboyd, tglx, John Stultz, joe.lawrence, linux-kernel, Shuah Khan
On 7/23/20 3:01 AM, Po-Hsu Lin wrote:
> (Adding Shuah's linuxfoundation mail)
> Hello,
> do you need more changes / tests for this test?
>
> Thanks!
> Po-Hsu
>
I was hoping to get Ack from timers test maintainers.
Will pull this in for my fixes update.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCHv3] selftests/timers: Turn off timeout setting
2020-03-18 2:42 [PATCHv3] selftests/timers: Turn off timeout setting Po-Hsu Lin
2020-07-23 9:01 ` Po-Hsu Lin
@ 2020-08-04 21:38 ` John Stultz
2020-08-10 20:48 ` Shuah Khan
1 sibling, 1 reply; 5+ messages in thread
From: John Stultz @ 2020-08-04 21:38 UTC (permalink / raw)
To: Po-Hsu Lin
Cc: linux-kselftest, Shuah Khan, Stephen Boyd, Thomas Gleixner,
joe.lawrence, lkml
On Tue, Mar 17, 2020 at 7:42 PM Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
>
> The following 4 tests in timers can take longer than the default 45
> seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh:
> Add 45 second timeout per test") to run:
> * nsleep-lat - 2m7.350s
> * set-timer-lat - 2m0.66s
> * inconsistency-check - 1m45.074s
> * raw_skew - 2m0.013s
>
> Thus they will be marked as failed with the current 45s setting:
> not ok 3 selftests: timers: nsleep-lat # TIMEOUT
> not ok 4 selftests: timers: set-timer-lat # TIMEOUT
> not ok 6 selftests: timers: inconsistency-check # TIMEOUT
> not ok 7 selftests: timers: raw_skew # TIMEOUT
>
> Disable the timeout setting for timers can make these tests finish
> properly:
> ok 3 selftests: timers: nsleep-lat
> ok 4 selftests: timers: set-timer-lat
> ok 6 selftests: timers: inconsistency-check
> ok 7 selftests: timers: raw_skew
>
> https://bugs.launchpad.net/bugs/1864626
> Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
> tools/testing/selftests/timers/Makefile | 1 +
> tools/testing/selftests/timers/settings | 1 +
> 2 files changed, 2 insertions(+)
> create mode 100644 tools/testing/selftests/timers/settings
>
> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
> index 7656c7c..0e73a16 100644
> --- a/tools/testing/selftests/timers/Makefile
> +++ b/tools/testing/selftests/timers/Makefile
> @@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
>
> TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)
>
> +TEST_FILES := settings
>
> include ../lib.mk
>
> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
> new file mode 100644
> index 0000000..e7b9417
> --- /dev/null
> +++ b/tools/testing/selftests/timers/settings
> @@ -0,0 +1 @@
> +timeout=0
> --
Apologies for missing this before. I've not tested with this, but it
sounds sane to me. A number of the timekeeping tests do take a while
to run.
Acked-by: John Stultz <john.stultz@linaro.org>
thanks
-john
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCHv3] selftests/timers: Turn off timeout setting
2020-08-04 21:38 ` John Stultz
@ 2020-08-10 20:48 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2020-08-10 20:48 UTC (permalink / raw)
To: John Stultz, Po-Hsu Lin
Cc: linux-kselftest, Shuah Khan, Stephen Boyd, Thomas Gleixner,
joe.lawrence, lkml, Shuah Khan
On 8/4/20 3:38 PM, John Stultz wrote:
> On Tue, Mar 17, 2020 at 7:42 PM Po-Hsu Lin <po-hsu.lin@canonical.com> wrote:
>>
>> The following 4 tests in timers can take longer than the default 45
>> seconds that added in commit 852c8cbf34d3 ("selftests/kselftest/runner.sh:
>> Add 45 second timeout per test") to run:
>> * nsleep-lat - 2m7.350s
>> * set-timer-lat - 2m0.66s
>> * inconsistency-check - 1m45.074s
>> * raw_skew - 2m0.013s
>>
>> Thus they will be marked as failed with the current 45s setting:
>> not ok 3 selftests: timers: nsleep-lat # TIMEOUT
>> not ok 4 selftests: timers: set-timer-lat # TIMEOUT
>> not ok 6 selftests: timers: inconsistency-check # TIMEOUT
>> not ok 7 selftests: timers: raw_skew # TIMEOUT
>>
>> Disable the timeout setting for timers can make these tests finish
>> properly:
>> ok 3 selftests: timers: nsleep-lat
>> ok 4 selftests: timers: set-timer-lat
>> ok 6 selftests: timers: inconsistency-check
>> ok 7 selftests: timers: raw_skew
>>
>> https://bugs.launchpad.net/bugs/1864626
>> Fixes: 852c8cbf34d3 ("selftests/kselftest/runner.sh: Add 45 second timeout per test")
>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>> ---
>> tools/testing/selftests/timers/Makefile | 1 +
>> tools/testing/selftests/timers/settings | 1 +
>> 2 files changed, 2 insertions(+)
>> create mode 100644 tools/testing/selftests/timers/settings
>>
>> diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile
>> index 7656c7c..0e73a16 100644
>> --- a/tools/testing/selftests/timers/Makefile
>> +++ b/tools/testing/selftests/timers/Makefile
>> @@ -13,6 +13,7 @@ DESTRUCTIVE_TESTS = alarmtimer-suspend valid-adjtimex adjtick change_skew \
>>
>> TEST_GEN_PROGS_EXTENDED = $(DESTRUCTIVE_TESTS)
>>
>> +TEST_FILES := settings
>>
>> include ../lib.mk
>>
>> diff --git a/tools/testing/selftests/timers/settings b/tools/testing/selftests/timers/settings
>> new file mode 100644
>> index 0000000..e7b9417
>> --- /dev/null
>> +++ b/tools/testing/selftests/timers/settings
>> @@ -0,0 +1 @@
>> +timeout=0
>> --
>
> Apologies for missing this before. I've not tested with this, but it
> sounds sane to me. A number of the timekeeping tests do take a while
> to run.
>
> Acked-by: John Stultz <john.stultz@linaro.org>
>
Thanks. I will get this in for 5.9-rc2 fixes update.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-10 20:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-18 2:42 [PATCHv3] selftests/timers: Turn off timeout setting Po-Hsu Lin
2020-07-23 9:01 ` Po-Hsu Lin
2020-08-04 21:21 ` Shuah Khan
2020-08-04 21:38 ` John Stultz
2020-08-10 20:48 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).