* [PATCH kunit] kunit: building kunit as a module breaks allmodconfig
@ 2020-01-10 11:49 Alan Maguire
2020-01-10 21:39 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Alan Maguire @ 2020-01-10 11:49 UTC (permalink / raw)
To: skhan, brendanhiggins, gregkh
Cc: rafael, jmorris, serge, knut.omang, linux-kernel,
linux-security-module, kunit-dev, linux-kselftest, sfr,
Alan Maguire
kunit tests that do not support module build should depend
on KUNIT=y rather than just KUNIT in Kconfig, otherwise
they will trigger compilation errors for "make allmodconfig"
builds.
Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/base/Kconfig | 2 +-
security/apparmor/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/Kconfig b/drivers/base/Kconfig
index c3b3b5c..5f0bc74 100644
--- a/drivers/base/Kconfig
+++ b/drivers/base/Kconfig
@@ -150,7 +150,7 @@ config DEBUG_TEST_DRIVER_REMOVE
config PM_QOS_KUNIT_TEST
bool "KUnit Test for PM QoS features"
- depends on KUNIT
+ depends on KUNIT=y
config HMEM_REPORTING
bool
diff --git a/security/apparmor/Kconfig b/security/apparmor/Kconfig
index d547930..0fe3368 100644
--- a/security/apparmor/Kconfig
+++ b/security/apparmor/Kconfig
@@ -71,7 +71,7 @@ config SECURITY_APPARMOR_DEBUG_MESSAGES
config SECURITY_APPARMOR_KUNIT_TEST
bool "Build KUnit tests for policy_unpack.c"
- depends on KUNIT && SECURITY_APPARMOR
+ depends on KUNIT=y && SECURITY_APPARMOR
help
This builds the AppArmor KUnit tests.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH kunit] kunit: building kunit as a module breaks allmodconfig
2020-01-10 11:49 [PATCH kunit] kunit: building kunit as a module breaks allmodconfig Alan Maguire
@ 2020-01-10 21:39 ` Shuah Khan
2020-01-14 2:18 ` Brendan Higgins
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2020-01-10 21:39 UTC (permalink / raw)
To: Alan Maguire, brendanhiggins, gregkh
Cc: rafael, jmorris, serge, knut.omang, linux-kernel,
linux-security-module, kunit-dev, linux-kselftest, sfr,
Shuah Khan
Hi Alan,
On 1/10/20 4:49 AM, Alan Maguire wrote:
> kunit tests that do not support module build should depend
> on KUNIT=y rather than just KUNIT in Kconfig, otherwise
> they will trigger compilation errors for "make allmodconfig"
> builds.
>
> Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Thanks for fixing this quickly. For future reference, Signed-off-by
should be last. I fixed it and applied the patch.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH kunit] kunit: building kunit as a module breaks allmodconfig
2020-01-10 21:39 ` Shuah Khan
@ 2020-01-14 2:18 ` Brendan Higgins
0 siblings, 0 replies; 3+ messages in thread
From: Brendan Higgins @ 2020-01-14 2:18 UTC (permalink / raw)
To: Shuah Khan
Cc: Alan Maguire, Greg KH, rafael, jmorris, serge, Knut Omang,
Linux Kernel Mailing List, linux-security-module,
KUnit Development, open list:KERNEL SELFTEST FRAMEWORK,
Stephen Rothwell
On Fri, Jan 10, 2020 at 1:39 PM Shuah Khan <skhan@linuxfoundation.org> wrote:
>
> Hi Alan,
>
> On 1/10/20 4:49 AM, Alan Maguire wrote:
> > kunit tests that do not support module build should depend
> > on KUNIT=y rather than just KUNIT in Kconfig, otherwise
> > they will trigger compilation errors for "make allmodconfig"
> > builds.
> >
> > Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> > Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Thanks for fixing this quickly. For future reference, Signed-off-by
> should be last. I fixed it and applied the patch.
Thanks everyone for taking care of this so quickly in my absence!
Cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-14 2:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-10 11:49 [PATCH kunit] kunit: building kunit as a module breaks allmodconfig Alan Maguire
2020-01-10 21:39 ` Shuah Khan
2020-01-14 2:18 ` Brendan Higgins
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).