From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com> To: "lee.jones@linaro.org" <lee.jones@linaro.org> Cc: "dmurphy@ti.com" <dmurphy@ti.com>, "linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>, "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>, "mazziesaccount@gmail.com" <mazziesaccount@gmail.com>, "mturquette@baylibre.com" <mturquette@baylibre.com>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "a.zummo@towertech.it" <a.zummo@towertech.it>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "sboyd@kernel.org" <sboyd@kernel.org>, "pavel@ucw.cz" <pavel@ucw.cz>, "jacek.anaszewski@gmail.com" <jacek.anaszewski@gmail.com>, "broonie@kernel.org" <broonie@kernel.org> Subject: Re: [PATCH v10 08/13] regulator: bd718x7: Split driver to common and bd718x7 specific parts Date: Mon, 20 Jan 2020 07:06:16 +0000 Message-ID: <11054d0ec82b0dc0fd07970db86c596ba137c0ef.camel@fi.rohmeurope.com> (raw) In-Reply-To: <20200117134026.GM15507@dell> Hello, On Fri, 2020-01-17 at 13:40 +0000, Lee Jones wrote: > On Fri, 17 Jan 2020, Vaittinen, Matti wrote: > > > > > > > > +enum { > > > > + ROHM_DVS_LEVEL_UNKNOWN, > > > > + ROHM_DVS_LEVEL_RUN, > > > > + ROHM_DVS_LEVEL_IDLE, > > > > + ROHM_DVS_LEVEL_SUSPEND, > > > > + ROHM_DVS_LEVEL_LPSR, > > > > +#define ROHM_DVS_LEVEL_MAX ROHM_DVS_LEVEL_LPSR > > > > > > Haven't seen this before. Is it legit? > > > > > > > I don't know why it wouldn't be :) I kind of grew used to that when > > I > > still did some networking stuff. > > Networking it not a good example. > > It's full of odd little quirks to the standard styling. That was quite a strong wording... Some people might disagree :) Anyways, as far as I know the preprocessor does not care about where the preprocessor directives are placed. It just goes through the file sequentially and macro definitions take effect at the place you write them. And actual compiler does not see the directive - just code which has been replaced. So from C point of view I see no problem here. From coding conventions or guidelines point of view - well, that's more of your territory ;) > > What about: > > > ROHM_DVS_LEVEL_MAX = ROHM_DVS_LEVEL_LPSR > > > > Anyways, I don't see why define wouldn't be Ok here - but sure it > > can > > be changed if you insist ;) Just let me know if you can accept the > > define or not :) > > Let's go for not in this instance. :D Ok. I sent v11 where this has been changed as you suggested :) Br, --Matti
next prev parent reply index Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-17 9:30 [PATCH v10 00/13] Support ROHM BD71828 PMIC Matti Vaittinen 2020-01-17 9:31 ` [PATCH v10 01/13] dt-bindings: leds: ROHM BD71282 PMIC LED driver Matti Vaittinen 2020-01-17 9:32 ` [PATCH v10 02/13] dt-bindings: mfd: Document ROHM BD71828 bindings Matti Vaittinen 2020-01-17 9:34 ` [PATCH v10 03/13] mfd: rohm PMICs - use platform_device_id to match MFD sub-devices Matti Vaittinen 2020-01-17 9:35 ` [PATCH v10 04/13] mfd: bd718x7: Add compatible for BD71850 Matti Vaittinen 2020-01-17 9:36 ` [PATCH v10 05/13] mfd: bd71828: Support ROHM BD71828 PMIC - core Matti Vaittinen 2020-01-17 9:36 ` [PATCH v10 06/13] mfd: input: bd71828: Add power-key support Matti Vaittinen 2020-01-17 9:37 ` [PATCH v10 07/13] clk: bd718x7: Support ROHM BD71828 clk block Matti Vaittinen 2020-01-17 9:38 ` [PATCH v10 08/13] regulator: bd718x7: Split driver to common and bd718x7 specific parts Matti Vaittinen 2020-01-17 10:28 ` Lee Jones 2020-01-17 10:43 ` Vaittinen, Matti 2020-01-17 13:40 ` Lee Jones 2020-01-20 7:06 ` Vaittinen, Matti [this message] 2020-01-17 9:40 ` [PATCH v10 09/13] mfd: bd70528: Fix hour register mask Matti Vaittinen 2020-01-17 10:21 ` Lee Jones 2020-01-17 9:42 ` [PATCH v10 10/13] rtc: bd70528: add BD71828 support Matti Vaittinen 2020-01-17 9:42 ` [PATCH v10 11/13] gpio: bd71828: Initial support for ROHM BD71828 PMIC GPIOs Matti Vaittinen 2020-01-17 10:21 ` Lee Jones 2020-01-20 6:48 ` Vaittinen, Matti 2020-01-20 8:02 ` Lee Jones 2020-01-23 15:18 ` Linus Walleij 2020-01-17 9:43 ` [PATCH v10 12/13] leds: Add common LED binding parsing support to LED class/core Matti Vaittinen 2020-01-20 8:56 ` Vaittinen, Matti 2020-01-17 9:44 ` [PATCH v10 13/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC Matti Vaittinen 2020-01-17 10:30 ` [PATCH v10 00/13] Support " Lee Jones 2020-01-17 10:48 ` Vaittinen, Matti 2020-01-17 13:44 ` Lee Jones 2020-02-26 13:42 ` Pavel Machek 2020-02-26 14:25 ` Vaittinen, Matti
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=11054d0ec82b0dc0fd07970db86c596ba137c0ef.camel@fi.rohmeurope.com \ --to=matti.vaittinen@fi.rohmeurope.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=bgolaszewski@baylibre.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=jacek.anaszewski@gmail.com \ --cc=lee.jones@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-leds@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mazziesaccount@gmail.com \ --cc=mturquette@baylibre.com \ --cc=pavel@ucw.cz \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-LEDs Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-leds/0 linux-leds/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-leds linux-leds/ https://lore.kernel.org/linux-leds \ linux-leds@vger.kernel.org public-inbox-index linux-leds Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-leds AGPL code for this site: git clone https://public-inbox.org/public-inbox.git