* [PATCH] leds: lgm: fix gpiolib dependency
@ 2021-03-08 15:30 Arnd Bergmann
2021-03-09 18:08 ` Intel, please maintain your drivers was " Pavel Machek
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2021-03-08 15:30 UTC (permalink / raw)
To: Pavel Machek, Amireddy Mallikarjuna reddy
Cc: Arnd Bergmann, Dan Murphy, linux-leds, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without gpiolib, the driver fails to build:
drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
struct gpio_chip chip;
^
include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
struct gpio_chip;
^
drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
gpiod_set_value(led->gpiod, val);
^
drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
static inline void gpio_set_value(unsigned gpio, int value)
^
drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
gpiod_set_value(led->gpiod, 1);
^
Add the dependency in Kconfig.
Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/leds/blink/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 265b53476a80..6dedc58c47b3 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -9,6 +9,7 @@ if LEDS_BLINK
config LEDS_BLINK_LGM
tristate "LED support for Intel LGM SoC series"
+ depends on GPIOLIB
depends on LEDS_CLASS
depends on MFD_SYSCON
depends on OF
--
2.29.2
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Intel, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
2021-03-08 15:30 [PATCH] leds: lgm: fix gpiolib dependency Arnd Bergmann
@ 2021-03-09 18:08 ` Pavel Machek
2021-03-09 19:39 ` Pavel Machek
0 siblings, 1 reply; 10+ messages in thread
From: Pavel Machek @ 2021-03-09 18:08 UTC (permalink / raw)
To: Arnd Bergmann, rafael.j.wysocki
Cc: Amireddy Mallikarjuna reddy, Arnd Bergmann, Dan Murphy,
linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Hi!
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without gpiolib, the driver fails to build:
>
> drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
> struct gpio_chip chip;
> ^
Thanks, applied.
I'd like people from Intel to contact me. There's more to fix there,
and AFAICT original author went away.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Intel, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
2021-03-09 18:08 ` Intel, please maintain your drivers was " Pavel Machek
@ 2021-03-09 19:39 ` Pavel Machek
2021-03-10 1:19 ` MaxLinear, " Adam Borowski
0 siblings, 1 reply; 10+ messages in thread
From: Pavel Machek @ 2021-03-09 19:39 UTC (permalink / raw)
To: Arnd Bergmann, rafael.j.wysocki
Cc: Amireddy Mallikarjuna reddy, Arnd Bergmann, Dan Murphy,
linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]
Hi!
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Without gpiolib, the driver fails to build:
> >
> > drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
> > struct gpio_chip chip;
> > ^
>
> Thanks, applied.
>
> I'd like people from Intel to contact me. There's more to fix there,
> and AFAICT original author went away.
The following message to <mallikarjunax.reddy@linux.intel.com> was
undeliverable.
The reason for the problem:
5.1.0 - Unknown address error 550-'5.1.1
<mallikarjunax.reddy@linux.intel.com>: Recipient
+address rejected: User unknown in virtual mailbox table'
commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Signed-off-by: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
If someone knows how to contact the author, that would be welcome.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
2021-03-09 19:39 ` Pavel Machek
@ 2021-03-10 1:19 ` Adam Borowski
2021-03-10 7:28 ` Pavel Machek
0 siblings, 1 reply; 10+ messages in thread
From: Adam Borowski @ 2021-03-10 1:19 UTC (permalink / raw)
To: Pavel Machek
Cc: Arnd Bergmann, rafael.j.wysocki, Arnd Bergmann, Dan Murphy,
linux-leds, linux-kernel
On Tue, Mar 09, 2021 at 08:39:10PM +0100, Pavel Machek wrote:
> > I'd like people from Intel to contact me. There's more to fix there,
> > and AFAICT original author went away.
>
> The following message to <mallikarjunax.reddy@linux.intel.com> was
> undeliverable.
> <mallikarjunax.reddy@linux.intel.com>: Recipient
> +address rejected: User unknown in virtual mailbox table'
> commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
> Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
together with the rest of the Connected Home Division. So he most likely
still works on this stuff, just under a different banner.
> If someone knows how to contact the author, that would be welcome.
Alas, no idea about his MaxLinear address.
Meow!
--
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁ in the beginning was the boot and root floppies and they were good.
⢿⡄⠘⠷⠚⠋⠀ -- <willmore> on #linux-sunxi
⠈⠳⣄⠀⠀⠀⠀
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
2021-03-10 1:19 ` MaxLinear, " Adam Borowski
@ 2021-03-10 7:28 ` Pavel Machek
2021-03-10 16:57 ` Arnd Bergmann
0 siblings, 1 reply; 10+ messages in thread
From: Pavel Machek @ 2021-03-10 7:28 UTC (permalink / raw)
To: Adam Borowski
Cc: Arnd Bergmann, rafael.j.wysocki, Arnd Bergmann, Dan Murphy,
linux-leds, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]
Hi!
> > > I'd like people from Intel to contact me. There's more to fix there,
> > > and AFAICT original author went away.
> >
> > The following message to <mallikarjunax.reddy@linux.intel.com> was
> > undeliverable.
>
> > <mallikarjunax.reddy@linux.intel.com>: Recipient
> > +address rejected: User unknown in virtual mailbox table'
>
> > commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
> > Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
>
> I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
> together with the rest of the Connected Home Division. So he most likely
> still works on this stuff, just under a different banner.
>
> > If someone knows how to contact the author, that would be welcome.
>
> Alas, no idea about his MaxLinear address.
Thanks for the effort. Anyway, I suspect I'll just do this:
BR,
Pavel
diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
index 6dedc58c47b3..79493f21d365 100644
--- a/drivers/leds/blink/Kconfig
+++ b/drivers/leds/blink/Kconfig
@@ -1,14 +1,6 @@
-menuconfig LEDS_BLINK
- bool "LED Blink support"
- depends on LEDS_CLASS
- help
- This option enables blink support for the leds class.
- If unsure, say Y.
-
-if LEDS_BLINK
-
config LEDS_BLINK_LGM
tristate "LED support for Intel LGM SoC series"
+ depends on BROKEN
depends on GPIOLIB
depends on LEDS_CLASS
depends on MFD_SYSCON
@@ -17,5 +9,3 @@ config LEDS_BLINK_LGM
Parallel to serial conversion, which is also called SSO controller,
can drive external shift register for LED outputs.
This enables LED support for Serial Shift Output controller(SSO).
-
-endif # LEDS_BLINK
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
2021-03-10 7:28 ` Pavel Machek
@ 2021-03-10 16:57 ` Arnd Bergmann
2021-03-10 20:17 ` Hauke Mehrtens
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2021-03-10 16:57 UTC (permalink / raw)
To: Pavel Machek
Cc: Adam Borowski, Rafael J. Wysocki, Dan Murphy, linux-leds,
linux-kernel, Hauke Mehrtens, John Crispin
On Wed, Mar 10, 2021 at 8:30 AM Pavel Machek <pavel@ucw.cz> wrote:
>
> Hi!
>
> > > > I'd like people from Intel to contact me. There's more to fix there,
> > > > and AFAICT original author went away.
> > >
> > > The following message to <mallikarjunax.reddy@linux.intel.com> was
> > > undeliverable.
> >
> > > <mallikarjunax.reddy@linux.intel.com>: Recipient
> > > +address rejected: User unknown in virtual mailbox table'
> >
> > > commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
> > > Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
> >
> > I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
> > together with the rest of the Connected Home Division. So he most likely
> > still works on this stuff, just under a different banner.
> >
> > > If someone knows how to contact the author, that would be welcome.
> >
> > Alas, no idea about his MaxLinear address.
>
> Thanks for the effort. Anyway, I suspect I'll just do this:
Maybe Hauke or John (added both to cc) know who at MaxLinear is
responsible for maintaining the Lightning Mountain drivers now.
Arnd
> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
> index 6dedc58c47b3..79493f21d365 100644
> --- a/drivers/leds/blink/Kconfig
> +++ b/drivers/leds/blink/Kconfig
> @@ -1,14 +1,6 @@
> -menuconfig LEDS_BLINK
> - bool "LED Blink support"
> - depends on LEDS_CLASS
> - help
> - This option enables blink support for the leds class.
> - If unsure, say Y.
> -
> -if LEDS_BLINK
> -
> config LEDS_BLINK_LGM
> tristate "LED support for Intel LGM SoC series"
> + depends on BROKEN
> depends on GPIOLIB
> depends on LEDS_CLASS
> depends on MFD_SYSCON
> @@ -17,5 +9,3 @@ config LEDS_BLINK_LGM
> Parallel to serial conversion, which is also called SSO controller,
> can drive external shift register for LED outputs.
> This enables LED support for Serial Shift Output controller(SSO).
> -
> -endif # LEDS_BLINK
>
>
> --
> http://www.livejournal.com/~pavelmachek
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: MaxLinear, please maintain your drivers was Re: [PATCH] leds: lgm: fix gpiolib dependency
2021-03-10 16:57 ` Arnd Bergmann
@ 2021-03-10 20:17 ` Hauke Mehrtens
[not found] ` <MN2PR19MB3486B88ADF5BE557BEE168AEAF909@MN2PR19MB3486.namprd19.prod.outlook.com>
0 siblings, 1 reply; 10+ messages in thread
From: Hauke Mehrtens @ 2021-03-10 20:17 UTC (permalink / raw)
To: Arnd Bergmann, Pavel Machek, qwu
Cc: Adam Borowski, Rafael J. Wysocki, Dan Murphy, linux-leds,
linux-kernel, John Crispin, Hauke Mehrtens
On 3/10/21 5:57 PM, Arnd Bergmann wrote:
> On Wed, Mar 10, 2021 at 8:30 AM Pavel Machek <pavel@ucw.cz> wrote:
>>
>> Hi!
>>
>>>>> I'd like people from Intel to contact me. There's more to fix there,
>>>>> and AFAICT original author went away.
>>>>
>>>> The following message to <mallikarjunax.reddy@linux.intel.com> was
>>>> undeliverable.
>>>
>>>> <mallikarjunax.reddy@linux.intel.com>: Recipient
>>>> +address rejected: User unknown in virtual mailbox table'
>>>
>>>> commit c3987cd2bca34ddfec69027acedb2fae5ffcf7a0
>>>> Author: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
>>>
>>> I asked around, and got told Mallikarjuna has been "sold" to MaxLinear,
>>> together with the rest of the Connected Home Division. So he most likely
>>> still works on this stuff, just under a different banner.
>>>
>>>> If someone knows how to contact the author, that would be welcome.
>>>
>>> Alas, no idea about his MaxLinear address.
>>
>> Thanks for the effort. Anyway, I suspect I'll just do this:
>
> Maybe Hauke or John (added both to cc) know who at MaxLinear is
> responsible for maintaining the Lightning Mountain drivers now.
>
> Arnd
Hi Qiming,
It looks like there are some problems and potential fixes for the led
driver Mallikarjuna added to the Linux kernel for LGM some time ago.
Could you please take care of this request from Pavel and Arnd.
Hauke
>
>> diff --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig
>> index 6dedc58c47b3..79493f21d365 100644
>> --- a/drivers/leds/blink/Kconfig
>> +++ b/drivers/leds/blink/Kconfig
>> @@ -1,14 +1,6 @@
>> -menuconfig LEDS_BLINK
>> - bool "LED Blink support"
>> - depends on LEDS_CLASS
>> - help
>> - This option enables blink support for the leds class.
>> - If unsure, say Y.
>> -
>> -if LEDS_BLINK
>> -
>> config LEDS_BLINK_LGM
>> tristate "LED support for Intel LGM SoC series"
>> + depends on BROKEN
>> depends on GPIOLIB
>> depends on LEDS_CLASS
>> depends on MFD_SYSCON
>> @@ -17,5 +9,3 @@ config LEDS_BLINK_LGM
>> Parallel to serial conversion, which is also called SSO controller,
>> can drive external shift register for LED outputs.
>> This enables LED support for Serial Shift Output controller(SSO).
>> -
>> -endif # LEDS_BLINK
>>
>>
>> --
>> http://www.livejournal.com/~pavelmachek
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-16 9:20 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 15:30 [PATCH] leds: lgm: fix gpiolib dependency Arnd Bergmann
2021-03-09 18:08 ` Intel, please maintain your drivers was " Pavel Machek
2021-03-09 19:39 ` Pavel Machek
2021-03-10 1:19 ` MaxLinear, " Adam Borowski
2021-03-10 7:28 ` Pavel Machek
2021-03-10 16:57 ` Arnd Bergmann
2021-03-10 20:17 ` Hauke Mehrtens
[not found] ` <MN2PR19MB3486B88ADF5BE557BEE168AEAF909@MN2PR19MB3486.namprd19.prod.outlook.com>
[not found] ` <MW2PR1901MB2187816296E1B03F91EB972BD0909@MW2PR1901MB2187.namprd19.prod.outlook.com>
[not found] ` <MN2PR19MB3693B7620DABED199AA304B5B1909@MN2PR19MB3693.namprd19.prod.outlook.com>
2021-03-11 10:00 ` Arnd Bergmann
2021-03-16 9:19 ` Rahul Tanwar
2021-03-13 10:24 ` Pavel Machek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).