From: Rob Herring <robh@kernel.org>
To: Hermes Zhang <chenhui.zhang@axis.com>
Cc: pavel@ucw.cz, dmurphy@ti.com, linux-leds@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
chenhuiz@axis.com, lkml@axis.com, kernel@axis.com
Subject: Re: [PATCH v2 1/2] dt-binding: leds: Document leds-multi-gpio bindings
Date: Sat, 27 Mar 2021 12:12:22 -0600 [thread overview]
Message-ID: <20210327181222.GA327657@robh.at.kernel.org> (raw)
In-Reply-To: <20210326052801.17666-2-chenhui.zhang@axis.com>
On Fri, Mar 26, 2021 at 01:28:00PM +0800, Hermes Zhang wrote:
> From: Hermes Zhang <chenhuiz@axis.com>
>
> This binding represents LED devices which are controller with
> multiple GPIO lines in order to achieve more than two brightness
> states.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
> .../bindings/leds/leds-multi-gpio.yaml | 50 +++++++++++++++++++
> 1 file changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml b/Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml
> new file mode 100644
> index 000000000000..1549f21e8d6e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-multi-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Multiple GPIOs LED driver
> +
> +maintainers:
> + - Hermes Zhang <chenhuiz@axis.com>
> +
> +description:
> + This will support some LED made of multiple GPIOs and the brightness of the
> + LED could map to different states of the GPIOs.
> +
> +properties:
> + compatible:
> + const: multi-gpio-led
> +
> + led-gpios:
> + description: Array of one or more GPIOs pins used to control the LED.
> + minItems: 1
> + maxItems: 8 # Should be enough
> +
> + led-states:
> + description: |
> + The array list the supported states here which will map to brightness
> + from 0 to maximum. Each item in the array will present all the GPIOs
> + value by bit.
> + $ref: /schemas/types.yaml#/definitions/uint8-array
> + minItems: 1
> + maxItems: 256 # Should be enough
Isn't this the same as the standard 'brightness-levels' from backlight
binding? The index is the level and the value is the h/w specific
setting.
> +
> +required:
> + - compatible
> + - led-gpios
> + - led-states
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpios-led {
> + compatible = "multi-gpio-led";
> +
> + led-gpios = <&gpio0 23 0x1>,
> + <&gpio0 24 0x1>;
> + led-states = /bits/ 8 <0x00 0x01 0x02 0x03>;
> + };
> +...
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-03-27 18:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 5:27 [PATCH v2 0/2] New multiple GPIOs LED driver Hermes Zhang
2021-03-26 5:28 ` [PATCH v2 1/2] dt-binding: leds: Document leds-multi-gpio bindings Hermes Zhang
2021-03-27 18:12 ` Rob Herring [this message]
2021-03-29 6:03 ` Hermes Zhang
2021-03-26 5:28 ` [PATCH v2 2/2] leds: leds-multi-gpio: Add multiple GPIOs LED driver Hermes Zhang
2021-03-26 5:56 ` Alexander Dahl
2021-03-26 6:07 ` Hermes Zhang
2021-03-26 13:49 ` Pavel Machek
2021-03-29 6:00 ` Hermes Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210327181222.GA327657@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chenhui.zhang@axis.com \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lkml@axis.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).