From: Pavel Machek <pavel@ucw.cz>
To: Jiri Kosina <jikos@kernel.org>
Cc: Roderick Colenbrander <thunderbird2k@gmail.com>,
Roderick Colenbrander <roderick@gaikai.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input <linux-input@vger.kernel.org>,
linux-leds@vger.kernel.org,
"Daniel J . Ogorchock" <djogorchock@gmail.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH v3 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.
Date: Fri, 22 Oct 2021 09:21:15 +0200 [thread overview]
Message-ID: <20211022072115.GA25215@amd> (raw)
In-Reply-To: <nycvar.YFH.7.76.2110220840340.12554@cbobk.fhfr.pm>
[-- Attachment #1: Type: text/plain, Size: 1137 bytes --]
On Fri 2021-10-22 08:42:06, Jiri Kosina wrote:
> On Mon, 18 Oct 2021, Jiri Kosina wrote:
>
> > > Ok, so let's put it in the common place. I'll take this patch through
> > > LED tree if you resubmit it. You still may want to use local defines
> > > so you can apply the other patches without waiting.
> >
> > Pavel, why complicate it so much? Given how trivial the patch is, the
> > easiest way is what's usually done in such cases (where substantial patch
> > depends on a tiny trivial change elsewhere) -- take it through HID tree
> > with your Reviewed-by / Acked-by:.
> >
> > Do you see any issue with that?
>
> Pavel, another week has passed. I am considering just including the
> trivial LED #define additions and take them through hid.git unless I hear
> from you today.
I'd prefer not to deal with rejects / common immutable branches / etc.
You don't _need_ the defines at all, and you don't need them in the
common place. Just merge the patch without the defines. I'll merge the
defines. That seems like least complex solution to me.
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2021-10-22 7:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 16:55 [PATCH v3 0/3] HID: playstation: add LED support Roderick Colenbrander
2021-09-08 16:55 ` [PATCH v3 1/3] HID: playstation: expose DualSense lightbar through a multi-color LED Roderick Colenbrander
2021-09-08 16:55 ` [PATCH v3 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers Roderick Colenbrander
2021-09-22 9:50 ` Jiri Kosina
2021-09-27 14:11 ` Pavel Machek
2021-09-27 16:29 ` Roderick Colenbrander
2021-10-07 10:34 ` Jiri Kosina
2021-10-13 7:48 ` Pavel Machek
2021-10-13 17:20 ` Roderick Colenbrander
2021-10-18 15:40 ` Jiri Kosina
2021-10-22 6:42 ` Jiri Kosina
2021-10-22 7:21 ` Pavel Machek [this message]
2021-10-22 7:27 ` Jiri Kosina
2021-10-22 7:32 ` Jiri Kosina
2021-10-25 9:19 ` Pavel Machek
2021-10-25 9:36 ` Jiri Kosina
2021-10-26 18:48 ` Pavel Machek
2021-10-27 7:50 ` Jiri Kosina
2021-09-08 16:55 ` [PATCH v3 3/3] HID: playstation: expose DualSense player LEDs through LED class Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211022072115.GA25215@amd \
--to=pavel@ucw.cz \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
--cc=thunderbird2k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).