From: Jiri Kosina <jikos@kernel.org>
To: Roderick Colenbrander <roderick@gaikai.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Pavel Machek <pavel@ucw.cz>,
linux-input@vger.kernel.org, linux-leds@vger.kernel.org,
"Daniel J . Ogorchock" <djogorchock@gmail.com>,
Roderick Colenbrander <roderick.colenbrander@sony.com>
Subject: Re: [PATCH v3 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers.
Date: Wed, 22 Sep 2021 11:50:34 +0200 (CEST) [thread overview]
Message-ID: <nycvar.YFH.7.76.2109221150110.15944@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210908165539.3102929-3-roderick.colenbrander@sony.com>
On Wed, 8 Sep 2021, Roderick Colenbrander wrote:
> Player LEDs are commonly found on game controllers from Nintendo and Sony
> to indicate a player ID across a number of LEDs. For example, "Player 2"
> might be indicated as "-x--" on a device with 4 LEDs where "x" means on.
>
> This patch introduces LED_FUNCTION_PLAYER1-5 defines to properly indicate
> player LEDs from the kernel. Until now there was no good standard, which
> resulted in inconsistent behavior across xpad, hid-sony, hid-wiimote and
> other drivers. Moving forward new drivers should use LED_FUNCTION_PLAYERx.
>
> Note: management of Player IDs is left to user space, though a kernel
> driver may pick a default value.
>
> Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
> ---
> Documentation/leds/well-known-leds.txt | 14 ++++++++++++++
> include/dt-bindings/leds/common.h | 7 +++++++
> 2 files changed, 21 insertions(+)
Pavel, could you please eventually Ack this, so that I can take it
together with the rest?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-09-22 9:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 16:55 [PATCH v3 0/3] HID: playstation: add LED support Roderick Colenbrander
2021-09-08 16:55 ` [PATCH v3 1/3] HID: playstation: expose DualSense lightbar through a multi-color LED Roderick Colenbrander
2021-09-08 16:55 ` [PATCH v3 2/3] leds: add new LED_FUNCTION_PLAYER for player LEDs for game controllers Roderick Colenbrander
2021-09-22 9:50 ` Jiri Kosina [this message]
2021-09-27 14:11 ` Pavel Machek
2021-09-27 16:29 ` Roderick Colenbrander
2021-10-07 10:34 ` Jiri Kosina
2021-10-13 7:48 ` Pavel Machek
2021-10-13 17:20 ` Roderick Colenbrander
2021-10-18 15:40 ` Jiri Kosina
2021-10-22 6:42 ` Jiri Kosina
2021-10-22 7:21 ` Pavel Machek
2021-10-22 7:27 ` Jiri Kosina
2021-10-22 7:32 ` Jiri Kosina
2021-10-25 9:19 ` Pavel Machek
2021-10-25 9:36 ` Jiri Kosina
2021-10-26 18:48 ` Pavel Machek
2021-10-27 7:50 ` Jiri Kosina
2021-09-08 16:55 ` [PATCH v3 3/3] HID: playstation: expose DualSense player LEDs through LED class Roderick Colenbrander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2109221150110.15944@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=djogorchock@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=roderick.colenbrander@sony.com \
--cc=roderick@gaikai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).